Maniphest T153720

PayPal EC response processor needs to act on "recurring" flag
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

We're not hitting the code that calls CreateRecurringPaymentsProfile, presumably because the recurring flag isn't passed through to the response processor. We might have to include that in the return_url.

Details

	Subject	Repo	Branch	Lines +/-
	Add recurring flag to PayPal Return URL	mediawiki/extensions/DonationInterface	master	+8 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Pcoombe	T170255 WMF Fundraising 2017-18 - Japan (5 September - 3 October)
		Resolved		None	T87621 [epic] PayPal upgrade
		Resolved		awight	T131800 Spike: Internal Test Express Checkout in Japan to prove feasability of method
		Resolved		None	T131815 Paypay Express checkout internal test
		Resolved		Ejegg	T123001 Convert PayPal interstitial form from RapidHTML to Mustache
		Invalid		None	T130852 Debug gateway account name handling
		Resolved		awight	T134452 Spike: Decide whether PayPal Express Checkout is a new gateway, payment method, or account name.
		Resolved		None	T130843 [Epic] Support PayPal Express Checkout NVP API
		Resolved		awight	T131806 Get Express Checkout production credentials
		Resolved		awight	T136743 Support API certificate authentication
					Restricted Task
		Resolved		XenoRyet	T131816 Paypal Express checkout 1 hour test
		Open		None	T138013 Epic: Distinguish PayPal legacy vs. Express Checkout transactions
		Resolved		XenoRyet	T130851 Make PayPal listener understand Express Checkout
		Resolved		Ejegg	T131817 Paypal Express checkout campaign ready
		Resolved		awight	T134605 Update audit parser for PayPal Express Checkout
		Resolved		Ejegg	T134446 [Epic] Support Express Checkout recurring donations
		Resolved		XenoRyet	T153720 PayPal EC response processor needs to act on "recurring" flag

Event Timeline

awight created this task.Dec 19 2016, 10:50 PM

• ggellerman moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Dec 20 2016, 10:14 PM

XenoRyet claimed this task.Jan 30 2017, 9:22 PM

XenoRyet added a project: Fundraising Sprint Baudelaire Bowdlerizer.

XenoRyet moved this task from Backlog to Doing on the Fundraising Sprint Baudelaire Bowdlerizer board.

According to the docs, PayPal only appends the 'token' and 'PayerID' parameters:
https://developer.paypal.com/docs/integration/direct/payments/create-process-order/

So we just need to add recurring=1 to the return URL

Ejegg moved this task from Sprint +1 to Current Sprint and Completed in Q3 2016-17 on the Fundraising-Backlog board.Feb 2 2017, 9:13 PM

XenoRyet added a project: Fundraising Sprint Costlier Alternative.Feb 8 2017, 6:24 PM

XenoRyet moved this task from Backlog to Doing on the Fundraising Sprint Costlier Alternative board.

Change 336666 had a related patch set uploaded (by XenoRyet):
Add recurring flag to PayPal Return URL

https://gerrit.wikimedia.org/r/336666

gerritbot added a project: Patch-For-Review.Feb 8 2017, 7:45 PM

Change 336666 merged by jenkins-bot:
Add recurring flag to PayPal Return URL

https://gerrit.wikimedia.org/r/336666

XenoRyet moved this task from Doing to Review on the Fundraising Sprint Costlier Alternative board.Feb 8 2017, 8:19 PM

Ejegg moved this task from Backlog to 1-hour test on the FR-PayPal-ExpressCheckout board.Feb 8 2017, 8:38 PM

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)).Feb 8 2017, 9:00 PM

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Costlier Alternative board.Feb 8 2017, 9:55 PM

• DStrine added a project: Fundraising Sprint Deferential Equations.Feb 15 2017, 11:53 PM

XenoRyet moved this task from Backlog to Doing on the Fundraising Sprint Deferential Equations board.Feb 16 2017, 12:20 AM

XenoRyet moved this task from Doing to Done on the Fundraising Sprint Deferential Equations board.Feb 17 2017, 12:52 AM

Ejegg closed this task as Resolved.Mar 1 2017, 11:54 PM

Ejegg set the point value for this task to 1.

• mmodell removed a subscriber: awight.Jun 22 2017, 9:44 PM

• DStrine moved this task from Pending Deployment to Done on the Fundraising Sprint Costlier Alternative board.Aug 29 2017, 9:02 PM