Page MenuHomePhabricator
Create Task
Maniphest T154341

Research the usage of NewsletterDeletionUpdate (and probably remove it)
Closed, ResolvedPublic
Actions

Description

Currently, it does not look like the NewsletterDeletionUpdate class does anything. It looks like it is an unnecessary class that doesn't add any new functionality. Please research and/or confirm this. If indeed it is useless, remove it from the extension.

Details

SubjectRepoBranchLines +/-
Remove unnecessary class NewsletterDeletionUpdatemediawiki/extensions/Newslettermaster+0 -36
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DuplicateQgilT125545 Phabricator Q&A session for Community Liaisons
 ResolvedQgilT116025 Goal: Align Community Liaison and Developer Relations project management practices
 ResolvedQgilT119387 Community Liaison and Developer Relation quarterly goals for January - March 2016
 DeclinedNoneT104131 Exporting existing newsletter to the Newsletter extension
 ResolvedAddshoreT110170 Goal: Deploy Newsletter extension in Wikimedia
 DuplicateNoneT115098 Deploy Newsletter extension in beta cluster
 ResolvedoriT127297 Add the Newsletter extension to the Beta Cluster
 ResolvedBawolffT115095 Security review of Newsletter extension
 ResolvedGlaisherT116382 Raw html should be escaped before output in Newsletter pages
 ResolvedTinaj1234T110491 Newsletter extension should have validation
 DeclinedNoneT131616 Cap the number of active newsletters per user
 ResolvedGlaisherT132016 Add CheckUser integration to Extension:Newsletter
 Resolved01tonythomasT132018 Add newsletter description to log messages
 ResolvedGlaisherT132017 Throttle for newsletter announcements
 Resolved01tonythomasT132019 Add table prefix to sub-queries in NewsletterTablePager
 ResolvedPpperyT132022 Add AbuseFilter integration to Extension:Newsletter
 ResolvedDaimonaT135668 Need documentation on How to integrate AbuseFilter with xyz extension
 ResolvedDaimonaT239348 Custom actions should always be included in the list of available actions
 Resolved01tonythomasT119058 Special:Newsletter fatals if the newsletter main page is deleted
 ResolvedQgilT154229 Agree first user group that will be able to create newsletters in Wikimedia
 ResolvedFilipT154534 Restrict 'newsletter-{create,manage,destroy}' only to 'sysop' by default
 ResolvedxSavitarT159075 Fix character escaping throughout the extension files
ResolvedNoneT159084 [Security] Fix inconsistent Newsletter user rights
Resolved01tonythomasT159085 [Security] Improve data attribute naming to avoid forge
 Resolved01tonythomasT160854 Newsletter strange behaviour on an API create/edit
Resolved01tonythomasT140402 Namespace is repeated in notification link
 Resolved01tonythomasT138462 Convert Newsletter to use ContentHandler
 ResolvedPpperyT154341 Research the usage of NewsletterDeletionUpdate (and probably remove it)

Event Timeline

MtDu created this task.Dec 30 2016, 11:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 30 2016, 11:28 PM
MtDu added a parent task: T138462: Convert Newsletter to use ContentHandler.Dec 30 2016, 11:30 PM
01tonythomas moved this task from Backlog to Google Code In 2016 on the MediaWiki-extensions-Newsletter board.Dec 30 2016, 11:33 PM
01tonythomas added a project: Google-Code-In-2016.Dec 31 2016, 1:35 PM

Imported as https://codein.withgoogle.com/dashboard/tasks/4888252748136448/ waiting for one of the admins to approve.

Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Dec 31 2016, 1:55 PM
Pppery claimed this task.Dec 31 2016, 8:00 PM
gerritbot subscribed.Dec 31 2016, 8:09 PM

Change 329804 had a related patch set uploaded (by Pppery):
Remove unnecessary class NewsletterDeletionUpdate

https://gerrit.wikimedia.org/r/329804

gerritbot added a project: Patch-For-Review.Dec 31 2016, 8:09 PM
Pppery added a comment.Dec 31 2016, 8:10 PM

The class is indeed redundant; the functionality it provides it also implemented in Newsletter.hooks.php in OnArticleDelete.

01tonythomas closed this task as Resolved.Dec 31 2016, 10:33 PM

Killed with fire :D Thank you!

gerritbot added a comment.Dec 31 2016, 10:34 PM

Change 329804 merged by jenkins-bot:
Remove unnecessary class NewsletterDeletionUpdate

https://gerrit.wikimedia.org/r/329804

Qgil awarded a token.Jan 7 2017, 10:28 AM
Pppery removed a project: Patch-For-Review.Feb 9 2017, 2:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits