Add the Newsletter extension to the Beta Cluster
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Qgil
	Feb 18 2016, 11:55 AM

Description

~~Hi, it is not very clear how to request the addition of an extension to the Beta Cluster. Said that...~~
https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment#Deploy_to_beta_cluster_on_Labs

This is a request to add https://www.mediawiki.org/wiki/Extension:Newsletter aka MediaWiki-extensions-Newsletter

Currently the extension is functional, and we keep working polishing it. It is available in http://newsletter-test.wmflabs.org/ only, and we have requested T115095: Security review of Newsletter extension. A logical next step is to have this extension available for testing in the Beta Cluster.

NOTE: https://deployment.wikimedia.beta.wmflabs.org/wiki/Special:Newsletters

Details

	Subject	Repo	Branch	Lines +/-
	Add Newsletter extension to beta	operations/mediawiki-config	master	+8 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Duplicate	Qgil	T125545 Phabricator Q&A session for Community Liaisons
Resolved	Qgil	T116025 Goal: Align Community Liaison and Developer Relations project management practices
Resolved	Qgil	T119387 Community Liaison and Developer Relation quarterly goals for January - March 2016
Declined	None	T104131 Exporting existing newsletter to the Newsletter extension
Resolved	Addshore	T110170 Goal: Deploy Newsletter extension in Wikimedia
Resolved	ori	T127297 Add the Newsletter extension to the Beta Cluster
Resolved	Bawolff	T115095 Security review of Newsletter extension
Resolved	Glaisher	T116382 Raw html should be escaped before output in Newsletter pages
Resolved	Tinaj1234	T110491 Newsletter extension should have validation
Declined	None	T131616 Cap the number of active newsletters per user
Resolved	Glaisher	T132016 Add CheckUser integration to Extension:Newsletter
Resolved	01tonythomas	T132018 Add newsletter description to log messages
Resolved	01tonythomas	T138462 Convert Newsletter to use ContentHandler
Resolved	nikitavbv	T149645 Upon creating newsletter, the confirmation message do not show link to new newsletter
Invalid	None	T149647 Fix the warning after removing subscription to newsletter
Resolved	Filip	T149648 Upon deleting a newsletter, the message shows Newsletter ID
Duplicate	None	T149649 Upon deleting a newsletter, do not show the subtitle navigation on top
Resolved	01tonythomas	T149651 Clear 'nl_*' tables in http://newsletter-test.wmflabs.org/
Resolved	Filip	T150090 Warnings thrown up on creating a new newsletter via Special:CreateNewsletter
Resolved	MtDu	T150095 newsletter-create-editsummary is not defined
Resolved	MtDu	T150125 Implement Undeleting a newsletter from the Logs
Resolved	Georggi199	T152678 Remove default view (Special:Newsletter/id/) code from SpecialNewsletter.php
Resolved	Filip	T154120 Remove unused SpecialNewsletter:getNewsletterActionButtons()
Resolved	Pppery	T154341 Research the usage of NewsletterDeletionUpdate (and probably remove it)
Resolved	Filip	T154342 Remove redundant and unnecessary logging from the Newsletter Extension
Resolved	Pppery	T154379 Bizzare behavior when newsletter moved outside Newsletter namespace
Resolved	Pppery	T154380 MWException raised when the ContentModel of a page is changed to NewsletterContent
Resolved	Glaisher	T132017 Throttle for newsletter announcements
Resolved	01tonythomas	T132019 Add table prefix to sub-queries in NewsletterTablePager
Resolved	Pppery	T132022 Add AbuseFilter integration to Extension:Newsletter
Resolved	Daimona	T135668 Need documentation on How to integrate AbuseFilter with xyz extension
Resolved	Daimona	T239348 Custom actions should always be included in the list of available actions
Resolved	01tonythomas	T119058 Special:Newsletter fatals if the newsletter main page is deleted
Resolved	Qgil	T154229 Agree first user group that will be able to create newsletters in Wikimedia
Resolved	Filip	T154534 Restrict 'newsletter-{create,manage,destroy}' only to 'sysop' by default
Resolved	xSavitar	T159075 Fix character escaping throughout the extension files
Resolved	None	T159084 [Security] Fix inconsistent Newsletter user rights
Resolved	01tonythomas	T159085 [Security] Improve data attribute naming to avoid forge
Resolved	01tonythomas	T160854 Newsletter strange behaviour on an API create/edit

Event Timeline

Qgil created this task.Feb 18 2016, 11:55 AM

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 18 2016, 11:55 AM

Qgil moved this task from Backlog to Technical review on the MediaWiki-extensions-Newsletter board.Feb 18 2016, 11:56 AM

Qgil updated the task description. (Show Details)Feb 18 2016, 12:20 PM

Qgil merged a task: T115098: Deploy Newsletter extension in beta cluster.

Qgil added subscribers: Tinaj1234, 01tonythomas, Glaisher and 5 others.

Getting a new extension on the Beta Cluster is part of the process of getting it into production (we don't just add random extensions people want to play with to BC ;) ). See https://www.mediawiki.org/wiki/Review_queue for the general workflow of getting things into production.

The security review is a blocker to this one.

greg added a subtask: T115095: Security review of Newsletter extension.Feb 18 2016, 3:02 PM

greg added a parent task: T110170: Goal: Deploy Newsletter extension in Wikimedia.

OK, this was just me being outdated with test, test2, betacluster. Sorry for the confusion.

This is an extension aiming to be deployed in production indeed. We hope to start the security review in a few weeks (csteipp said just today).

Is there a chance to get this done during the Wikimedia-Hackathon-2016 ? I think most of the blockers are resolved for deployment, expect some agreement with the security review. I will add that as a blocker here though.

Change 281249 had a related patch set uploaded (by 01tonythomas):
Add Newsletter extension to beta

https://gerrit.wikimedia.org/r/281249

gerritbot added a project: Patch-For-Review.Apr 3 2016, 6:49 AM

In T127297#2173836, @01tonythomas wrote:

Is there a chance to get this done during the Wikimedia-Hackathon-2016 ? I think most of the blockers are resolved for deployment, expect some agreement with the security review. I will add that as a blocker here though.

Yeah, I think so. I'll be at the venue in a couple of hours and could help with that.

In T127297#2173859, @ori wrote:

In T127297#2173836, @01tonythomas wrote:

Is there a chance to get this done during the Wikimedia-Hackathon-2016 ? I think most of the blockers are resolved for deployment, expect some agreement with the security review. I will add that as a blocker here though.

Yeah, I think so. I'll be at the venue in a couple of hours and could help with that.

Great. I prepared a patch ( from my little experience with how we did back with the MediaWiki-extensions-BounceHandler extension ).

I'm still waiting to hear back from the Security team regarding whether or not my security review is sufficient for deploying the extension to production, but I'm going to go ahead and assume my review is good enough for deploying to the beta cluster.

Done in https://gerrit.wikimedia.org/r/#/c/281288/ , waiting for scap to run on beta.

Checked out at deploymentwiki: Works.

Aklapper added a project: Wikimedia-Hackathon-2016.Apr 3 2016, 1:18 PM

THIS IS IMPRESSIVE! Thank you very much to all the regular and spontaneous contributors that helped during this Hackathon weekend. I was optimistic about the progress we could achieve during these days, but I hadn't allowed myself to dream to have the extension deployed to the Beta cluster today!

Qgil awarded a token.Apr 3 2016, 7:47 PM

Change 281249 abandoned by Reedy:
Add Newsletter extension to beta

Reason:
Looks like it's already done

https://gerrit.wikimedia.org/r/281249

Woohoo! Thank you again everyone for this :) @ori , special thank you for the security review, we've been waiting for one forever!

Qgil updated the task description. (Show Details)Apr 19 2016, 9:34 AM

Bawolff closed subtask T115095: Security review of Newsletter extension as Resolved.Jun 26 2017, 8:18 AM