Page MenuHomePhabricator
Create Task
Maniphest T150095

newsletter-create-editsummary is not defined
Closed, ResolvedPublic
Actions

Description

When a newsletter is created, the edit summary (which is visible in the first edit on the History page of the Newsletter) is undefined and just shows a raw "⧼newsletter-create-editsummary⧽". This should instead show a proper string (in human language) instead of that variable name.

See http://newsletter-test.wmflabs.org/w/index.php?title=Newsletter:CustomOne&action=history

Mentor: @01tonythomas

Details

SubjectRepoBranchLines +/-
Define message 'newsletter-create-editsummary'mediawiki/extensions/Newslettermaster+2 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DuplicateQgilT125545 Phabricator Q&A session for Community Liaisons
 ResolvedQgilT116025 Goal: Align Community Liaison and Developer Relations project management practices
 ResolvedQgilT119387 Community Liaison and Developer Relation quarterly goals for January - March 2016
 DeclinedNoneT104131 Exporting existing newsletter to the Newsletter extension
 ResolvedAddshoreT110170 Goal: Deploy Newsletter extension in Wikimedia
 DuplicateNoneT115098 Deploy Newsletter extension in beta cluster
 ResolvedoriT127297 Add the Newsletter extension to the Beta Cluster
 ResolvedBawolffT115095 Security review of Newsletter extension
 ResolvedGlaisherT116382 Raw html should be escaped before output in Newsletter pages
 ResolvedTinaj1234T110491 Newsletter extension should have validation
 DeclinedNoneT131616 Cap the number of active newsletters per user
 ResolvedGlaisherT132016 Add CheckUser integration to Extension:Newsletter
 Resolved01tonythomasT132018 Add newsletter description to log messages
 ResolvedGlaisherT132017 Throttle for newsletter announcements
 Resolved01tonythomasT132019 Add table prefix to sub-queries in NewsletterTablePager
 ResolvedPpperyT132022 Add AbuseFilter integration to Extension:Newsletter
 ResolvedDaimonaT135668 Need documentation on How to integrate AbuseFilter with xyz extension
 ResolvedDaimonaT239348 Custom actions should always be included in the list of available actions
 Resolved01tonythomasT119058 Special:Newsletter fatals if the newsletter main page is deleted
 ResolvedQgilT154229 Agree first user group that will be able to create newsletters in Wikimedia
 ResolvedFilipT154534 Restrict 'newsletter-{create,manage,destroy}' only to 'sysop' by default
 ResolvedxSavitarT159075 Fix character escaping throughout the extension files
ResolvedNoneT159084 [Security] Fix inconsistent Newsletter user rights
Resolved01tonythomasT159085 [Security] Improve data attribute naming to avoid forge
 Resolved01tonythomasT160854 Newsletter strange behaviour on an API create/edit
Resolved01tonythomasT140402 Namespace is repeated in notification link
 Resolved01tonythomasT138462 Convert Newsletter to use ContentHandler
 ResolvedMtDuT150095 newsletter-create-editsummary is not defined

Event Timeline

01tonythomas created this task.Nov 5 2016, 4:37 PM
01tonythomas updated the task description. (Show Details)
01tonythomas removed 01tonythomas as the assignee of this task.Nov 5 2016, 4:44 PM
01tonythomas moved this task from Backlog to Google Code In 2016 on the MediaWiki-extensions-Newsletter board.Nov 5 2016, 4:51 PM
01tonythomas renamed this task from [Beginner] newsletter-create-editsummary is not defined to newsletter-create-editsummary is not defined .Nov 5 2016, 5:01 PM
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Nov 28 2016, 12:17 AM

Imported as https://codein.withgoogle.com/tasks/5675756126470144/

Aklapper updated the task description. (Show Details)Dec 7 2016, 2:08 PM
01tonythomas added a comment.Dec 7 2016, 2:13 PM

Thanks for that one, @Aklapper ! :)

gerritbot added a comment.Dec 8 2016, 4:51 AM

Change 325880 had a related patch set uploaded (by MtDu):
Define message 'newsletter-create-editsummary'

https://gerrit.wikimedia.org/r/325880

gerritbot added a project: Patch-For-Review.Dec 8 2016, 4:51 AM
MtDu claimed this task.Dec 8 2016, 5:33 AM
gerritbot added a comment.Dec 8 2016, 9:49 AM

Change 325880 merged by jenkins-bot:
Define message 'newsletter-create-editsummary'

https://gerrit.wikimedia.org/r/325880

01tonythomas closed this task as Resolved.Dec 8 2016, 9:51 AM
Qgil awarded a token.Dec 8 2016, 10:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL