Badges are no longer shown next to interwiki links
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Srdjan
	Aug 5 2017, 10:23 AM

Description

Go to https://de.wikipedia.org/wiki/Game_of_Thrones
Scroll down until you've gone over all the interwiki links
You should see that there are no badges for featured and good articles despite the fact that several are asigned on Wikidata

Details

	Subject	Repo	Branch	Lines +/-
	Add autoload classes	mediawiki/extensions/WikimediaBadges	master	+4 -0
	Explicitly load WikimediaBadges with wfLoadExtension	wikidata/build-resources	master	+2 -0

Customize query in gerrit

Related Objects

Mentioned In: T172805: Commonscat not longer shown under "In other projects"
rWDBR525d31471f94: Explicitly load WikimediaBadges with wfLoadExtension

Event Timeline

Srdjan created this task.Aug 5 2017, 10:23 AM

Restricted Application added subscribers: PokestarFan, Aklapper. · View Herald TranscriptAug 5 2017, 10:23 AM

Aklapper added projects: Regression, Wikimedia-Interwiki-links.Aug 5 2017, 11:15 AM

I can't seem to add Wikidata to this project for some reason... adding Lydia in the hope she can put the task in the right project :)

I spot-checked a few other articles that should have badges on dewp and enwp. They don't show them either. A purge didn't seem to help.

I'm checking and it seems like a very stupid mistake in updating CSS. I'm on it.

Okay, Everything looks normal except that CSS of WikimediaBadges extension stopped being injected for a reason that's still unknown to me.

The fast fix is to add https://en.wikipedia.org/w/index.php?title=User:Ladsgroup/monobook.css&oldid=794035784 to Mediawiki:Monobook.css and https://en.wikipedia.org/w/index.php?title=User:Ladsgroup/vector.css&oldid=794035724 to Mediawiki:Vector.css

In the mean time, I will find out what's going on there.

The only patch I was able to find that remotely can contribute to the problem is https://gerrit.wikimedia.org/r/#/c/368252.

Vachovec1 subscribed.Aug 5 2017, 1:27 PM

On nowiki is working.

Dvorapa subscribed.Aug 5 2017, 10:38 PM

In T172592#3503789, @MrFulano wrote:

On nowiki is working.

Yeah, because they use a customized css and put it in the mediawiki:common.css so it gets injected.

Stryn subscribed.Aug 6 2017, 7:57 AM

Liuxinyu970226 subscribed.Aug 6 2017, 2:01 PM

He7d3r subscribed.Aug 6 2017, 2:35 PM

• Obsuser subscribed.Aug 6 2017, 6:00 PM

Change 370453 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikimediaBadges@master] Add autoload classes

https://gerrit.wikimedia.org/r/370453

gerritbot added a project: Patch-For-Review.Aug 7 2017, 10:59 AM

Ladsgroup claimed this task.Aug 7 2017, 11:00 AM

Ladsgroup added a project: Wikidata-Former-Sprint-Board.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptAug 7 2017, 11:00 AM

Ladsgroup moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.Aug 7 2017, 11:00 AM

Change 370462 had a related patch set uploaded (by Aude; owner: Aude):
[wikidata/build-resources@master] Explicitly load WikimediaBadges with wfLoadExtension

https://gerrit.wikimedia.org/r/370462

aude mentioned this in rWDBR525d31471f94: Explicitly load WikimediaBadges with wfLoadExtension.Aug 7 2017, 12:50 PM

matej_suchanek added a project: User-notice.Aug 8 2017, 7:23 AM

matej_suchanek moved this task from incoming to in progress on the Wikidata board.

We seem to be having the same problem on ro.wp

Reception123 subscribed.Aug 8 2017, 9:41 AM

Umherirrender mentioned this in T172805: Commonscat not longer shown under "In other projects".Aug 8 2017, 8:49 PM

Johan moved this task from To Triage to Announce in next Tech/News on the User-notice board.Aug 9 2017, 3:48 PM

Johan moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.

I would like to fix this in swat tomorrow. I believe it only needs a change in the build, preferably i am able to verify locally + on beta

Nirmos merged a task: T172989: Badges for good and featured articles gone from interwiki list.Aug 10 2017, 1:50 PM

Nirmos added subscribers: Nirmos, Larske.

• Arbnos subscribed.Aug 10 2017, 8:24 PM

Pasleim merged a task: T173177: Badges not shown on client wikis.Aug 12 2017, 1:43 PM

Pasleim added a subscriber: Tacsipacsi.

Ladsgroup moved this task from Incoming to In progress on the User-Ladsgroup board.Aug 14 2017, 10:29 AM

@aude: any progress?

RandomDSdevel awarded a token.Aug 15 2017, 12:30 AM

I hoped this task would have been resolved in one or two days max, because those badges are very important for both Wikipedians and readers when navigating articles... More than 10 days passed with no fixing attempt or direct response, even though problem as I see it should be easily resolvable.

I agree but all of the team were in Wikimania, it's hard to get things through around that time.

Change 370462 merged by jenkins-bot:
[wikidata/build-resources@master] Explicitly load WikimediaBadges with wfLoadExtension

https://gerrit.wikimedia.org/r/370462

Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Aug 15 2017, 11:23 PM

this is enabled again on test wikis (https://test2.wikipedia.org/wiki/Special:Version) and the fix goes out everywhere else with the train this week (tomorrow/thursday)

It seems this has successfully been fixed for all Wikipedias, finally.