Maniphest T192250

On the mobile site, <mapframe> autozoom doesn't work when data is drawn on top of the basemap and the sections of the page are autocollapsed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Gareth
	Apr 16 2018, 1:00 AM

Description

On the mobile site, mapframes display zoomed out to show the whole world if any sort of data (GEOJSON, OSM data or Commons .map pages) are displayed on top of the basemap; the page must be loaded with the relevant section collapsed (collapsing all sections is the default behaviour on phones).

Visit this example page on a phone. The maps above the section break work correctly. Most of the ones below the break do not (the only ones that do are the one where no data is being drawn on top of the base map and the one where the zoom is manually specified).

Note that all maps display correctly if the page is reloaded with the section expanded (because the section remains expanded when the page is reloaded).

QA Results - Prod

AC	Status	Details
1	✅	T192250#6045559

Details

	Subject	Repo	Branch	Lines +/-
	Correct autozoom/center calculations on uncollapsed maps	mediawiki/extensions/Kartographer	master	+47 -8

Customize query in gerrit

Related Objects

Mentioned In: Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mentioned Here: T193528: [mobile] Zoom controls not displayed in portrait view

Event Timeline

Gareth created this task.Apr 16 2018, 1:00 AM

Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptApr 16 2018, 1:00 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• jmatazzoni added a project: Collaboration-Team-Triage (Collab-Team-This-Quarter).May 3 2018, 1:25 AM

• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

• jmatazzoni mentioned this in Collaboration-Team-Triage (Collab-Team-This-Quarter).May 3 2018, 1:44 AM

Etonkovidova merged a task: T193528: [mobile] Zoom controls not displayed in portrait view .May 8 2018, 9:25 PM

Etonkovidova subscribed.

Based on T193528: [mobile] Zoom controls not displayed in portrait view (closed as a duplicate), the steps to reproduce the issue are as following:

On a mobile device or on Chrome mobile emulator go to https://test2.m.wikipedia.org/wiki/User_talk:Etonkovidova/sandbox (there are few samples of dynamic maps).
A mobile device will display the sections collapsed - click to un-collapse them - the zoom controls will not be dispalayed:

To might be trickier to reproduce the issue In Chrome mobile emulator because after viewing a map in full-view, the zoom controls will be, in fact, displayed. Collapse the sections -reload the page - un-collapse - the controls will be gone:

Screen Shot 2018-05-08 at 2.32.52 PM.png (643×481 px, 133 KB)

• jmatazzoni removed projects: Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps).May 29 2018, 6:49 PM

• Jhernandez removed a project: Discovery-ARCHIVED.Jul 10 2018, 4:35 PM

• Mholloway triaged this task as Low priority.Aug 14 2018, 3:59 PM

• Mholloway edited projects, added Maps (Kartographer); removed Maps.

MSantos moved this task from Unsorted to UI tasks on the Maps (Kartographer) board.Sep 18 2018, 3:52 PM

Liuxinyu970226 awarded a token.Nov 11 2018, 11:21 AM

Liuxinyu970226 subscribed.

Almost certainly because we do not trigger invalidateSize() on the map in that case, which we do do for mw-collapsible.. I'm not sure how to be notified of collapsible sections on mobile however.

@Jdlrobson is there a method with which I can reach the Mobile eventbus to listen to section-toggled ?

In T192250#5989463, @TheDJ wrote:

Almost certainly because we do not trigger invalidateSize() on the map in that case, which we do do for mw-collapsible.. I'm not sure how to be notified of collapsible sections on mobile however.

@Jdlrobson is there a method with which I can reach the Mobile eventbus to listen to section-toggled ?

mw.mobileFrontend.require('mobile.startup').eventBusSingleton.on('section-toggled', (a) => { console.log('hello world', a ); })

Change 582579 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/Kartographer@master] Correct autzoom/center calculations on uncollapsed maps

https://gerrit.wikimedia.org/r/582579

gerritbot added a project: Patch-For-Review.Mar 22 2020, 2:41 PM

Well this is as best as i can get it I think :/

Jdlrobson added a project: Web-Team-Backlog.Mar 23 2020, 4:07 AM

• nray moved this task from Needs triage to Triaged on the Mobile board.Mar 23 2020, 11:49 PM

Change 582579 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Correct autozoom/center calculations on uncollapsed maps

https://gerrit.wikimedia.org/r/582579

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).Apr 6 2020, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 6 2020, 6:11 PM

We should probably QA this unless there is another team doing this. @JTannerWMF can you advise?

Jdlrobson moved this task from Needs Analysis to Needs QA on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Apr 8 2020, 12:22 AM

For QA. To clarify, the patch will ONLY fix the situation where a map is initially in a collapsed state and a user then uncollapses this section manually.

ovasileva assigned this task to Edtadros.Apr 8 2020, 4:02 PM

ovasileva moved this task from Needs QA to Needs QA in Prod on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Apr 9 2020, 5:47 PM

Test Result - Prod

Status: ✅ PASS
Environment: commons
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA steps

Go to https://commons.m.wikimedia.org/wiki/User:Gareth/maps/test2
Expand section break
✅ AC1: Verify that mapframes DO NOT display zoomed out to show the whole world if any sort of data (GEOJSON, OSM data or Commons .map pages) are displayed on top of the basemap; the page must be loaded with the relevant section collapsed (collapsing all sections is the default behaviour on phones).

commons.m.wikimedia.org_wiki_User_Gareth_maps_test2(iPhone X) (1).png (2×1 px, 1 MB)

commons.m.wikimedia.org_wiki_User_Gareth_maps_test2(iPhone X).png (2×1 px, 529 KB)

Edtadros updated the task description. (Show Details)Apr 10 2020, 6:28 AM

Looks good!

	F31748207: commons.m.wikimedia.org_wiki_User_Gareth_maps_test2(iPhone X) (1).png
	Apr 10 2020, 6:27 AM

	F31748206: commons.m.wikimedia.org_wiki_User_Gareth_maps_test2(iPhone X).png
	Apr 10 2020, 6:27 AM

	F18086364: Screen Shot 2018-05-08 at 2.32.52 PM.png
	May 8 2018, 9:41 PM

	F18086335: Image-1 (1).jpg
	May 8 2018, 9:41 PM

On the mobile site, <mapframe> autozoom doesn't work when data is drawn on top of the basemap and the sections of the page are autocollapsedClosed, ResolvedPublicActions