Maniphest T192769

Special:Preferences: OOUI tabs cause a FOUC because the PHP side doesn't hack in their HTML, unlike the non-OOUI tabs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Apr 23 2018, 12:08 PM

Description

As TabPanelLayout is not available in PHP, the tab menu is not visible until JS runs.

Details

	Subject	Repo	Branch	Lines +/-
	Special:Preferences: Construct fake tabs to avoid FOUC	mediawiki/core	master	+155 -21

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
Open	None	T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
Open	None	T100161 Convert all of MediaWiki core to OOUI PHP (tracking)
Resolved	matmarex	T101480 Remove 'wgUseMediaWikiUIEverywhere' and code forks, always using the off/false path
Invalid	None	T101471 Convert core forms that use MW UI with wgUseMediaWikiUIEverywhere false to OOUI FormSpecialPage or explicit OOUI PHP
Open	None	T107037 Convert all MW core special pages to OOUI
Open	None	T64559 Redesign Special:Preferences (tracking)
Resolved	Volker_E	T180538 Improve Special:Preferences UI/UX
Resolved	Volker_E	T117781 Convert Special:Preferences to OOUI
Resolved	Esanders	T192769 Special:Preferences: OOUI tabs cause a FOUC because the PHP side doesn't hack in their HTML, unlike the non-OOUI tabs
Resolved	Esanders	T189366 OOUI styles aren't available separately for certain modules

Event Timeline

Esanders created this task.Apr 23 2018, 12:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2018, 12:08 PM

Esanders mentioned this in T180538: Improve Special:Preferences UI/UX.Apr 23 2018, 12:09 PM

Esanders added a parent task: T180538: Improve Special:Preferences UI/UX.

Change 428326 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Special:Preferences: Construct fake tabs to avoid FOUC

https://gerrit.wikimedia.org/r/428326

gerritbot added a project: Patch-For-Review.Apr 23 2018, 12:21 PM

Mainframe98 mentioned this in T189366: OOUI styles aren't available separately for certain modules.Apr 23 2018, 12:44 PM

Esanders added a subscriber: matmarex.Apr 23 2018, 5:46 PM

matmarex added a subtask: T189366: OOUI styles aren't available separately for certain modules.Apr 25 2018, 11:03 PM

Jdforrester-WMF renamed this task from Lots of FOUC in Special:Preferences OOUI version to Special:Preferences: OOUI tabs cause a FOUC because the PHP side doesn't hack in their HTML, unlike the non-OOUI tabs.May 11 2018, 9:41 PM

Jdforrester-WMF assigned this task to Esanders.

Jdforrester-WMF triaged this task as Medium priority.

Jdforrester-WMF added a project: UI-Standardization.

Change 428326 merged by jenkins-bot:
[mediawiki/core@master] Special:Preferences: Construct fake tabs to avoid FOUC

https://gerrit.wikimedia.org/r/428326

Jdforrester-WMF closed this task as Resolved.May 18 2018, 6:51 PM

Jdforrester-WMF closed subtask T189366: OOUI styles aren't available separately for certain modules as Resolved.

Jdforrester-WMF removed a project: Patch-For-Review.

TheDJ awarded a token.May 18 2018, 7:38 PM

Izno edited parent tasks, added: T117781: Convert Special:Preferences to OOUI; removed: T180538: Improve Special:Preferences UI/UX.Sep 18 2018, 10:34 PM

thiemowmde mentioned this in T215490: Clicking the "Beta" button takes you right to the bottom of the beta features preferences pane instead of the top.Mar 14 2019, 2:26 PM