Maniphest T193312

Clicking on mapframe static map (or maplink link) in apps doesn't launch dynamic map
Open, LowPublic
Actions

Assigned To

None

Authored By

	• jmatazzoni
	Apr 27 2018, 11:59 PM

Description

mapframe map

In the iOS or Android app, go to the Catalan Wikipedia article for San Francisco. (mapframe is enabled on ca.wiki).
In the info box, you'll find a static map that was generated by mapframe.
Click on the map

Expected behavior: launch a dynamic map, probably in a web browser. (An "expand" icon should also appear in the upper-right corner of the static map).
Actual behavior: go to the "no javascript" fallback for the maps page, showing the coordinates of where you clicked.

maplink map

The results here are the same if you click on a "maplink" (a related featured to mapframe, but the map is not embedded on the page; it's just a link on the page that opens a map in a popup).

E.g., go to this article of Bays Precinct
Click on the link in the upper-right corner of the page.

Collaboration team plans to bring mapframe maps to literally hundreds of Wikipedias, including English, in May. This new capability willl surely raise the profile and usage of mapframe and maplink maps. Without the dynamic map, a huge portion the advantage mapframe and maplink maps bring is missing. Please consider same for this ticket ( and related ticket ) as you prioritize ios tassks for action.

Related Objects

Mentioned In: T216576: Maplink template crashes app
T193470: Mapframe maps with an image in the GeoJSON don't display on mobile website or mobile apps
T193448: Clicking on mapframe static map (or maplink link) in Android app doesn't launch dynamic map

Event Timeline

• jmatazzoni created this task.Apr 27 2018, 11:59 PM

Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptApr 27 2018, 11:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• jmatazzoni updated the task description. (Show Details)Apr 28 2018, 12:00 AM

• jmatazzoni updated the task description. (Show Details)Apr 28 2018, 1:10 AM

• JMinor moved this task from Needs Triage to Tracking on the Wikipedia-iOS-App-Backlog board.Apr 30 2018, 5:38 PM

Regarding behavior of link coordinates - clicking on the link will redirect to https://tools.wmflabs.org/geohack/geohack.php?pagename=San_Francisco&language=ca&params=37.766667_N_-122.433333_E_ . Currently this behavior is consistent between desktop/mobile(wmf.1) and iPhone app (5.8.0(1393)).

The screenshot is for iPhone (6S) app:

• jmatazzoni mentioned this in T193448: Clicking on mapframe static map (or maplink link) in Android app doesn't launch dynamic map.Apr 30 2018, 10:42 PM

• jmatazzoni updated the task description. (Show Details)Apr 30 2018, 10:47 PM

• jmatazzoni updated the task description. (Show Details)

LGoto moved this task from Tracking to Product Backlog on the Wikipedia-iOS-App-Backlog board.May 1 2018, 5:48 PM

Another example of a page with a #maplink
https://en.wikipedia.org/wiki/Silver_Comet_Trail

The HTML we get from
https://en.wikipedia.org/api/rest_v1/page/html/Silver_Comet_Trail

<span style="font-size: small;" id="coordinates" about="#mwt2" typeof="mw:Transclusion" data-mw='{"parts":[{"template":{"target":{"wt":"maplink","href":"./Template:Maplink"},"params":{"display":{"wt":"inline,title"},"type":{"wt":"line"},"text":{"wt":"Map Trail&apos;s Path"}},"i":0}}]}'><a class="mw-kartographer-maplink" mw-data="interface" data-style="osm-intl" href="/wiki/Special:Map////en" data-overlays='["_eac655fa6529e63b85da3c959eed97c648946393"]' typeof="mw:Extension/maplink" about="#mwt27" data-mw='{"name":"maplink","attrs":{"text":"Map Trail&apos;s Path"},"body":{"extsrc":"{\"properties\":{\"stroke-width\":6,\"stroke\":\"#ff0000\",\"title\":\"Silver Comet Trail\"},\"type\":\"ExternalData\",\"service\":\"geoline\",\"ids\":\"Q7515926\"}"}}'>Map Trail's Path</a><span about="#mwt27">
</span><link rel="mw:PageProp/Category" href="./Category:Pages_with_maps" about="#mwt27"/></span><a class="mw-kartographer-maplink" mw-data="interface" data-style="osm-intl" href="/wiki/Special:Map////en" data-overlays='["_eac655fa6529e63b85da3c959eed97c648946393"]' typeof="mw:Extension/maplink" about="#mwt2" data-mw='{"name":"maplink","attrs":{"text":"Map Trail&apos;s Path"},"body":{"extsrc":"{\"properties\":{\"stroke-width\":6,\"stroke\":\"#ff0000\",\"title\":\"Silver Comet Trail\"},\"type\":\"ExternalData\",\"service\":\"geoline\",\"ids\":\"Q7515926\"}"}}'>Map Trail's Path</a>

And from mobileview:

<span style="font-size: small;" id="coordinates"><a class="mw-kartographer-maplink" mw-data="interface" data-style="osm-intl" href="/wiki/Special:Map////en" data-overlays='["_eac655fa6529e63b85da3c959eed97c648946393"]'>Map Trail's Path</a></span><a class="mw-kartographer-maplink" mw-data="interface" data-style="osm-intl" href="/wiki/Special:Map////en" data-overlays='["_eac655fa6529e63b85da3c959eed97c648946393"]'>Map Trail's Path</a></p>

@Jdlrobson @ssastry This seems not to be expanded in Parsoid and Mobile View APIs… ideas why?

It looks like that's the expected parser output:
https://github.com/wikimedia/mediawiki-extensions-Kartographer/blob/364ab1a8e2886537296c30e592540fd343550d21/tests/parser/parserTests.txt

and the link transforms happen here:
https://github.com/wikimedia/mediawiki-extensions-Kartographer/blob/e5cfeba1692fb6f27beeb6bb75e77ff56cb3cbaf/modules/maplink/maplink.js

cc @Dbrant @Mhurd @Niedzielski is there a good way to incorporate this into the page library?

RHo renamed this task from Clicking on mapframe static map (or maplink link) in iOS app doesn't launch dynamic map to Clicking on mapframe static map (or maplink link) in apps doesn't launch dynamic map.May 15 2018, 4:35 PM

RHo updated the task description. (Show Details)

• jmatazzoni mentioned this in T193470: Mapframe maps with an image in the GeoJSON don't display on mobile website or mobile apps .Jun 1 2018, 1:08 AM

@JoeWalsh, sorry for the late response. I'm not sure the Page Library would be appropriate since both native apps offer native maps which should probably be favored over the web versions.

• Vvjjkkii renamed this task from Clicking on mapframe static map (or maplink link) in apps doesn't launch dynamic map to j1daaaaaaa.Jul 1 2018, 1:13 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from j1daaaaaaa to Clicking on mapframe static map (or maplink link) in apps doesn't launch dynamic map.Jul 2 2018, 4:34 PM

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)