Page MenuHomePhabricator
Create Task
Maniphest T194088

Wikivoyage should provide non external Nearby articles
Closed, InvalidPublic
Actions

Description

Following T186247 users in hewikivoyage complain that nearby articles is not loaded by default and it is considered as external layer.
Nearby articles is too important layer be external and comes from labs ( https://tools.wmflabs.org/wikivoyage/w/data/he-articles.js )

This is not consistent in wikivoyage sites:

How to reproduce

  1. Get into a page in wikivoyage such as https://en.wikivoyage.org/wiki/Destinations
  2. In the right top corner press the layers button, and select "Nearby articles"

Expected: Nearby articles layer will be added to map
Actual: A warning appear: "External data source: This content is hosted externally, so enabling it shares your data with other sites."
(if it doesn't appear - open it as anonymous or clear the LocalStorage)

Policy
Will it be OK if we enable nearby articles layer by default without violating privacy policy?

Technically it is possible to add into MediaWiki:Kartographer.js enabling this layer

wvmap._controlNearby._toggleLayer()

Technical
We should allow nearby articles to be non external or Wikimedia should provide an "official" internal layer of nearby articles

Related Objects
Search...

Event Timeline

eranroz created this task.May 7 2018, 9:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2018, 9:05 PM
Framawiki subscribed.May 7 2018, 10:41 PM
Aklapper added a comment.EditedMay 8 2018, 10:21 AM

I am afraid that I do not understand the problem. :(

The problem in T186247 was NOT that he.wikivoyage.org was automatically loading content from https://tools.wmflabs.org/ . The problem was that it automatically loaded content from https://tools.wmflabs.org/wikivoyage/w/poimap2.php which also automatically passed user's data to openstreetmap.org and openptmap.org. openstreetmap.org and openptmap.org are third party websites, but not tools.wmflabs.org.

Both https://fr.wikivoyage.org/wiki/Destinations and https://en.wikivoyage.org/wiki/Destinations load all of their data from WMF sites (which includes tools.wmflabs.org) and, as far as I see, do NOT automatically pass any user's data to third-party websites.

What exactly "is considered as external layer" and by who? How exactly is "external layer" related to "automatically loaded"/"automatically disabled"?

eranroz updated the task description. (Show Details)May 8 2018, 11:05 AM

Updated the description above with "How to reproduce"

Aklapper added projects: Tools, Maps, Privacy.May 8 2018, 11:09 AM

Thanks, way clearer now :)

Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptMay 8 2018, 11:09 AM
DekelE subscribed.May 17 2018, 7:33 PM
DekelE added a subscriber: WJ.May 17 2018, 7:39 PM
• Vvjjkkii renamed this task from Wikivoyage should provide non external Nearby articles to zfdaaaaaaa.Jul 1 2018, 1:11 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed Tools.
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from zfdaaaaaaa to Wikivoyage should provide non external Nearby articles.Jul 1 2018, 3:49 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
Aklapper added a project: Tools.Jul 2 2018, 10:07 AM
• Jhernandez removed a project: Discovery-ARCHIVED.Jul 10 2018, 4:35 PM
• jmatazzoni unsubscribed.Jul 10 2018, 4:58 PM
• Mholloway triaged this task as Lowest priority.Aug 14 2018, 3:32 PM
• Mholloway subscribed.

Needs investigation. Not sure if this counts as a bug or feature request.

• Mholloway edited projects, added Maps (Kartographer); removed Maps.Aug 14 2018, 3:32 PM
MSantos moved this task from Unsorted to Wikivoyage on the Maps (Kartographer) board.Sep 18 2018, 3:43 PM
• JFishback_WMF moved this task from Intake to Backlog on the Privacy board.Mar 24 2020, 3:23 PM
TheDJ added a subtask: T244691: WikiVoyage nearby articles map layer loads a JS file from toolforge.Mar 25 2020, 12:50 PM
TheDJ mentioned this in T332785: Remove custom old nearby functionality for Wikivoyage from Kartographer.Mar 22 2023, 2:45 PM
Tmv subscribed.Sep 27 2023, 9:22 AM

Now that we have a new feature of Kartographer, I don't think this thread makes sense.

WMDE-Fisch closed this task as Invalid.Feb 26 2024, 1:15 PM
WMDE-Fisch closed subtask T244691: WikiVoyage nearby articles map layer loads a JS file from toolforge as Invalid.
WMDE-Fisch subscribed.

Yes , the special WikiVoyage nearby feature got deprecated and the code removed T332785: Remove custom old nearby functionality for Wikivoyage from Kartographer. So this ticket should be invalid now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits