Maniphest T195600

Drafts should not disappear from the new pages feed after 90 days
Closed, InvalidPublic
Actions

Assigned To

None

Authored By

	TonyBallioni
	May 25 2018, 3:50 PM

Description

See this thread and this thread for more background.

Pages on the English Wikipedia that are moved from draft to mainspace are not supposed to be patrolled unless the individual moving the draft to mainspace is also autopatrolled.

Currently, any draft that was created over 90 days ago will not show up in the new pages feed or be eligible to be patrolled. (Examples include: Constance Savery, José Angel Figueroa and Quartet Skaz.

The software should not be allowing drafts to be patrolled unless they are moved to mainspace by an autopatroller, bot, or sysop. Old drafts should stay unpatrolled until they are manually patrolled, just as newer drafts are. This is because of en.wiki's two step review system for drafts as compared to mainspace articles.

Event Timeline

TonyBallioni created this task.May 25 2018, 3:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2018, 3:50 PM

TonyBallioni updated the task description. (Show Details)May 25 2018, 3:53 PM

Xaosflux added projects: English-Wikipedia-New-Pages-Patrol, MediaWiki-Patrolling.May 25 2018, 4:08 PM

Xaosflux added subscribers: Primefac, Kudpung.

Xaosflux subscribed.

Ladsgroup subscribed.May 26 2018, 7:14 PM

Is there any motion on this? It's a rather serious deal, especially given the fact that we've had a couple thousand drafts accepted in the last few months that have likely slipped through the cracks.

• Vvjjkkii renamed this task from Old drafts on the English Wikipedia incorrectly marked as patrolled to z9baaaaaaa.Jul 1 2018, 1:08 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from z9baaaaaaa to Old drafts on the English Wikipedia incorrectly marked as patrolled.Jul 2 2018, 3:45 PM

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

JJMC89 edited projects, added PageTriage; removed MediaWiki-Patrolling.Jul 9 2019, 11:42 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 9 2019, 11:42 PM

94rain subscribed.Jul 10 2019, 12:26 AM

Catrope renamed this task from Old drafts on the English Wikipedia incorrectly marked as patrolled to Drafts should not disappear from the new pages feed after 90 days.Jul 11 2019, 9:45 PM

Catrope moved this task from Inbox to Needs Discussion on the Growth-Team board.Jul 11 2019, 9:48 PM

Tagging Community-Tech due to their current work of Page Curation.

@JTannerWMF I'm assuming you didn't mean to claim/resolve this? :)

I'm removing the Community Tech label from this ticket, as it is not part of the wishlist requests for Page Curation.

DannyS712 moved this task from Backlog to PageCuration & NewPagesFeed on the English-Wikipedia-New-Pages-Patrol board.Dec 2 2019, 9:12 PM

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:56 PM

This looks like it could be a major issue.

Needs testing to make sure this bug still exists (set up a draftspace on a localhost wiki, create a draft, go into phpmyadmin and tweak the article creation date of a draft to be older than 90 days, move it to mainspace with a non autopatrolled account, see if it shows up in Special:NewPagesFeed).

If the bug still exists, need to figure out the root cause. The only magic number that is 90 days that I can think of is $wgPageTriageMaxAge, and in theory that should only affect NOINDEX.

Possibly cron job related (cron/updatePageTriageQueue.php)?

Novem_Linguae moved this task from Backlog to Soon on the PageTriage board.Sep 17 2022, 6:08 AM

ifried unsubscribed.Sep 19 2022, 2:29 PM

Couldn't reproduce on localhost wiki. I changed the timestamp in the revision, page and pagetriage tables to 4 months back, and then moved the draft to mainspace. It showed up in NewPagesFeed.

Thank you @MPGuy2824. Closing for now. If anybody can reproduce it please feel free to re-open.

Hang on... Sorry, @Novem_Linguae , I don't fully understand the Phabricator colloquialisms. Does this mean the task as originally requested by @TonyBallioni four years ago, and which @Primefac endorsed as

It's a rather serious deal, especially given the fact that we've had a couple thousand drafts accepted in the last few months that have likely slipped through the cracks.

has been done, resolved, and is operational? Or has it been closed as 'Can't be done' ?

It's "unable to reproduce so we assume it's fixed", meaning when we tested it just now, we couldn't get it to do the buggy behavior. So we are assuming it was fixed by something (a patch that forgot to link this ticket? voodoo magic?) between when it was opened and now. Hope that makes sense.

@Novem_Linguae, does that mean that someone has checked locally to see if drafts are in fact no longer being indexed?

Yes. MPGuy2824 did above. He made the comment:

Couldn't reproduce on localhost wiki.

If you encounter this bug on enwiki feel free to reopen this. Until someone sees the bug though, since this is a 4 year old ticket, I think it's reasonable to close it.

Thanks everyone. I would be curious to know why it took four years, but that's another topic.

Drafts should not disappear from the new pages feed after 90 daysClosed, InvalidPublicActions

Description

Event Timeline

Drafts should not disappear from the new pages feed after 90 days
Closed, InvalidPublic
Actions