Page MenuHomePhabricator
Create Task
Maniphest T195948

MCS should respect Accept-Language header
Closed, ResolvedPublic
Actions

Description

As a first iteration of the language variants support we're going to generate language variants for MCS content on the fly. In order to do that, RESTBase would pass the Acccept-Language header to MCS when needed, and MCS should respect it and forward it back to RESTBase when fetching Parsoid content from RESTBase before transforming it to mobile-sections or summaries.

In case requests to MW API are needed to get any content in the variant, we might need to make some library to transform Accept-Language into something MW understands, but I'm not sure that's needed.

NOTE: RESTBase itself doesn't support forwarding the Accept-Language to MCS or returning correct parsoid HTML yet, it's blocked on Parsoid transform endpoint, so it won't be possible to properly test this just yet.

Details

SubjectRepoBranchLines +/-
Pass through Accept-Language headers to Parsoid requestsmediawiki/services/mobileappsmaster+4 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Pchelolo triaged this task as Medium priority.May 30 2018, 9:42 AM
• Pchelolo created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2018, 9:42 AM
• Pchelolo updated the task description. (Show Details)May 30 2018, 9:44 AM
LGoto moved this task from Needs triage to Kanban on the Product-Infrastructure-Team-Backlog-Deprecated board.May 31 2018, 5:55 PM
LGoto edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.
• bearND reassigned this task from • bearND to Jdforrester-WMF.Jun 5 2018, 4:49 PM
Jdforrester-WMF moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jun 5 2018, 5:50 PM
gerritbot subscribed.Jun 5 2018, 6:38 PM

Change 437530 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/services/mobileapps@master] Pass through Accept-Language headers to Parsoid requests

https://gerrit.wikimedia.org/r/437530

gerritbot added a project: Patch-For-Review.Jun 5 2018, 6:38 PM
gerritbot added a comment.Jun 5 2018, 11:35 PM

Change 437530 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Pass through Accept-Language headers to Parsoid requests

https://gerrit.wikimedia.org/r/437530

Jdforrester-WMF removed a project: Patch-For-Review.Jun 6 2018, 12:07 AM
Jdforrester-WMF moved this task from Doing to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

Not sure if this counts as Resolved?

• bearND added a comment.Jun 6 2018, 12:30 AM

In the past we usually resolved tasks after deployment to production.

Stashbot mentioned this in T196402: Public rollout of feed content availability endpoint.Jun 6 2018, 8:10 PM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2018-06-06T20:10:01Z] <bsitzmann@deploy1001> Started deploy [mobileapps/deploy@a07af40]: Update mobileapps to 3bf9be5 (T196402 T195948)

Stashbot added a comment.Jun 6 2018, 8:18 PM

Mentioned in SAL (#wikimedia-operations) [2018-06-06T20:18:38Z] <bsitzmann@deploy1001> Finished deploy [mobileapps/deploy@a07af40]: Update mobileapps to 3bf9be5 (T196402 T195948) (duration: 08m 37s)

• Mholloway moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jun 6 2018, 10:25 PM
• bearND closed this task as Resolved.Jun 7 2018, 4:48 PM
• bearND reopened this task as Open.Jun 7 2018, 5:02 PM

Maybe that was a bit premature. We should probably also check if we need to change any MW API requests for language variants.

Jdforrester-WMF added a comment.Jun 7 2018, 5:28 PM

For the language variants stuff in practice, there's active discussion on T43716; will wait for that to settle.

• bearND added a comment.Jun 7 2018, 5:43 PM

I think T43716 pertains only to Parsoid. I was thinking we should also look into getting the correct language variant for the values we get from MW API, which could be done independently.
A few areas that come to mind are (but that's probably not a full list):

  • summary: description, titles
  • metadata: categories, hatnotes, issues, toc,
  • media: titles, descriptions, captions, artists, license strings, ...
  • mobile-sections: for the main page content we still use action=mobileview

That's a lot of stuff, so that could be handled by a separate task, too.

• mobrovac added a comment.Jun 7 2018, 8:43 PM
In T195948#4265118, @bearND wrote:

I think T43716 pertains only to Parsoid.

Indeed. Since MCS goes through RESTBase, it will use the same Accept-Language header regardless of the actual Parsoid API/implementation.

• Pchelolo added a comment.Jun 12 2018, 11:16 AM

I believe adapting non-parsoid-derived content in MCS to respect the accept-language deserves its own task, that is not as trivial as just passing through Accept-Language.

• bearND mentioned this in T197009: MCS should respect Accept-Language header for MW API requests.Jun 12 2018, 3:11 PM
• bearND added a comment.Jun 12 2018, 3:15 PM

Created a new task for the MW API usage of MCS.

Jdforrester-WMF moved this task from Sign off to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jun 18 2018, 4:32 PM
• bearND moved this task from Doing to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jun 18 2018, 4:51 PM
• bearND moved this task from To Deploy to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jun 18 2018, 4:55 PM
• Vvjjkkii renamed this task from MCS should respect Accept-Language header to b0baaaaaaa.Jul 1 2018, 1:06 AM
• Vvjjkkii removed Jdforrester-WMF as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii edited subscribers, added: Jdforrester-WMF; removed: gerritbot, Aklapper.
• mobrovac renamed this task from b0baaaaaaa to MCS should respect Accept-Language header.Jul 1 2018, 10:14 AM
• mobrovac assigned this task to Jdforrester-WMF.
• mobrovac lowered the priority of this task from High to Medium.
• mobrovac removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
• mobrovac updated the task description. (Show Details)
• mobrovac removed a subscriber: Jdforrester-WMF.
phuedx mentioned this in T188164: Popups don‘t support language variant conversion and {{lang}} template.Jul 2 2018, 9:07 AM
• Jhernandez changed the status of subtask T197792: MCS should proxy Vary and Content-Language headers header it gets from Parsoid from Open to Stalled.Jul 5 2018, 7:10 PM
• Pchelolo closed subtask T197792: MCS should proxy Vary and Content-Language headers header it gets from Parsoid as Resolved.Jul 10 2018, 11:25 AM
• bearND reopened subtask T197792: MCS should proxy Vary and Content-Language headers header it gets from Parsoid as Open.Jul 10 2018, 9:45 PM
• Pchelolo closed subtask T197792: MCS should proxy Vary and Content-Language headers header it gets from Parsoid as Resolved.Jul 10 2018, 9:49 PM
• Jhernandez subscribed.Jul 13 2018, 4:32 PM

What's the status on this? Should we move it to blocked? If so, what is it blocked on and what will we do to unblock it? Thanks!

Jdforrester-WMF added a comment.Jul 13 2018, 5:58 PM
In T195948#4423151, @Jhernandez wrote:

What's the status on this? Should we move it to blocked? If so, what is it blocked on and what will we do to unblock it? Thanks!

As originally written, it's done. :-) It's now blocked by its child task for what to do with MW API results. I think that's not covered by what we use "blocked" as that task is internal to the team?

Liuxinyu970226 subscribed.Jul 14 2018, 3:31 AM
• Jhernandez removed a subtask: T197009: MCS should respect Accept-Language header for MW API requests.Jul 16 2018, 2:02 PM
• Jhernandez moved this task from Doing to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

I've unlinked this one from the other one to move on, and moved it to signoff.

• Jhernandez closed this task as Resolved.Jul 20 2018, 10:50 AM
Liuxinyu970226 unsubscribed.Jul 24 2018, 7:13 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL