Page MenuHomePhabricator

+2 for Daimona Eaytoy in AbuseFilter
Closed, ResolvedPublic

Tokens
"Like" token, awarded by Krinkle."Like" token, awarded by MarcoAurelio."Like" token, awarded by Bawolff."Like" token, awarded by ashley."Like" token, awarded by Volker_E."Like" token, awarded by Tgr."Like" token, awarded by Vituzzu."Like" token, awarded by matej_suchanek."Like" token, awarded by Jdforrester-WMF.
Assigned To
Authored By
Legoktm, Jul 18 2018

Description

Daimona is one of the de-facto maintainers of AbuseFilter already, contributing patches and code review. They should have +2 rights. (And maybe in the future +2 in mediawiki/ :))

Event Timeline

Legoktm created this task.Jul 18 2018, 7:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2018, 7:41 AM
Tgr awarded a token.Jul 18 2018, 10:37 AM
Huji added a comment.Jul 18 2018, 7:56 PM

I think Daimona has made a significant, positive impact on AbuseFilter over the last 5-6 months, and I can see his coding getting more mature over time as well. I don't want to discourage him inadvertently, but I also believe in constructive criticism.

I think he has still has some room to grow when it comes to inline documentation, and I have occasionally found rookie mistakes in his code. That said, if we all think that is normal and we still would trust him with +2, I would be happy as well.

I think Daimona has made a significant, positive impact on AbuseFilter over the last 5-6 months, and I can see his coding getting more mature over time as well. I don't want to discourage him inadvertently, but I also believe in constructive criticism.
I think he has still has some room to grow when it comes to inline documentation, and I have occasionally found rookie mistakes in his code. That said, if we all think that is normal and we still would trust him with +2, I would be happy as well.

Everyone makes mistakes, I think it's a question of trust and learning/improvement. And I have no qualms about Daimona in that regard.

Huji added a comment.Jul 18 2018, 9:26 PM

In T199869#4436294, @Legoktm wrote:
Everyone makes mistakes, I think it's a question of trust and learning/improvement. And I have no qualms about Daimona in that regard.

I can also vouch for his ability to learn and improve.

Legoktm closed this task as Resolved.Jul 25 2018, 4:55 PM
Legoktm claimed this task.

Done, congrats :)

Thanks to all of you for the support :-) I chose not to say anything to avoid influencing in any manner the result with biased opininons. I know there's still much I can do to improve my code quality, and that's what I've been trying to do lately, and what I'll continue to do from now on, with increased responsibility. Again, thanks!

Huji added a comment.Jul 25 2018, 8:46 PM

That is the attitude! Congrats :)