Page MenuHomePhabricator
Create Task
Maniphest T201480

Toggle buttons in Phabricator don't work on mobile (affects: Login, Search)
Closed, ResolvedPublic
Actions

Description

I've experienced this repeatedly over the past week on Chrome for iOS. It seems some kind of JavaScript is handling touch/click events in a strange way.

When tapping on the "Developer Log In" button, the LDAP log in form appears but then immediately disappears again. The same also happens for the search icon and the search bar, they almost impossible to keep open.

I can sometimes get it to work when long-pressing on the button and then slowly dragging away from the button. Given it affects multiple buttons in Phabricator (not just our custom login), I assume this is an upstream bug.

Related Objects

Event Timeline

Krinkle created this task.Aug 8 2018, 12:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2018, 12:31 AM
Aklapper added a project: Mobile.Aug 8 2018, 6:31 AM
Pcoombe subscribed.Aug 8 2018, 12:52 PM

I've experienced the same in Chrome (68) on Android.

Cirdan subscribed.Aug 8 2018, 3:24 PM
Framawiki edited projects, added Phabricator (Upstream); removed Phabricator.Aug 8 2018, 4:44 PM
Framawiki added subscribers: epriestley, Framawiki.

Pinging my personal-human-upstream-gateway: @epriestley :)

Restricted Application added a project: Upstream. · View Herald TranscriptAug 8 2018, 4:44 PM
• mmodell edited projects, added Phabricator; removed Upstream, Phabricator (Upstream).Aug 8 2018, 4:45 PM
• mmodell edited subscribers, added: • mmodell; removed: epriestley.

This is a wmf customization, not upstream.

• mmodell edited projects, added Phabricator (Upstream); removed Phabricator.Aug 8 2018, 5:32 PM

I apologize. I didn't read the last sentence of the description. :(

What other phabricator buttons are affected?

Restricted Application added a project: Upstream. · View Herald TranscriptAug 8 2018, 5:32 PM
Aklapper added a comment.Aug 8 2018, 8:27 PM

@Framawiki: Please do not generally CC upstream developers for small bugs. You are free to report bugs to upstream instead, or they are free to subscribe themselves to tasks in our issue tracker. Thanks.

Framawiki added a comment.Aug 9 2018, 4:53 PM
In T201480#4489707, @Aklapper wrote:

@Framawiki: Please do not generally CC upstream developers for small bugs. You are free to report bugs to upstream instead, or they are free to subscribe themselves to tasks in our issue tracker. Thanks.

Hello @Aklapper. Where can I create a bug upstream for phabricator ?

greg subscribed.Aug 9 2018, 5:30 PM

https://discourse.phabricator-community.org/t/guide-reporting-a-bug/938

Jdlrobson moved this task from Needs triage to Triaged on the Mobile board.Aug 9 2018, 9:00 PM
Aklapper merged a task: T172705: Search bar of phabricator isn't easily accessible on mobile devices.Aug 24 2018, 10:58 AM
Aklapper added a subscriber: Kaartic.
Aklapper merged a task: T160045: Search box in Phabricator on Android Chrome closes right away (need to hold down finger to stay open).Aug 24 2018, 11:01 AM
Aklapper moved this task from Backlog to To upstream/missing upstream link on the Upstream board.
Aklapper moved this task from Backlog to Ready To Go on the Phabricator (Upstream) board.
Aklapper added subscribers: Jopparn, Zppix.
Ammarpad subscribed.Mar 23 2019, 7:17 PM
epriestley added a comment.Mar 29 2019, 12:31 AM

I believe this will be (partially?) fixed upstream by the 2019 Week 13 release. See https://secure.phabricator.com/D20343 for particulars.

(This may or may not fix everything mentioned in this task, but should fix the "Search" icon in the main menu bar, at least. It may fix customizations if they use the jx-toggle-class behavior.)

Aklapper merged a task: T221557: LDAP and search icon doesn't let you just tap on it.Apr 22 2019, 6:50 PM
Aklapper mentioned this in T221557: LDAP and search icon doesn't let you just tap on it.
Aklapper added subscribers: TerraCodes, Paladox.
epriestley moved this task from Ready To Go to Solved upstream on the Phabricator (Upstream) board.May 17 2019, 3:18 PM
Aklapper closed this task as Resolved.Jul 4 2019, 12:56 AM
Aklapper edited projects, added Phabricator (2019-07-03); removed Phabricator (Upstream).

We deployed the fix that Evan mentioned on phabricator.wikimedia.org. I cannot make the problem happen on my mobile phone (I tried a Mozilla based browser and a WebKit based browser), so I assume this is resolved.

However, as my phone does not run Android or iOS or such, please reopen this task if you can still reproduce this problem. Thanks!

• mmodell awarded a token.Jul 4 2019, 2:43 PM
Kaartic added a comment.EditedJul 8 2019, 5:43 AM

I used to have issues opening the search bar. On cursory testing, this does seem to be fixed i.e., I am able to tap on search and the search bar shows up as intended without issues. 🎉

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL