| Jdlrobson | |
| Oct 4 2018, 11:01 PM |
| F26312095: Screen Shot 2018-10-04 at 4.09.33 PM.png | |
| Oct 4 2018, 11:09 PM |
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Watchlist
Add the following to LocalSettings and verify you are getting a 500.
$wgHooks['ChangesListSpecialPageQuery'][] = function ( $name, $tables, $fields, $conds, $query_options, $join_conds, $opts ) {
return true;
};Verify the fix makes it go away.
Can you access the watchlist at https://en.wikipedia.beta.wmflabs.org/wiki/Special:Watchlist?
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ovasileva | T206047 SpecialWatchlistQuery is being deprecated, remove usage in SpecialMobileWatchlist | |||
| Resolved | Jdlrobson | T206274 MobileFrontend's Watchlist is causing 500 server error on beta cluster |
As a logged in user tapping modified, I see the following:
https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Watchlist&watchlistview=feed&filter=all PHP fatal error: Argument 5 passed to Wikibase\Client\Hooks\ChangesListSpecialPageHookHandlers::onChangesListSpecialPageQuery() must be an instance of array, null given
My empty watchlist works though.
It's caused by this change: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/463879/3/includes/specials/SpecialMobileWatchlist.php - code has to pass the array, not a null as default argument.
I didn't realize we had a separate one for beta. I wish our Gerrit / tooling errors went there instead of prod!
Change 464814 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Pass query_options to the ChangesListSpecialPageQuery hook
Change 464814 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Pass query_options to the ChangesListSpecialPageQuery hook
New issues now
https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Watchlist&mobileaction=toggle_view_mobile
[W7eX5QpEEj4AAD7IPo4AAAAA] /w/index.php?title=Special:Watchlist&mobileaction=toggle_view_mobile MWException from line 146 of /srv/mediawiki/php-master/includes/FormOptions.php: Invalid option hidepageedits
Backtrace:
#0 /srv/mediawiki/php-master/includes/FormOptions.php(181): FormOptions->validateName(string, boolean)
#1 /srv/mediawiki/php-master/includes/FormOptions.php(402): FormOptions->getValue(string)
#2 /srv/mediawiki/php-master/extensions/Flow/Hooks.php(2181): FormOptions->offsetGet(string)
#3 /srv/mediawiki/php-master/includes/Hooks.php(174): FlowHooks::onChangesListSpecialPageQuery(string, array, array, array, array, array, FormOptions)
#4 /srv/mediawiki/php-master/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#5 /srv/mediawiki/php-master/extensions/MobileFrontend/includes/specials/SpecialMobileWatchlist.php(285): Hooks::run(string, array)
#6 /srv/mediawiki/php-master/extensions/MobileFrontend/includes/specials/SpecialMobileWatchlist.php(72): SpecialMobileWatchlist->doFeedQuery()
#7 /srv/mediawiki/php-master/extensions/MobileFrontend/includes/specials/MobileSpecialPage.php(58): SpecialMobileWatchlist->executeWhenAvailable(NULL)
#8 /srv/mediawiki/php-master/extensions/MobileFrontend/includes/specials/MobileSpecialPageFeed.php(26): MobileSpecialPage->execute(NULL)
#9 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(569): MobileSpecialPageFeed->execute(NULL)
#10 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(568): SpecialPage->run(NULL)
#11 /srv/mediawiki/php-master/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#12 /srv/mediawiki/php-master/includes/MediaWiki.php(868): MediaWiki->performRequest()
#13 /srv/mediawiki/php-master/includes/MediaWiki.php(525): MediaWiki->main()
#14 /srv/mediawiki/php-master/index.php(42): MediaWiki->run()
#15 /srv/mediawiki/w/index.php(3): include(string)
#16 {main}Yeah, it may the problem as different things expect some fields to be present in the FormOptions, even we don't use it, we will have to define same set options as ChangesListSpecialPage, maybe we can re-use the ChangesListSpecialPage class (initialize it just to get the options), but honestly that is one big hack. I didn't get this error as I don't have Flow extension installed.
Let me do a step back, my question is -> do we need to call that hook? /cc @Jdlrobson
Change 464850 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Flow@master] Hide Flow changes from Special:Watchlist on mobile
Let me do a step back, my question is -> do we need to call that hook? /cc @Jdlrobson
Was added by the one and only Brion Vibber so I'm guessing so!
I think it's a little dangerous for Hook users to call methods which may throw exceptions without the exception handling so it makes sense to fix this in Flow.
Change 464870 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Drop hook usage in Watchlist mobile
Change 464850 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] UBN: Hide Flow changes from Special:Watchlist on mobile
Fatals are no longer happening but we need to work out what to do with this hook inside mobilefrontend.
We decided to drop the hook usage anyway, if something goes wrong and mobile watchlist becomes unusable we are able to quickly bring back the old behavior by setting the MFWatchlistRunsChangesListSpecialPageQuery config option to true.
Change 464870 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Drop hook usage in Watchlist mobile via off feature flag
Testing is being taken care of in T206047.
I'll sign this off as I need to make sure we schedule revisiting this config flag (and maybe removing it) later.