Page MenuHomePhabricator

mAllowUsertalk property on User.php is not being used and should be removed
Open, Needs TriagePublic

Event Timeline

dmaza created this task.Dec 6 2018, 6:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 6 2018, 6:17 AM
Anomie added a comment.Dec 6 2018, 2:14 PM

FYI: The value is passed to the UserIsBlockedFrom hook, where #LiquidThreads tries to make use of it.

dmaza added a comment.Dec 6 2018, 5:43 PM

FYI: The value is passed to the UserIsBlockedFrom hook, where #LiquidThreads tries to make use of it.

Right. And UserIsBlockedFrom signature will need to change for this. LiquidThreads can be fix accordingly.

I still think mAllowUsertalk can be removed.