Page MenuHomePhabricator
Create Task
Maniphest T211276

mAllowUsertalk property on User.php is not being used and should be removed
Closed, ResolvedPublic
Actions

Description

https://codesearch.wmflabs.org/search/?q=mAllowUsertalk&i=nope&files=&repos=

Details

SubjectRepoBranchLines +/-
Hard deprecate User::isAllowUsertalkmediawiki/coremaster+12 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

dmaza created this task.Dec 6 2018, 6:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 6 2018, 6:17 AM
Anomie added a comment.Dec 6 2018, 2:14 PM

FYI: The value is passed to the UserIsBlockedFrom hook, where MediaWiki-extensions-LiquidThreads tries to make use of it.

dmaza added a comment.Dec 6 2018, 5:43 PM
In T211276#4803503, @Anomie wrote:

FYI: The value is passed to the UserIsBlockedFrom hook, where MediaWiki-extensions-LiquidThreads tries to make use of it.

Right. And UserIsBlockedFrom signature will need to change for this. LiquidThreads can be fix accordingly.

I still think mAllowUsertalk can be removed.

dbarratt awarded a token.Dec 13 2018, 6:32 PM
JJMC89 moved this task from Backlog to User blocking on the MediaWiki-User-management board.Dec 20 2018, 4:20 AM
DannyS712 edited projects, added MediaWiki-Blocks; removed MediaWiki-User-management.Apr 25 2020, 12:10 AM
Restricted Application added a project: MediaWiki-User-management. · View Herald TranscriptApr 25 2020, 12:10 AM
Aklapper removed a project: MediaWiki-User-management.Apr 25 2020, 12:23 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:01 PM
matej_suchanek claimed this task.Jul 12 2021, 11:30 AM
matej_suchanek added a project: Technical-Debt.
matej_suchanek removed a subscriber: • aezell.
dbarratt unsubscribed.Jul 12 2021, 12:21 PM
gerritbot added a comment.Jul 13 2021, 7:57 AM

Change 704278 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/core@master] Remove User::$mAllowUsertalk and deprecate User::isAllowUsertalk

https://gerrit.wikimedia.org/r/704278

gerritbot added a project: Patch-For-Review.Jul 13 2021, 7:57 AM
gerritbot added a comment.Sep 1 2021, 2:14 PM

Change 704278 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate User::isAllowUsertalk

https://gerrit.wikimedia.org/r/704278

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 1 2021, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 1 2021, 3:10 PM
matej_suchanek changed the task status from Open to Stalled.Sep 2 2021, 11:39 AM

Per Stable interface policy § Removal:

Obsolete behavior MAY be removed after it has been hard deprecated for three months in the development version (the master branch) as well as in one major release

matej_suchanek added a parent task: T277511: Drop hard-deprecated User methods once they've been hard-deprecated in at least once release.Sep 14 2021, 12:50 PM
matej_suchanek changed the task status from Stalled to In Progress.Dec 3 2021, 9:02 AM
matej_suchanek moved this task from Unsorted to Needs removal on the Technical-Debt board.
matej_suchanek closed this task as Resolved.Dec 4 2021, 9:51 AM
matej_suchanek reassigned this task from matej_suchanek to Vlad.shapik.
matej_suchanek subscribed.

Already removed in rMWaac67c6c382797eb122205f614f901ebe8ba12a9.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits