Help panel: add space between paragraphs on confirmation screen in mobile view
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RHo
	Jan 3 2019, 9:24 PM

Description

Apply padding-bottom:1em on the paragraph text in mobile.
Expected:

| Actual:

Help_Panel_spacing_2019-01-02.png (1×750 px, 98 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Help Panel: Paragraph margin and section heading text	mediawiki/extensions/GrowthExperiments	master	+13 -11

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		MMiller_WMF	T206711 [EPIC] Growth: help panel
		Resolved		kostajh	T212901 Help panel: add space between paragraphs on confirmation screen in mobile view

Event Timeline

RHo created this task.Jan 3 2019, 9:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 3 2019, 9:24 PM

RHo mentioned this in T211633: Help panel: design tweaks.Jan 3 2019, 9:54 PM

RHo triaged this task as Medium priority.Jan 4 2019, 6:26 PM

kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 4 2019, 6:30 PM

kostajh claimed this task.Jan 4 2019, 7:48 PM

kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 482344 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Help Panel: Paragraph margin and section heading text

https://gerrit.wikimedia.org/r/482344

gerritbot added a project: Patch-For-Review.Jan 4 2019, 8:14 PM

kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 4 2019, 8:15 PM

kostajh mentioned this in rEGRE3b1631226219: Help Panel: Paragraph margin and section heading text.Jan 4 2019, 8:15 PM

Change 482344 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help Panel: Paragraph margin and section heading text

https://gerrit.wikimedia.org/r/482344

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.12; 2019-01-08).Jan 4 2019, 10:00 PM

MMiller_WMF added a parent task: T206711: [EPIC] Growth: help panel.Jan 4 2019, 10:41 PM

MMiller_WMF added subscribers: kostajh, Catrope, SBisson and 6 others.

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 4 2019, 10:56 PM

Etonkovidova mentioned this in T212551: [minor] Help panel: the checkmark for "Your question has been posted" displayed on a new line .Jan 7 2019, 8:21 PM

Checked in betalabs browser simulator and on iPhone 6S.

Screen Shot 2019-01-07 at 10.23.16 AM.png (515×404 px, 44 KB)

iPhone 6s -notice that in the real device the check mark on a different line - it's not reproducible in a simulator. I added it to T212551: [minor] Help panel: the checkmark for "Your question has been posted" displayed on a new line .

MMiller_WMF reopened this task as Open.Jan 7 2019, 8:59 PM

MMiller_WMF moved this task from QA to Design Review on the Growth-Team (Sprint 0 (Growth Team)) board.

LGTM

Desktop

Mobile

MMiller_WMF closed this task as Resolved.Jan 15 2019, 12:12 AM

MMiller_WMF moved this task from Needs PM Review to Epics In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

jijiki mentioned this in rEGRE7a1dbbe9eff3: Help Panel: Paragraph margin and section heading text.Mar 18 2019, 4:30 PM

	F27814979: Screen Shot 2019-01-07 at 10.23.16 AM.png
	Jan 7 2019, 8:26 PM

	F27779394: Help_Panel_spacing_2019-01-02.png
	Jan 3 2019, 9:24 PM

	F27821359: image.png
	Jan 8 2019, 12:15 PM

	F27821353: image.png
	Jan 8 2019, 12:15 PM

	F27785819: Artboard Copy.png
	Jan 3 2019, 9:24 PM

Help panel: add space between paragraphs on confirmation screen in mobile viewClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Help panel: add space between paragraphs on confirmation screen in mobile view
Closed, ResolvedPublic
Actions

Related Objects
Search...