Page MenuHomePhabricator

Help panel: add space between paragraphs on confirmation screen in mobile view
Closed, ResolvedPublic

Assigned To
Authored By
RHo
Jan 3 2019, 9:24 PM
Referenced Files
F27821359: image.png
Jan 8 2019, 12:15 PM
F27821353: image.png
Jan 8 2019, 12:15 PM
F27815004: IMG_6663.PNG
Jan 7 2019, 8:26 PM
F27814979: Screen Shot 2019-01-07 at 10.23.16 AM.png
Jan 7 2019, 8:26 PM
F27785819: Artboard Copy.png
Jan 3 2019, 9:24 PM
F27779394: Help_Panel_spacing_2019-01-02.png
Jan 3 2019, 9:24 PM

Description

Apply padding-bottom:1em on the paragraph text in mobile.
Expected:

Artboard Copy.png (360×375 px, 53 KB)
| Actual:
Help_Panel_spacing_2019-01-02.png (750×1,334 px, 98 KB)

Event Timeline

RHo triaged this task as Medium priority.Jan 4 2019, 6:26 PM

Change 482344 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Help Panel: Paragraph margin and section heading text

https://gerrit.wikimedia.org/r/482344

Change 482344 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help Panel: Paragraph margin and section heading text

https://gerrit.wikimedia.org/r/482344

Checked in betalabs browser simulator and on iPhone 6S.

Screen Shot 2019-01-07 at 10.23.16 AM.png (404×515 px, 44 KB)

iPhone 6s -notice that in the real device the check mark on a different line - it's not reproducible in a simulator. I added it to T212551: [minor] Help panel: the checkmark for "Your question has been posted" displayed on a new line .

IMG_6663.PNG (640×1,136 px, 95 KB)