Page MenuHomePhabricator
Create Task
Maniphest T213341

Don't allow structured data captions/statements on "File" pages which are just redirects
Closed, ResolvedPublic
Actions

Description

https://test-commons.wikimedia.org/w/index.php?title=File:Bluesq.png&redirect=no has very low user value.

Details

SubjectRepoBranchLines +/-
Hide structured data captions on redirect pagesmediawiki/extensions/WikibaseMediaInfomaster+7 -2
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Jan 9 2019, 9:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 9 2019, 9:15 PM
• Ramsey-WMF subscribed.Jan 9 2019, 11:05 PM
Herzi.Pinki mentioned this in T213594: Disable Captions on Commons redirects.Jan 12 2019, 2:10 AM
Multichill merged a task: T213594: Disable Captions on Commons redirects.Jan 12 2019, 11:29 AM
Multichill added subscribers: Roy17, Herzi.Pinki, Abit, Keegan.
Fuzheado subscribed.Jan 12 2019, 11:53 AM
VIGNERON subscribed.Jan 12 2019, 4:28 PM
gerritbot subscribed.Jan 12 2019, 8:01 PM

Change 483950 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] Hide structured data captions on redirect pages

https://gerrit.wikimedia.org/r/483950

gerritbot added a project: Patch-For-Review.Jan 12 2019, 8:01 PM
Jdforrester-WMF claimed this task.Jan 12 2019, 8:01 PM
Jdforrester-WMF moved this task from To Do to Doing on the Structured Data Engineering board.
Jdforrester-WMF mentioned this in rEWBI7292f5a60f1a: Hide structured data captions on redirect pages.Jan 12 2019, 8:05 PM
Jdforrester-WMF mentioned this in rEWBIcf2a3ec947a7: Hide structured data captions on redirect pages.Jan 12 2019, 9:12 PM
Jdforrester-WMF mentioned this in rEWBId495026292ef: Hide structured data captions on redirect pages.Jan 12 2019, 9:29 PM
Jdforrester-WMF removed a project: Patch-For-Review.Jan 14 2019, 5:50 PM
Jdforrester-WMF moved this task from Doing to Verify on Production on the Structured Data Engineering board.
gerritbot added a comment.Jan 14 2019, 5:58 PM

Change 483950 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Hide structured data captions on redirect pages

https://gerrit.wikimedia.org/r/483950

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.13; 2019-01-15).Jan 14 2019, 6:00 PM
Roy17 unsubscribed.Jan 16 2019, 9:00 PM

So the tentative solution as implemented is to hide the input field for redirects? But when the redirect link is malformed, it would show up. Perhaps the input field should be hidden for all pages without a file.

Jdforrester-WMF added a subscriber: Roy17.Jan 16 2019, 11:40 PM
In T213341#4885986, @Roy17 wrote:

So the tentative solution as implemented is to hide the input field for redirects? But when the redirect link is malformed, it would show up.

Not tentative, merged, and now deployed to Wikimedia Commons.

Perhaps the input field should be hidden for all pages without a file.

File pages that don't exist already don't get a captions box. Checking for binary file being attached could be a bit too expensive a test.

• Ramsey-WMF closed this task as Resolved.Jan 17 2019, 8:39 PM

Confirmed working on production with Redirect-testing.jpg and ImageRedirectTest.jpg

greg added a project: Multimedia.Mar 7 2019, 10:59 PM
jijiki mentioned this in rEWBI9514b4df0c94: Hide structured data captions on redirect pages.Mar 18 2019, 4:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits