Page MenuHomePhabricator
Create Task
Maniphest T214317

Phase out deprecated Title::isValidMoveTarget
Closed, ResolvedPublic
Actions

Description

Title::isValidMoveTarget has been deprecated since 1.25 in favor of MovePage, but is still used in a couple of places. All usages should be replaced, and the method should be hard-deprecated (should call wfDeprecated()), and scheduled for removal in 1.34.

Details

SubjectRepoBranchLines +/-
Hard-deprecation of Title::isValidMoveTargetmediawiki/coremaster+6 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

daniel created this task.Jan 21 2019, 4:49 PM
Restricted Application added projects: Commons, Multimedia. · View Herald TranscriptJan 21 2019, 4:49 PM
Aklapper added a project: Technical-Debt.Jan 21 2019, 10:12 PM
CCicalese_WMF added a project: Platform Team Workboards.Jan 23 2019, 2:07 PM
CCicalese_WMF moved this task from Not a real column to Ready on the Platform Team Workboards board.Jan 25 2019, 2:40 PM
BPirkle reassigned this task from BPirkle to Hknust.Feb 28 2019, 8:24 PM
BPirkle subscribed.
Reedy updated the task description. (Show Details)Feb 28 2019, 8:24 PM
Reedy updated the task description. (Show Details)Feb 28 2019, 8:26 PM
gerritbot subscribed.Mar 6 2019, 5:29 PM

Change 494789 had a related patch set uploaded (by Holger Knust; owner: Holger Knust):
[mediawiki/core@master] Hard-deprecation of Title::isValidMoveTarget

https://gerrit.wikimedia.org/r/494789

gerritbot added a project: Patch-For-Review.Mar 6 2019, 5:29 PM
gerritbot added a comment.Mar 15 2019, 8:29 PM

Change 494789 had a related patch set uploaded (by Holger Knust; owner: Holger Knust):
[mediawiki/core@master] Hard-deprecation of Title::isValidMoveTarget

https://gerrit.wikimedia.org/r/494789

greg subscribed.Mar 25 2019, 4:59 PM

Just to check, what I gathered from the Scrum of Scrums notice last week is that this is blocked on the removal of the UserMerge extension (T216089)?

• holger.knust subscribed.Mar 25 2019, 6:18 PM

Yes, currently on hold until T216089 is merged.

CCicalese_WMF edited projects, added Platform Engineering (Decoupling (CDP2)), Platform Team Workboards (Blocked Externally); removed Platform Team Workboards, MediaWiki-Decoupling, Platform Engineering (Needs Cleaning - Code Health (TEC13)).Mar 26 2019, 4:47 PM
WDoranWMF removed a project: Platform Team Workboards (Blocked Externally).Jul 5 2019, 7:14 PM
WDoranWMF moved this task from Decoupling (CDP2) to mop on the Platform Engineering board.Jul 26 2019, 6:56 PM
WDoranWMF edited projects, added Core Platform Team Initiatives (Decoupling (CDP2)); removed Platform Engineering (Decoupling (CDP2)).
DannyS712 moved this task from Unsorted to Migrate / Replace on the Technical-Debt board.Nov 18 2019, 7:49 AM
Daimona closed this task as Resolved.Mar 8 2020, 5:09 PM
Daimona subscribed.

This was done.

gerritbot added a comment.Aug 17 2020, 2:43 PM

Change 494789 abandoned by Thiemo Kreuz (WMDE):
[mediawiki/core@master] Hard-deprecation of Title::isValidMoveTarget

Reason:
Apparently the method does not exist any more since 1.35.

https://gerrit.wikimedia.org/r/494789

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL