Page MenuHomePhabricator

Don't hardcode castor url in castor docker container
Closed, ResolvedPublic

Event Timeline

thcipriani triaged this task as Medium priority.Feb 15 2019, 2:02 PM
thcipriani created this task.

It is a bit of a mess. The instance fqdn is hardcoded in jjb/castor-load-sync.bash which is the inlined in the jobs definition in jjb/castor.yaml. The last two jobs using that logics are to be migrated to Docker containers:

wikidata-query-gui-buildT210286
wikimedia-portals-buildT213806

Then we have releng/castor which includes the same shell snippets. The files under jjb/ are simply symlinked under dockerfiles/castor/.

All of that is crazy :(

Can the host just be exposed in CI generally as an env var?

Change 770920 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: tie castor saving job to a label

https://gerrit.wikimedia.org/r/770920

Change 770921 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] dockerfiles: castor hostname from CASTOR_HOST env

https://gerrit.wikimedia.org/r/770921

Mentioned in SAL (#wikimedia-releng) [2022-03-15T14:30:48Z] <hashar> CI Jenkins: globally defined CASTOR_HOST=integration-castor03.integration.eqiad.wmflabs via https://integration.wikimedia.org/ci/configure # T216244

Change 770920 merged by jenkins-bot:

[integration/config@master] jjb: tie castor saving job to a label

https://gerrit.wikimedia.org/r/770920

Change 770921 merged by jenkins-bot:

[integration/config@master] dockerfiles: set castor hostname from CASTOR_HOST env

https://gerrit.wikimedia.org/r/770921

Mentioned in SAL (#wikimedia-releng) [2022-03-17T14:07:03Z] <hashar> Building Docker image to support CASTOR_HOST | https://gerrit.wikimedia.org/r/770921 | T216244

Change 771608 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update castor image to support CASTOR_HOST

https://gerrit.wikimedia.org/r/771608

Change 771608 merged by jenkins-bot:

[integration/config@master] jjb: update castor image to support CASTOR_HOST

https://gerrit.wikimedia.org/r/771608

The Docker image now supports overriding the Castor instance by setting the CASTOR_HOST environment variable.

It is configured on https://integration.wikimedia.org/ci/configure

All Jenkins jobs have been switched.

When we want to migrate the service to another instance (T252071) we can thus change the value in the CI Jenkins global configuration.