Page MenuHomePhabricator
Create Task
Maniphest T216244

Don't hardcode castor url in castor docker container
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
jjb: update castor image to support CASTOR_HOSTintegration/configmaster+3 -3
dockerfiles: set castor hostname from CASTOR_HOST envintegration/configmaster+70 -1
jjb: tie castor saving job to a labelintegration/configmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani triaged this task as Medium priority.Feb 15 2019, 2:02 PM
thcipriani created this task.
hashar added subtasks: T213806: Migrate wikimedia-portals-build to Docker container, T210286: Create docker based CI job to build the wikidata-query-gui.Feb 20 2019, 2:18 PM
hashar subscribed.Feb 20 2019, 2:22 PM

It is a bit of a mess. The instance fqdn is hardcoded in jjb/castor-load-sync.bash which is the inlined in the jobs definition in jjb/castor.yaml. The last two jobs using that logics are to be migrated to Docker containers:

wikidata-query-gui-buildT210286
wikimedia-portals-buildT213806

Then we have releng/castor which includes the same shell snippets. The files under jjb/ are simply symlinked under dockerfiles/castor/.

All of that is crazy :(

greg moved this task from INBOX to Backlog on the Release-Engineering-Team board.Mar 5 2019, 12:41 AM
greg edited projects, added Release-Engineering-Team (Backlog); removed Release-Engineering-Team.
• Phabricator_maintenance edited projects, added Release-Engineering-Team-TODO; removed Release-Engineering-Team (Backlog).Jun 12 2019, 11:51 PM
• Phabricator_maintenance moved this task from Should be empty (use Release-Engineering-Team) to Later / Need volunteer on the Release-Engineering-Team-TODO board.Jun 12 2019, 11:55 PM
greg added a project: Release-Engineering-Team.Jun 21 2019, 10:35 PM
greg edited projects, added Release-Engineering-Team (CI & Testing services); removed Release-Engineering-Team.Jun 24 2019, 7:51 PM
Jdforrester-WMF closed subtask T213806: Migrate wikimedia-portals-build to Docker container as Resolved.Apr 27 2020, 11:46 PM
hashar added a project: Castor.Aug 5 2020, 5:28 PM
Addshore closed subtask T210286: Create docker based CI job to build the wikidata-query-gui as Resolved.Mar 19 2021, 2:58 PM
Addshore subscribed.Mar 19 2021, 3:03 PM

Can the host just be exposed in CI generally as an env var?

WMDE-Fisch unsubscribed.Mar 24 2021, 1:36 PM
thcipriani removed a project: Release-Engineering-Team (CI & Testing services).Apr 20 2021, 1:09 AM
thcipriani edited projects, added Release-Engineering-Team (thcipriani-workboard-fiddling); removed Release-Engineering-Team-TODO.Apr 20 2021, 3:41 AM
thcipriani moved this task from thcipriani-workboard-fiddling to Seen (ARCHIVE) on the Release-Engineering-Team board.Apr 20 2021, 3:53 AM
thcipriani edited projects, added Release-Engineering-Team; removed Release-Engineering-Team (thcipriani-workboard-fiddling).
thcipriani edited projects, added Release-Engineering-Team (Seen); removed Release-Engineering-Team.Apr 20 2021, 3:23 PM
Stashbot added a comment.Mar 15 2022, 2:17 PM

Mentioned in SAL (#wikimedia-releng) [2022-03-15T14:17:22Z] <hashar> Apply label castor to node https://integration.wikimedia.org/ci/computer/integration-castor03/ # T216244

hashar claimed this task.Mar 15 2022, 2:19 PM
hashar edited projects, added Release-Engineering-Team (🚂🧪 Trainsperiment Week); removed Release-Engineering-Team (Seen).
gerritbot added a comment.Mar 15 2022, 2:21 PM

Change 770920 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: tie castor saving job to a label

https://gerrit.wikimedia.org/r/770920

gerritbot added a project: Patch-For-Review.Mar 15 2022, 2:21 PM
gerritbot added a comment.Mar 15 2022, 2:28 PM

Change 770921 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] dockerfiles: castor hostname from CASTOR_HOST env

https://gerrit.wikimedia.org/r/770921

Stashbot added a comment.Mar 15 2022, 2:30 PM

Mentioned in SAL (#wikimedia-releng) [2022-03-15T14:30:48Z] <hashar> CI Jenkins: globally defined CASTOR_HOST=integration-castor03.integration.eqiad.wmflabs via https://integration.wikimedia.org/ci/configure # T216244

hashar moved this task from Backlog to In progress on the Release-Engineering-Team (🚂🧪 Trainsperiment Week) board.Mar 15 2022, 2:50 PM
gerritbot added a comment.Mar 15 2022, 3:08 PM

Change 770920 merged by jenkins-bot:

[integration/config@master] jjb: tie castor saving job to a label

https://gerrit.wikimedia.org/r/770920

gerritbot added a comment.Mar 17 2022, 2:06 PM

Change 770921 merged by jenkins-bot:

[integration/config@master] dockerfiles: set castor hostname from CASTOR_HOST env

https://gerrit.wikimedia.org/r/770921

Restricted Application added a subscriber: RhinosF1. · View Herald TranscriptMar 17 2022, 2:06 PM
Stashbot added a comment.Mar 17 2022, 2:07 PM

Mentioned in SAL (#wikimedia-releng) [2022-03-17T14:07:03Z] <hashar> Building Docker image to support CASTOR_HOST | https://gerrit.wikimedia.org/r/770921 | T216244

gerritbot added a comment.Mar 17 2022, 2:10 PM

Change 771608 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update castor image to support CASTOR_HOST

https://gerrit.wikimedia.org/r/771608

Stashbot mentioned this in T252071: Move all Wikimedia CI (WMCS integration project) instances from stretch to buster/bullseye.Mar 17 2022, 2:11 PM

Mentioned in SAL (#wikimedia-releng) [2022-03-17T14:11:47Z] <hashar> Update all jobs to support CASTOR_HOST env variable | https://gerrit.wikimedia.org/r/770921 | T216244 | T252071

gerritbot added a comment.Mar 17 2022, 2:12 PM

Change 771608 merged by jenkins-bot:

[integration/config@master] jjb: update castor image to support CASTOR_HOST

https://gerrit.wikimedia.org/r/771608

hashar closed this task as Resolved.Mar 17 2022, 2:31 PM

The Docker image now supports overriding the Castor instance by setting the CASTOR_HOST environment variable.

It is configured on https://integration.wikimedia.org/ci/configure

All Jenkins jobs have been switched.

When we want to migrate the service to another instance (T252071) we can thus change the value in the CI Jenkins global configuration.

Maintenance_bot removed a project: Patch-For-Review.Mar 17 2022, 3:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits