⚓ T221314 Edit cards: deploy v1 to bn.wiki, he.wiki and fa.wiki

Subject	Repo	Branch	Lines +/-
Merge remote-tracking branch 'gerrit/wmf/1.34.0-wmf.10' into HEAD	mediawiki/extensions/VisualEditor	wmf/1.34.0-wmf.8	+0 -0
Update extensions/VisualEditor submodule to wmf/1.34.0-wmf.10	mediawiki/core	wmf/1.34.0-wmf.8	+1 -1
Enable new mobile contexts on bn/fa/hewiki	operations/mediawiki-config	master	+12 -0

Status	Assigned	Task
Resolved	None	T221247 [Epic] Mobile context items
Invalid	None	T221307 [Engineering Epic] Mobile edit cards
Resolved	ppelberg	T221309 Mobile edit cards: deploy v1.0 of "adding/modifying links" to prototype server
Resolved	ppelberg	T221314 Edit cards: deploy v1 to bn.wiki, he.wiki and fa.wiki

ppelberg created this task.Apr 17 2019, 10:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2019, 10:34 PM

ppelberg added a parent task: T221307: [Engineering Epic] Mobile edit cards.Apr 17 2019, 10:35 PM

ppelberg mentioned this in T221296: Edit cards: instrument existing "adding/modifying links" flow.Apr 25 2019, 1:07 AM

ppelberg mentioned this in T221306: Edit cards: instrument existing "adding/modifying citations" flow.Apr 25 2019, 1:11 AM

ppelberg renamed this task from Edit cards: deploy to train to Edit cards: deploy v1 to bn.wiki, he.wiki and fa.wiki.Jun 13 2019, 1:48 AM

ppelberg edited projects, added VisualEditor-MediaWiki-Mobile, VisualEditor (Current work); removed VisualEditor.

ppelberg updated the task description. (Show Details)

ppelberg added a parent task: T221309: Mobile edit cards: deploy v1.0 of "adding/modifying links" to prototype server.

ppelberg removed a parent task: T221307: [Engineering Epic] Mobile edit cards.Jun 13 2019, 1:59 PM

ppelberg added a subscriber: • Esanders.Jun 14 2019, 2:41 AM

ppelberg mentioned this in T221309: Mobile edit cards: deploy v1.0 of "adding/modifying links" to prototype server.Jun 14 2019, 2:46 AM

TODO: Write config change patch for this.

ppelberg mentioned this in T221311: Mobile edit cards: pre-deployment QA "adding/modifying links".Jun 18 2019, 4:47 PM

ppelberg updated the task description. (Show Details)Jun 19 2019, 5:14 AM

Change 518051 had a related patch set uploaded (by Esanders; owner: Esanders):
[operations/mediawiki-config@master] Enable new mobile contexts on bn/fa/hewiki

https://gerrit.wikimedia.org/r/518051

gerritbot added a project: Patch-For-Review.Jun 20 2019, 3:00 PM

Scheduled for deployment today: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20190620T1800

Change 518051 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable new mobile contexts on bn/fa/hewiki

https://gerrit.wikimedia.org/r/518051

We deployed the patch, but when testing, I realized that the production wikis are still running software version wmf.8 (from ~two weeks ago) rather than wmf.10 (from this week), and so the new code for mobile contexts is not deployed. Apparently there have been some issues with it, see T220735: 1.34.0-wmf.10 deployment blockers (not related to VisualEditor).

I have no idea when that will be resolved, it looks like no one figured out yet what is causing the problems…

I'm not sure what's the timeline for this task. If we need to have the new contexts available for testing or something soon, then we should backport wmf.10 VisualEditor changes to the wmf.8 branch (I can do that). If we can wait, then the new contexts will kick in whenever wmf.10 is fixed and redeployed.

matmarex moved this task from Incoming to In progress on the VisualEditor (Current work) board.Jun 20 2019, 6:55 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2019, 7:10 PM

Change 518141 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@wmf/1.34.0-wmf.8] Update extensions/VisualEditor submodule to wmf/1.34.0-wmf.10

https://gerrit.wikimedia.org/r/518141

gerritbot added a project: Patch-For-Review.Jun 20 2019, 8:39 PM

Change 518141 abandoned by Jforrester:
Update extensions/VisualEditor submodule to wmf/1.34.0-wmf.10

Reason:
Let's do a merge commit instead.

https://gerrit.wikimedia.org/r/518141

Change 518142 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.34.0-wmf.8] Merge remote-tracking branch 'gerrit/wmf/1.34.0-wmf.10' into HEAD

https://gerrit.wikimedia.org/r/518142

Change 518142 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.34.0-wmf.8] Merge remote-tracking branch 'gerrit/wmf/1.34.0-wmf.10' into HEAD

https://gerrit.wikimedia.org/r/518142

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.8; 2019-06-04).Jun 20 2019, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2019, 10:10 PM

And it's live! (with help from @Jdforrester-WMF)

We had to make sure that we didn't make any changes in our wmf.10 code that require the wmf.10 version of any other code (or backport them). For reference, we needed the following changes in wmf.8:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/518142 "Merge remote-tracking branch 'gerrit/wmf/1.34.0-wmf.10' into HEAD" – pull in all the VisualEditor commits from wmf.10
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/518144 "Revert "MobileArticleTarget: Update loading interface for new design"" – revert one commit that was incompatible with wmf.8 (required changes in MobileFrontend)
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GuidedTour/+/518147 "Use correct message for VE publish" – fix a lint failure that would otherwise result from 2b7bbf07