Page MenuHomePhabricator
Create Task
Maniphest T222405

Homepage: null pageviews should not be a link
Closed, ResolvedPublicBUG REPORT
Actions

Description

This bug found by @Urbanecm.

Steps to Reproduce:

Open up a production Wikipedia. Save an edit on a page in the article namespace. Go to your newcomer homepage. Click the link in the impact module for that article's pageviews (the link labeled "--").

Actual Results:

The "--" is a link that tries to open up the Pageviews Analysis tool, which tries to open with a "from" date after the "to" date. This spins for a couple minutes and then errors out. That bug with the Pageviews Analysis tool is filed at T222403.

image.png (534×1 px, 295 KB)

Expected Results:

The "--" should not be a link at all, because there are no pageviews to see yet. We want to convey to the newbie that they should check back tomorrow for pageviews, but we haven't come up with a good design for that yet (T216220).

Note: this is important to fix before turning on the experiment on May 6.

Details

SubjectRepoBranchLines +/-
Impact: No link to pageviews tool when data is not available (--)mediawiki/extensions/GrowthExperimentswmf/1.34.0-wmf.3+63 -50
Impact: No link to pageviews tool when data is not available (--)mediawiki/extensions/GrowthExperimentsmaster+63 -50
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 Resolved• RileychT213990 [EPIC] Growth: Newcomer homepage
 ResolvedMMiller_WMFT216217 Homepage: impact module
 ResolvedBUG REPORTSBissonT222405 Homepage: null pageviews should not be a link

Event Timeline

MMiller_WMF created this task.May 2 2019, 10:17 PM
Restricted Application added a subscriber: MusikAnimal. · View Herald TranscriptMay 2 2019, 10:17 PM
MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.May 2 2019, 10:17 PM
MMiller_WMF updated the task description. (Show Details)
SBisson claimed this task.May 3 2019, 12:30 PM
SBisson moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.May 3 2019, 1:10 PM

Change 507956 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Impact: No link to pageviews tool when data is not available (--)

https://gerrit.wikimedia.org/r/507956

gerritbot added a project: Patch-For-Review.May 3 2019, 1:10 PM
SBisson mentioned this in rEGRE100dde868979: Impact: No link to pageviews tool when data is not available (--).May 3 2019, 1:11 PM
SBisson mentioned this in rEGRE0832b6e2f44e: Impact: No link to pageviews tool when data is not available (--).May 3 2019, 1:23 PM
SBisson moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 3 2019, 1:49 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 3 2019, 3:16 PM
kostajh added a project: GrowthExperiments-Homepage.
SBisson mentioned this in rEGREd7aa31a4d9f0: Impact: No link to pageviews tool when data is not available (--).May 3 2019, 6:32 PM
gerritbot added a comment.May 3 2019, 8:02 PM

Change 507956 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Impact: No link to pageviews tool when data is not available (--)

https://gerrit.wikimedia.org/r/507956

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.4; 2019-05-07).May 3 2019, 9:00 PM
Etonkovidova closed this task as Resolved.May 5 2019, 10:17 PM
Etonkovidova moved this task from QA to Needs PM Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Moving for PM review. Checked in betalabs - the link is not present until Pageviews will get updated info.

Open questions:
(1) Could we prioritize T216220: Homepage: design for indicating that the user should check back for pageviews and T216220: Homepage: design for indicating that the user should check back for pageviews?
(2) Presently there is no info to user (not even a tooltip) what -- means. And -- stays on a page for about 24h.

gerritbot added a comment.May 6 2019, 1:12 PM

Change 508315 had a related patch set uploaded (by Kosta Harlan; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.3] Impact: No link to pageviews tool when data is not available (--)

https://gerrit.wikimedia.org/r/508315

kostajh mentioned this in rEGRE8a512eb806d9: Impact: No link to pageviews tool when data is not available (--).May 6 2019, 1:14 PM
Catrope mentioned this in rEGRE3ad43838af8b: Impact: No link to pageviews tool when data is not available (--).May 6 2019, 6:24 PM
MMiller_WMF mentioned this in T216220: Homepage: design for indicating that the user should check back for pageviews.May 6 2019, 6:36 PM
gerritbot added a comment.May 6 2019, 6:41 PM

Change 508315 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.3] Impact: No link to pageviews tool when data is not available (--)

https://gerrit.wikimedia.org/r/508315

Stashbot added a comment.May 6 2019, 6:47 PM

Mentioned in SAL (#wikimedia-operations) [2019-05-06T18:47:10Z] <catrope@deploy1001> Synchronized php-1.34.0-wmf.3/extensions/GrowthExperiments/: Remove link to pageviews tool when no data available (T222405) (duration: 00m 52s)

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.3; 2019-04-30); removed MW-1.34-notes (1.34.0-wmf.4; 2019-05-07).May 6 2019, 7:00 PM
Aklapper removed a project: GrowthExperiments.Sep 11 2019, 12:47 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 11 2019, 1:10 PM
Urbanecm edited subscribers, added: Urbanecm_WMF; removed: Urbanecm.Aug 26 2020, 2:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits