Page MenuHomePhabricator
Create Task
Maniphest T222835

Mobile Homepage: tabs layout
Closed, ResolvedPublic
Actions

Description

This task is about bringing the tab layout to mobile to switch between homepage, userpage, and usertalk, just like on desktop.

See parent task for detailed specs.

Details

SubjectRepoBranchLines +/-
Output AMC-style tabs on Special:Homepage and User pagemediawiki/extensions/GrowthExperimentsmaster+46 -6
Add hook to override SkinOptions, and allow overriding tabs outputmediawiki/skins/MinervaNeuemaster+30 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

SBisson created this task.May 8 2019, 6:54 PM
SBisson moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.May 8 2019, 7:23 PM
MMiller_WMF mentioned this in T222836: Mobile Homepage: instrumentation.May 30 2019, 12:40 AM
kostajh claimed this task.May 31 2019, 1:43 PM
kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.May 31 2019, 5:29 PM

Change 513649 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/skins/MinervaNeue@master] WIP: Add hook to override SkinOptions, and override tabs output

https://gerrit.wikimedia.org/r/513649

gerritbot added a project: Patch-For-Review.May 31 2019, 5:29 PM

Change 513650 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] WIP: Output AMC-style tabs on Special:Homepage and User page

https://gerrit.wikimedia.org/r/513650

• Cntlsn added a comment.EditedJun 4 2019, 2:19 PM

@kostajh @SBisson
This task T223142, about making the tabbed menu translation proof, is related.
This task T222835, about hiding the homepage intro text after the first visit, can also be related.

kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 4 2019, 3:10 PM

Note that we either need to feature flag this or wait for T222832 to be done before merging the GrowthExperiments patch.

• alexhollender_WMF unsubscribed.Jun 5 2019, 2:04 PM
kostajh moved this task from Code Review to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 5 2019, 4:09 PM
gerritbot added a comment.Jun 5 2019, 9:49 PM

Change 513649 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Add hook to override SkinOptions, and allow overriding tabs output

https://gerrit.wikimedia.org/r/513649

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 5 2019, 10:00 PM
SBisson moved this task from In Progress to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 6 2019, 12:58 AM
gerritbot added a comment.Jun 6 2019, 1:23 AM

Change 513650 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Output AMC-style tabs on Special:Homepage and User page

https://gerrit.wikimedia.org/r/513650

Maintenance_bot removed a project: Patch-For-Review.Jun 6 2019, 2:10 AM
Etonkovidova moved this task from QA to Needs PM Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 7 2019, 1:31 PM

Checked the tabbed layout in betalbs - the found issues (out of the scope of this task) are filed as a separate task T225288.

MMiller_WMF reassigned this task from kostajh to • Cntlsn.Jun 7 2019, 11:10 PM
MMiller_WMF moved this task from Needs PM Review to Design Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Moving back to Design Review before it goes to PM Review. @Cntlsn -- please try out the tabs in mobile on beta, and add any issues you find to T225288.

ovasileva moved this task from Needs triage to Triaged on the Mobile board.Jun 11 2019, 1:50 PM
• Cntlsn removed • Cntlsn as the assignee of this task.Jun 12 2019, 5:43 PM
• Cntlsn moved this task from Design Review to Needs PM Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Added a couple of issues to T225288. Moving to "Needs PM Review" column

MMiller_WMF added a comment.Jun 12 2019, 9:48 PM

This will stay here until the feature is in production.

MMiller_WMF closed this task as Resolved.Jul 3 2019, 11:45 PM
MMiller_WMF claimed this task.

This is working in production.

Aklapper removed a project: GrowthExperiments.Sep 11 2019, 12:47 PM
Urbanecm edited subscribers, added: Urbanecm_WMF; removed: Urbanecm.Aug 26 2020, 1:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL