Page MenuHomePhabricator
Create Task
Maniphest T223995

BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses)
Closed, ResolvedPublic5 Estimated Story PointsPRODUCTION ERROR
Actions

Description

To Do

  • implement MediaWikiPageSubEntityMetaDataAccessor::loadRevisionInformation
  • add tests for the new implementation

The following API call results in a fatal error: https://www.wikidata.org/w/api.php?action=wbgetentities&format=json&origin=*&ids=L11533-F7

API Sandbox: https://www.wikidata.org/wiki/Special:ApiSandbox#action=wbgetentities&format=json&ids=L123-F3&props=labels%7Cdescriptions&languages=de&languagefallback=1

Stacktrace:

BadMethodCallException from line 42 of /srv/mediawiki/php-1.34.0-wmf.5/extensions/WikibaseLexeme/src/DataAccess/Store/MediaWikiPageSubEntityMetaDataAccessor.php: Not Implemented

#0 /srv/mediawiki/php-1.34.0-wmf.5/extensions/Wikibase/lib/includes/Store/Sql/TypeDispatchingWikiPageEntityMetaDataAccessor.php(89): Wikibase\Lexeme\DataAccess\Store\MediaWikiPageSubEntityMetaDataAccessor->loadRevisionInformation(array, string)
#1 /srv/mediawiki/php-1.34.0-wmf.5/extensions/Wikibase/lib/includes/Store/Sql/PrefetchingWikiPageEntityMetaDataAccessor.php(264): Wikibase\Lib\Store\Sql\TypeDispatchingWikiPageEntityMetaDataAccessor->loadRevisionInformation(array, string)
#2 /srv/mediawiki/php-1.34.0-wmf.5/extensions/Wikibase/lib/includes/Store/Sql/PrefetchingWikiPageEntityMetaDataAccessor.php(186): Wikibase\Lib\Store\Sql\PrefetchingWikiPageEntityMetaDataAccessor->doFetch(string)
#3 /srv/mediawiki/php-1.34.0-wmf.5/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php(179): Wikibase\Lib\Store\Sql\PrefetchingWikiPageEntityMetaDataAccessor->loadRevisionInformation(array, string)
#4 /srv/mediawiki/php-1.34.0-wmf.5/extensions/Wikibase/lib/includes/Store/DispatchingEntityRevisionLookup.php(73): Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup->getLatestRevisionId(Wikibase\Lexeme\Domain\Model\LexemeId, string)
#5 /srv/mediawiki/php-1.34.0-wmf.5/extensions/WikibaseLexeme/src/DataAccess/Store/FormRevisionLookup.php(89): Wikibase\Lib\Store\DispatchingEntityRevisionLookup->getLatestRevisionId(Wikibase\Lexeme\Domain\Model\LexemeId, string)
#6 /srv/mediawiki/php-1.34.0-wmf.5/extensions/Wikibase/lib/includes/Store/TypeDispatchingEntityRevisionLookup.php(70): Wikibase\Lexeme\DataAccess\Store\FormRevisionLookup->getLatestRevisionId(Wikibase\Lexeme\Domain\Model\FormId, string)
#7 /srv/mediawiki/php-1.34.0-wmf.5/extensions/Wikibase/lib/includes/Store/CacheRetrievingEntityRevisionLookup.php(108): Wikibase\Lib\Store\TypeDispatchingEntityRevisionLookup->getLatestRevisionId(Wikibase\Lexeme\Domain\Model\FormId, string)
#8 /srv/mediawiki/php-1.34.0-wmf.5/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php(84): Wikibase\Lib\Store\CacheRetrievingEntityRevisionLookup->getEntityRevisionFromCache(Wikibase\Lexeme\Domain\Model\FormId, integer, string)
#9 /srv/mediawiki/php-1.34.0-wmf.5/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php(104): Wikibase\Lib\Store\CachingEntityRevisionLookup->getEntityRevision(Wikibase\Lexeme\Domain\Model\FormId, integer, string)
#10 /srv/mediawiki/php-1.34.0-wmf.5/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php(87): Wikibase\Lib\Store\CachingEntityRevisionLookup->fetchEntityRevision(Wikibase\Lexeme\Domain\Model\FormId, integer, string)
#11 /srv/mediawiki/php-1.34.0-wmf.5/extensions/Wikibase/repo/includes/Api/GetEntities.php(275): Wikibase\Lib\Store\CachingEntityRevisionLookup->getEntityRevision(Wikibase\Lexeme\Domain\Model\FormId)
#12 /srv/mediawiki/php-1.34.0-wmf.5/extensions/Wikibase/repo/includes/Api/GetEntities.php(257): Wikibase\Repo\Api\GetEntities->getEntityRevision(Wikibase\Lexeme\Domain\Model\FormId, boolean)
#13 /srv/mediawiki/php-1.34.0-wmf.5/extensions/Wikibase/repo/includes/Api/GetEntities.php(136): Wikibase\Repo\Api\GetEntities->getEntityRevisionsFromEntityIds(array, boolean)

Logstash: https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2019.05.21/mediawiki?id=AWraLzUKm4XPTDeI3npb&_g=()

Expected behaviour: data of the requested form or sense should be returned.

Details

SubjectRepoBranchLines +/-
Do not die when Wikibase prefetches Sense or Form Idmediawiki/extensions/WikibaseLexememaster+83 -24
Add test for wbgetentities with subentitiesmediawiki/extensions/WikibaseLexememaster+32 -4
Add test for wbgetentities with subentitiesmediawiki/extensions/WikibaseLexememaster+35 -4
Customize query in gerrit

Related Objects

Event Timeline

Michael created this task.May 21 2019, 12:18 PM
Michael moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
hoo renamed this task from BadMethodCallException wbgetentities when getting label + description for Lexeme Form to BadMethodCallException wbgetentities when getting Lexeme Form.May 21 2019, 1:01 PM
hoo subscribed.

Also results in error: https://www.wikidata.org/w/api.php?action=wbgetentities&format=json&origin=*&ids=L11533-F7&languages=de&languagefallback=1

hoo renamed this task from BadMethodCallException wbgetentities when getting Lexeme Form to BadMethodCallException wbgetentities when getting Lexemes.May 21 2019, 1:03 PM
hoo renamed this task from BadMethodCallException wbgetentities when getting Lexemes to BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses).
WMDE-leszek triaged this task as High priority.May 21 2019, 1:05 PM
WMDE-leszek updated the task description. (Show Details)
WMDE-leszek updated the task description. (Show Details)
WMDE-leszek set the point value for this task to 5.
hoo added a comment.May 21 2019, 1:08 PM

This used to work, see T196297 (but we didn't write tests back then :S )

Ladsgroup moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.May 21 2019, 2:24 PM
Ladsgroup edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Ladsgroup claimed this task.May 22 2019, 1:31 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMay 22 2019, 1:31 PM
WMDE-leszek mentioned this in T224211: Not Implemented: WikibaseLexeme/src/DataAccess/Store/MediaWikiPageSubEntityMetaDataAccessor.php:42.May 23 2019, 9:14 AM
hashar merged a task: T224211: Not Implemented: WikibaseLexeme/src/DataAccess/Store/MediaWikiPageSubEntityMetaDataAccessor.php:42.May 23 2019, 9:17 AM
hashar moved this task from Untriaged to May 2019 / 1.34.wmf.5+ on the Wikimedia-production-error board.
hashar added subscribers: hashar, WMDE-leszek.
hoo mentioned this in T200906: Special:EntityPage for form ID or sense ID results in InvalidArgumentException.May 29 2019, 3:53 PM
Ladsgroup removed Ladsgroup as the assignee of this task.Jun 5 2019, 9:58 AM
Ladsgroup moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Ladsgroup subscribed.

Unlicking the cookie

Krinkle mentioned this in T225104: Various Wikibase APIs can fatal with "Call to hasSlot() on null" (from WikiPageEntityRevisionLookup.php).Jun 5 2019, 2:58 PM
Ladsgroup added a comment.Jun 5 2019, 4:15 PM

Unbelievably, it works in beta cluster but not in production and my localhost: https://wikidata.beta.wmflabs.org/w/api.php?action=wbgetentities&ids=L53-S1

Ladsgroup claimed this task.Jun 5 2019, 4:16 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Oops!... I licked It Again

Ladsgroup added a comment.Jun 5 2019, 4:28 PM

It fails on test wikidata https://www.wikidata.org/w/api.php?action=wbgetentities&format=json&origin=*&ids=L1-S1

Ladsgroup merged a task: T225120: wbgetentities calls fail for Forms/Senses.Jun 5 2019, 4:49 PM
Ladsgroup added a subscriber: matej_suchanek.
Ladsgroup added a comment.Jun 5 2019, 5:00 PM

Beta cluster lexeme-related configs:

wgLexemePrefixRescoreProfile:"lexeme_prefix"
wgLexemeEnableRepo:true
wgLexemeNamespace:146
wgLexemePrefixSearchProfiles:[]
wgWBQualityConstraintsWikibaseSenseId:"Q505135"
wgLexemeRescoreFunctions:[]
wmgUseWikibaseLexemeCirrusSearch:true
wgLexemeEnableSenses:true
wgLexemeLanguageCodePropertyId:"P218"
wmgUseWikibaseLexeme:true
wgLexemeDisableCirrus:true
wgLexemeUseCirrus:true
wgLexemeTalkNamespace:147
wmgNewWikibaseLexemeCirrusSearch:true
wgLexemeFulltextRescoreProfile:"lexeme_fulltext"
wgLexemePrefixSearchProfile:"lexeme_prefix"
wgWBQualityConstraintsWikibaseLexemeId:"Q505133"

Production:

wgLexemePrefixRescoreProfile:"lexeme_prefix"
wgLexemeEnableRepo:true
wgLexemeNamespace:146
wgLexemePrefixSearchProfiles:[]
wgWBQualityConstraintsWikibaseSenseId:"Q54285715"
wgLexemeRescoreFunctions:[]
wmgUseWikibaseLexemeCirrusSearch:true
wgLexemeEnableSenses:true
wgLexemeLanguageCodePropertyId:"P218"
wmgUseWikibaseLexeme:true
wgLexemeDisableCirrus:true
wgLexemeUseCirrus:true
wgLexemeTalkNamespace:147
wmgNewWikibaseLexemeCirrusSearch:true
wgLexemeFulltextRescoreProfile:"lexeme_fulltext"
wgLexemePrefixSearchProfile:"lexeme_prefix"
wgWBQualityConstraintsWikibaseLexemeId:"Q51885771"

(I'm fascinated that we have "wgLexemeUseCirrus" and "wgLexemeDisableCirrus" both set to true in production and beta cluster)

Ladsgroup added a comment.Jun 5 2019, 5:20 PM

This is all of wikibase-related configs that differ between production and beta clsuter:

1 wgWBQualityConstraintsWikibaseFormId:"Q505134"
1 wgWBQualityConstraintsWikibaseFormId:"Q54285143"
1 wgWBQualityConstraintsWikibaseItemId:"Q29934200"
1 wgWBQualityConstraintsWikibaseItemId:"Q505131"
1 wgWBQualityConstraintsWikibaseLexemeId:"Q505133"
1 wgWBQualityConstraintsWikibaseLexemeId:"Q51885771"
1 wgWBQualityConstraintsWikibasePropertyId:"Q29934218"
1 wgWBQualityConstraintsWikibasePropertyId:"Q505132"
1 wgWBQualityConstraintsWikibaseSenseId:"Q505135"
1 wgWBQualityConstraintsWikibaseSenseId:"Q54285715"
1 wgWikibaseMultiRepositoryServiceWiringFiles:["\/srv\/mediawiki\/php-1.34.0-wmf.8\/extensions\/Wikibase\/client\/..\/data-access\/src\/MultiRepositoryServiceWiring.php"]
1 wgWikibaseMultiRepositoryServiceWiringFiles:["\/srv\/mediawiki-staging\/php-master\/extensions\/Wikibase\/client\/..\/data-access\/src\/MultiRepositoryServiceWiring.php"]
1 wgWikibasePerRepositoryServiceWiringFiles:["\/srv\/mediawiki\/php-1.34.0-wmf.8\/extensions\/Wikibase\/client\/..\/data-access\/src\/PerRepositoryServiceWiring.php"]
1 wgWikibasePerRepositoryServiceWiringFiles:["\/srv\/mediawiki-staging\/php-master\/extensions\/Wikibase\/client\/..\/data-access\/src\/PerRepositoryServiceWiring.php"]
1 wmgWikibaseClientBadgeClassNames:{"Q17437796":"badge-featuredarticle","Q17437798":"badge-goodarticle","Q17559452":"badge-recommendedarticle","Q17506997":"badge-featuredlist","Q17580674":"badge-featuredportal","Q20748091":"badge-notproofread","Q20748094":"badge-problematic","Q20748092":"badge-proofread","Q20748093":"badge-validated","Q28064618":"badge-digitaldocument","Q51759403":"badge-goodlist"}
1 wmgWikibaseClientBadgeClassNames:{"Q49444":"badge-goodarticle","Q49447":"badge-featuredarticle","Q49448":"badge-recommendedarticle","Q49449":"badge-featuredlist","Q49450":"badge-featuredportal","Q98649":"badge-notproofread","Q98650":"badge-problematic","Q98658":"badge-proofread","Q98651":"badge-validated"}
1 wmgWikibaseClientEchoIcon:{"path":"\/static\/images\/wikibase\/echoIcon.svg"}
1 wmgWikibaseClientEchoIcon:{"url":"\/static\/images\/wikibase\/echoIcon.svg"}
1 wmgWikibaseClientPropertyOrderUrl:"https:\/\/www.wikidata.org\/w\/index.php?title=MediaWiki:Wikibase-SortedProperties&action=raw&sp_ver=1"
1 wmgWikibaseClientRepoConceptBaseUri:"http:\/\/www.wikidata.beta.wmflabs.org\/entity\/"
1 wmgWikibaseClientRepoConceptBaseUri:"http:\/\/www.wikidata.org\/entity\/"
1 wmgWikibaseClientRepositories:{"":{"repoDatabase":"wikidatawiki","baseUri":"http:\/\/www.wikidata.org\/entity\/","entityNamespaces":{"item":0,"property":120,"lexeme":146},"prefixMapping":{"":""}}}
1 wmgWikibaseClientRepositories:{"":{"repoDatabase":"wikidatawiki","entityNamespaces":{"item":0,"property":120,"lexeme":146},"baseUri":"https:\/\/wikidata.beta.wmflabs.org\/entity\/","prefixMapping":{"":""}},"commons":{"repoDatabase":"commonswiki","entityNamespaces":{"mediainfo":"6\/mediainfo"},"baseUri":"https:\/\/commons.wikimedia.beta.wmflabs.org\/entity\/","prefixMapping":[]}}
1 wmgWikibaseClientRepoUrl:"https:\/\/wikidata.beta.wmflabs.org"
1 wmgWikibaseClientRepoUrl:"https:\/\/www.wikidata.org"
1 wmgWikibaseClientUseTermsTableSearchFields:false
1 wmgWikibaseClientUseTermsTableSearchFields:true
1 wmgWikibaseFeatureFlagWbeditentitySetEmptyAliases:false
1 wmgWikibaseFeatureFlagWbeditentitySetEmptyAliases:true
1 wmgWikibaseRepoBadgeItems:{"Q17437798":"wb-badge-goodarticle","Q17437796":"wb-badge-featuredarticle","Q17559452":"wb-badge-recommendedarticle","Q17506997":"wb-badge-featuredlist","Q17580674":"wb-badge-featuredportal","Q20748091":"wb-badge-notproofread","Q20748094":"wb-badge-problematic","Q20748092":"wb-badge-proofread","Q20748093":"wb-badge-validated","Q28064618":"wb-badge-digitaldocument","Q51759403":"wb-badge-goodlist"}
1 wmgWikibaseRepoBadgeItems:{"Q49444":"wb-badge-goodarticle","Q49447":"wb-badge-featuredarticle","Q49448":"wb-badge-recommendedarticle","Q49449":"wb-badge-featuredlist","Q49450":"wb-badge-featuredportal","Q98649":"wb-badge-notproofread","Q98650":"wb-badge-problematic","Q98658":"wb-badge-proofread","Q98651":"wb-badge-validated"}
1 wmgWikibaseSearchIndexProperties:[]
1 wmgWikibaseSearchIndexPropertiesExclude:[]
1 wmgWikibaseSearchIndexPropertiesExclude:["P304","P433","P478","P558","P3903","P3921","P4316","P1433","P2860"]
1 wmgWikibaseSearchIndexProperties:["P31","P279"]
1 wmgWikibaseSearchStatementBoosts:[]
1 wmgWikibaseSearchStatementBoosts:{"P31=Q4167410":-10,"P31=Q13442814":-5,"P31=Q18918145":-5}
1 wmgWikibaseSSRTermboxServerUrl:"https:\/\/ssr-termbox.wmflabs.org\/termbox"
1 wmgWikibaseUseSSRTermbox:true

The only thing that might be at fault is that if we enable federation, it would fix it (very very unlikely). The next step is to compare mediawiki core and similar paths. Will dig deeper tomorrow.

Ladsgroup added a comment.Jun 6 2019, 10:31 AM

If you set $wgWBRepoSettings['useEntitySourceBasedFederation'] = true; in localhost, it works just fine:

{
    "entities": {
        "L16-F1": {
            "pageid": 513,
            "ns": 146,
            "title": "Lexeme:L16",
            "lastrevid": 515,
            "modified": "2019-05-22T15:06:48Z",
            "id": "L16-F1",
            "representations": {
                "en": {
                    "language": "en",
                    "value": "ff"
                }
            },
            "grammaticalFeatures": [],
            "claims": {}
        }
    },
    "success": 1
}
WMDE-leszek added a comment.Jun 6 2019, 10:38 AM

How about adding a regression (failing) test as a first step? As apparently there has been no tests for this behaviour, no wonder it was (well, I did) broken when changes to federation have been made.

gerritbot added a comment.Jun 6 2019, 8:28 PM

Change 514883 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Add test for wbgetentities with subentities

https://gerrit.wikimedia.org/r/514883

gerritbot added a project: Patch-For-Review.Jun 6 2019, 8:28 PM
Ladsgroup added a comment.Jun 6 2019, 8:39 PM

So this is the backtrace when you set $wgWBRepoSettings['useEntitySourceBasedFederation'] = true;:

/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityMetaDataLookup.php:106
/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/Sql/TypeDispatchingWikiPageEntityMetaDataAccessor.php:88
/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/Sql/PrefetchingWikiPageEntityMetaDataAccessor.php:264
/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/Sql/PrefetchingWikiPageEntityMetaDataAccessor.php:186
/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php:125
/var/lib/mediawiki2/extensions/Wikibase/data-access/src/ByTypeDispatchingEntityRevisionLookup.php:54
/var/lib/mediawiki2/extensions/WikibaseLexeme/src/DataAccess/Store/SenseRevisionLookup.php:55
/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/TypeDispatchingEntityRevisionLookup.php:54
/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php:104
/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php:87
/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php:104
/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php:87
/var/lib/mediawiki2/extensions/Wikibase/repo/includes/Api/GetEntities.php:275
/var/lib/mediawiki2/extensions/Wikibase/repo/includes/Api/GetEntities.php:257
/var/lib/mediawiki2/extensions/Wikibase/repo/includes/Api/GetEntities.php:136
/var/lib/mediawiki2/includes/api/ApiMain.php:1595
/var/lib/mediawiki2/includes/api/ApiMain.php:500
/var/lib/mediawiki2/tests/phpunit/includes/api/ApiTestCase.php:106
/var/lib/mediawiki2/extensions/Wikibase/repo/tests/phpunit/includes/Api/WikibaseApiTestCase.php:156
/var/lib/mediawiki2/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Api/LexemeGetEntitiesTest.php:105
/var/lib/mediawiki2/tests/phpunit/MediaWikiTestCase.php:427
/var/lib/mediawiki2/maintenance/doMaintenance.php:99

This is a big red herring and waste of time, I looked at everything in depth and nothing was responsible. The part that is actually responsible is EntityPrefetcher. GetEntities do prefetch and when you disable EntitySourceBasedFederation, The EntityPrefetcher is actually a federated one which is DispatchingEntityPrefetcher but that doesn't distinguish between different prefetchers of entity types that exist in one federated repo. It's repo-based EntityPrefetcher. while if you set useEntitySourceBasedFederation, it uses MultipleEntitySourceServices to get the EntityPrefetcher (I still don't know how, otherwise I would have made the patch for it already) which that returns ByTypeDispatchingEntityPrefetcher which ignores entity types that don't have EntityPrefetcher defined so it lets the system flow naturally. I need to consolidate and find a better solution than DispatchingEntityPrefetcher but @WMDE-leszek knows way better than I do. Please take a look.

Marsupium subscribed.Jun 7 2019, 2:50 AM
Ladsgroup added a comment.Jun 19 2019, 2:15 PM

So it seems all of the buggy code will go away soon (TM) according to @WMDE-leszek so I recommend just setting $wgWBRepoSettings['useEntitySourceBasedFederation'] = true; for both commons and wikidata.

Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 19 2019, 2:15 PM
• alaa_wmde subscribed.Jun 19 2019, 9:50 PM

Cannot see why the patch is failing, because in zuul's comment on the patch, the link to the failing job gives 404 https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/52351/console (this happened before to me, is there a pattern/rule/reason for that?)

Ladsgroup added a comment.Jun 19 2019, 9:53 PM
In T223995#5269752, @alaa_wmde wrote:

Cannot see why the patch is failing, because in zuul's comment on the patch, the link to the failing job gives 404 https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/52351/console (this happened before to me, is there a pattern/rule/reason for that?)

It means it's too old and jenkins evicted the results page. Do a recheck.

• alaa_wmde added a comment.Jun 19 2019, 9:54 PM

Cool good to know thank you @Ladsgroup

Ladsgroup moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 20 2019, 9:56 AM
gerritbot added a comment.Jun 20 2019, 5:43 PM

Change 518090 had a related patch set uploaded (by WMDE-leszek; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Add test for wbgetentities with subentities

https://gerrit.wikimedia.org/r/518090

gerritbot added a comment.Jun 20 2019, 5:43 PM

Change 518091 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] Do not die when Wikibase prefetches Sense or Form Id

https://gerrit.wikimedia.org/r/518091

Addshore moved this task from incoming to in progress on the Wikidata board.Jun 21 2019, 11:25 PM
Krinkle mentioned this in Blog Post: Production Excellence #11: May 2019.Jul 1 2019, 6:48 PM
Ladsgroup removed Ladsgroup as the assignee of this task.Jul 8 2019, 11:56 AM
Ladsgroup moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
• alaa_wmde moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 22 2019, 8:47 AM

This has two patches that haven't been merged .. should be in peer review

gerritbot added a comment.Jul 22 2019, 12:50 PM

Change 518090 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add test for wbgetentities with subentities

https://gerrit.wikimedia.org/r/518090

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.15; 2019-07-23).Jul 22 2019, 1:00 PM
• alaa_wmde updated the task description. (Show Details)Jul 23 2019, 9:08 AM
• alaa_wmde moved this task from Peer Review to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

one to do left

• alaa_wmde claimed this task.Jul 26 2019, 6:00 PM
• alaa_wmde moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Jul 26 2019, 8:54 PM

Change 514883 abandoned by Alaa Sarhan:
Add test for wbgetentities with subentities

Reason:
done in 518090

https://gerrit.wikimedia.org/r/514883

• alaa_wmde added a comment.Jul 26 2019, 10:13 PM

Added tests to the patch.. @WMDE-leszek I have one question before I'm confident I did the tests right https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/518091/6/tests/phpunit/mediawiki/Store/MediaWikiPageSubEntityMetaDataAccessorTest.php#69

• alaa_wmde moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 26 2019, 10:14 PM
• alaa_wmde moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 29 2019, 10:07 AM
• alaa_wmde updated the task description. (Show Details)Jul 29 2019, 11:24 AM
• alaa_wmde moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
hoo moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 30 2019, 4:38 PM
gerritbot added a comment.Jul 31 2019, 9:25 AM

Change 518091 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Do not die when Wikibase prefetches Sense or Form Id

https://gerrit.wikimedia.org/r/518091

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.17; 2019-08-06); removed MW-1.34-notes (1.34.0-wmf.15; 2019-07-23).Jul 31 2019, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 31 2019, 10:10 AM
• alaa_wmde closed this task as Resolved.Aug 12 2019, 2:46 PM
• alaa_wmde moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
matej_suchanek unsubscribed.Aug 18 2019, 1:37 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL