Maniphest T225011

Clean up code related to blocking
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Tchanders
	Jun 4 2019, 5:55 PM

Tags

Referenced Files

None

Subscribers

Description

Recent work to implement partial blocks (T2674) has uncovered lots of places where block-related code needs cleaning up. This task tracks that work.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T225011 Clean up code related to blocking
		Open		None	T221066 Move methods from Block to BlockManager
		Open		None	T221067 Move block-related methods on User to the BlockManager
		Resolved		Tchanders	T229035 Deprecate 'GetBlockedStatus' hook and reduce visibility of User::mBlock, User::mBlockedBy and User::mHideName
		Resolved		Tchanders	T229692 Use GetUserBlockComplete hook instead of GetBlockedStatus in TorBlock extension
		Resolved		Tchanders	T228948 PermissionManager::isBlockedFrom() can return true even if the user does not have a block
		Resolved		DannyS712	T221075 Introduce a BlockStore service
		Open		None	T225016 Make block objects immutable
		Resolved		Tchanders	T219441 Introduce a BlockManager service for getting and combining the blocks that apply to a user/IP
		Resolved		Tchanders	T222737 Refactor Block to AbstractBlock, DatabaseBlock and SystemBlock
		Resolved		Tchanders	T225141 Move cookie-related logic from User and Block to BlockManager
		Open		None	T225250 Store block options as flags
		Resolved		dmaza	T227005 Don't require that the blocker be a User for a SystemBlock
		Resolved		Tchanders	T236814 Improve blocker information on mobile block error message drawer
		Resolved		• tstarling	T255433 Introduce a DatabaseBlock factory service

Event Timeline

Tchanders created this task.Jun 4 2019, 5:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 4 2019, 5:55 PM

Tchanders added subtasks: T221066: Move methods from Block to BlockManager, T221067: Move block-related methods on User to the BlockManager, T221075: Introduce a BlockStore service.Jun 4 2019, 5:58 PM

Tchanders added subtasks: T219441: Introduce a BlockManager service for getting and combining the blocks that apply to a user/IP, T222737: Refactor Block to AbstractBlock, DatabaseBlock and SystemBlock.Jun 4 2019, 7:34 PM

Tchanders moved this task from Backlog to User blocking on the MediaWiki-User-management board.Jun 5 2019, 7:18 PM

• Niharika closed subtask T222737: Refactor Block to AbstractBlock, DatabaseBlock and SystemBlock as Resolved.Jun 5 2019, 10:15 PM

Agabi10 subscribed.Jun 5 2019, 11:36 PM

dbarratt closed subtask T225141: Move cookie-related logic from User and Block to BlockManager as Resolved.Jun 18 2019, 4:11 PM

dbarratt closed subtask T227005: Don't require that the blocker be a User for a SystemBlock as Resolved.Nov 4 2019, 10:51 PM

daniel added a project: Platform Team Initiatives (Decoupling (CDP2)).Mar 27 2020, 10:12 AM

DannyS712 edited projects, added MediaWiki-Blocks; removed MediaWiki-User-management.Apr 25 2020, 12:10 AM

Restricted Application added a project: MediaWiki-User-management. · View Herald TranscriptApr 25 2020, 12:10 AM

Aklapper removed a project: MediaWiki-User-management.Apr 25 2020, 12:23 PM

• Niharika closed subtask T221075: Introduce a BlockStore service as Resolved.Jul 31 2020, 6:13 PM

Zabe subscribed.Jul 5 2022, 10:51 PM

• tstarling closed subtask T255433: Introduce a DatabaseBlock factory service as Resolved.Nov 27 2023, 9:15 AM