Tagging recreations of deleted pages would be a useful filter as patrollers have no easy way of noticing when that happens, but currently AbuseFilter does not support that. It would be nice if it had e.g. a variable for the number of deleted revisions.
Description
Description
Details
Details
- Reference
- bz20892
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T22892 Add ability to detect deleted revisions and page creation | |||
| Open | None | T68961 Logging needs an index to optimize searching by log_title |
Event Timeline
Comment Actions
I think the best way to implement this would be variables containing the number of live and deleted revisions.
Comment Actions
I think the "number" of deleted revisions is not something that should be exposed publicly (only sysops can see them outside the AbuseFilter, so only sysops can also see their count in the AbuseFilter's context). On the otherhand, the fact that the page was deleted (which is publicly available in logs) is something that can be also useful for AbuseFilter purposes. Hence my recommendation for a "has_been_deleted" variable in bug 66031.
Comment Actions
Change 139103 had a related patch set uploaded by Huji:
AbuseFilter: Add ability to detect deleted revisions
Comment Actions
Change 139105 had a related patch set uploaded by Huji:
AbuseFilter: Add ability to detect deleted revisions
Comment Actions
Change 139105 abandoned by Huji:
AbuseFilter: Add ability to detect deleted revisions
Reason:
Merged back into I4ec2c6aa1fc8aba1e6eb0563fec9ab05bb738d40
Comment Actions
I marked 139105 is abandoned because I finally figured out how to merge it back into https://gerrit.wikimedia.org/r/139103 (please check new patchset there)
Comment Actions
Gerrit change 139103 has CR -2 now because there's no index to quickly get the number of times it has been deleted.
I was going to propose a variable with the number of deleted revisions, but I'm a bit shocked because the archive table has index for ar_namespace but not for ar_title (!!!) [1], so it will have the same problem. But because of that, does it mean that the message that appears on top of pages that have deleted revisions is using a slow query to get the number of deleted revisions, because there's no index for that? I guess there should be an index for this one (namespace and title).
Comment Actions
I believe the lack of index is a separate bug. Since we already have a functionality in MediaWiki itself that is using a non-indexed column to show a message to the user when trying to recreate a previously deleted page, one might say that having a similar functionality in AbuseFilter should not be prohibited just based on the lack of index. Regardless, I've created bug 66961 as a blocker, and will wait for that to be fixed before my patch for 20892 is implemented.
In the meantime, I would be grateful if one could review the latest patch to see if there are any *other* problems with it.
Comment Actions
https://gerrit.wikimedia.org/r/#/c/139103/ got a -2, and since there doesn't seem to be more progress in this task.
@Huji, this is one of the oldest tasks assigned to someone. Are you planning to work on it, and is its current priority correct?
Comment Actions
Change 139103 had a related patch set uploaded (by Huji):
AbuseFilter: Add ability to detect deleted revisions
Comment Actions
Change 530949 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/AbuseFilter@master] Add ability to detect deleted revisions
Comment Actions
I'm really not doing anything new in my patch, but I wrote it on my computer before learning this task exists, so I uploaded it so it's not lost. @Huji, any progress?
Comment Actions
Removing task assignee due to inactivity, as this open task has been assigned to the same person for more than two years (see the emails sent to the task assignee on Oct27 and Nov23). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.
(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)
Comment Actions
It seems the only realistic immediate solution is to abandon the problematic logging query (that counts rows and is not fully indexed) and instead make a boolean query to archive using ArchivedRevisionLookup::hasArchivedRevisions. I left some comments on https://gerrit.wikimedia.org/r/c/530949 that can be used for guidance (or rebased).
Comment Actions
Change 530949 abandoned by Urbanecm:
[mediawiki/extensions/AbuseFilter@master] Add ability to detect deleted revisions
Reason: