Page MenuHomePhabricator
Create Task
Maniphest T229443

Unable to view some pages on Incubator (Postcondition failed in Title::getBaseTitle makeTitleSafe via GeoCrumbsHooks)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request ID: XUG40gpAMFQAAKDkvqIAAABW
Request URL: https://incubator.wikimedia.org/wiki//incubator.m.wikimedia.org

message
/wiki//incubator.m.wikimedia.org   Wikimedia\Assert\PostconditionException from line 140 of /srv/mediawiki/php-1.34.0-wmf.15/vendor/wikimedia/assert/src/Assert.php: Postcondition failed: makeTitleSafe() should always return a Title for the text returned by getBaseText().
trace
#0 /srv/mediawiki/php-1.34.0-wmf.15/includes/Title.php(1852): Wikimedia\Assert\Assert::postcondition(boolean, string)
#1 /srv/mediawiki/php-1.34.0-wmf.15/extensions/GeoCrumbs/includes/GeoCrumbsHooks.php(65): Title->getBaseTitle()
#2 /srv/mediawiki/php-1.34.0-wmf.15/extensions/GeoCrumbs/includes/GeoCrumbsHooks.php(45): GeoCrumbsHooks::completeImplicitIsIn(ParserOutput, Title)
#3 /srv/mediawiki/php-1.34.0-wmf.15/includes/Hooks.php(174): GeoCrumbsHooks::onParserBeforeTidy(Parser, string)
#4 /srv/mediawiki/php-1.34.0-wmf.15/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#5 /srv/mediawiki/php-1.34.0-wmf.15/includes/parser/Parser.php(1509): Hooks::run(string, array)
#6 /srv/mediawiki/php-1.34.0-wmf.15/includes/parser/Parser.php(558): Parser->internalParseHalfParsed(string, boolean, boolean)
#7 /srv/mediawiki/php-1.34.0-wmf.15/includes/cache/MessageCache.php(1260): Parser->parse(string, Title, ParserOptions, boolean)
#8 /srv/mediawiki/php-1.34.0-wmf.15/includes/language/Message.php(1265): MessageCache->parse(string, Title, boolean, boolean, LanguageEn)
#9 /srv/mediawiki/php-1.34.0-wmf.15/includes/language/Message.php(895): Message->parseText(string)
#10 /srv/mediawiki/php-1.34.0-wmf.15/includes/language/Message.php(981): Message->toString(string)
#11 /srv/mediawiki/php-1.34.0-wmf.15/includes/OutputPage.php(3960): Message->parseAsBlock()
#12 /srv/mediawiki/php-1.34.0-wmf.15/includes/OutputPage.php(3948): OutputPage->addWikiMsgArray(string, array)
#13 /srv/mediawiki/php-1.34.0-wmf.15/extensions/WikimediaIncubator/includes/WikimediaIncubator.php(624): OutputPage->addWikiMsg(string)
#14 /srv/mediawiki/php-1.34.0-wmf.15/includes/Hooks.php(174): WikimediaIncubator::onShowMissingArticle(Article)
#15 /srv/mediawiki/php-1.34.0-wmf.15/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#16 /srv/mediawiki/php-1.34.0-wmf.15/includes/page/Article.php(1400): Hooks::run(string, array)
#17 /srv/mediawiki/php-1.34.0-wmf.15/includes/page/Article.php(684): Article->showMissingArticle()
#18 /srv/mediawiki/php-1.34.0-wmf.15/includes/actions/ViewAction.php(63): Article->view()
#19 /srv/mediawiki/php-1.34.0-wmf.15/includes/MediaWiki.php(507): ViewAction->show()
#20 /srv/mediawiki/php-1.34.0-wmf.15/includes/MediaWiki.php(302): MediaWiki->performAction(Article, Title)
#21 /srv/mediawiki/php-1.34.0-wmf.15/includes/MediaWiki.php(892): MediaWiki->performRequest()
#22 /srv/mediawiki/php-1.34.0-wmf.15/includes/MediaWiki.php(523): MediaWiki->main()
#23 /srv/mediawiki/php-1.34.0-wmf.15/index.php(42): MediaWiki->run()
#24 /srv/mediawiki/w/index.php(3): include(string)
#25 {main}
Notes

Shows up in logstash ~29 times starting on 2019-07-24.

Still cropping up occasionally as of 1.35.0-wmf.23.

Details

SubjectRepoBranchLines +/-
title: Fix bogus Title::getSkinFromConfigSubpage()mediawiki/coremaster+35 -6
title: Fix Title::findSubpageDivider() destroying certain stringsmediawiki/coremaster+11 -28
Title: fix subpage split for degenerate casesmediawiki/coremaster+103 -21
Customize query in gerrit

Related Objects

Event Timeline

brennen created this task.Jul 31 2019, 4:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2019, 4:20 PM
brennen moved this task from Untriaged to Jul2019/1.34.wmf.13+ on the Wikimedia-production-error board.Jul 31 2019, 4:21 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:05 PM
Krinkle renamed this task from Postcondition failed: makeTitleSafe() should always return a Title for the text returned by getBaseText(). to Fatal error when viewing some Incubator pages (Postcondition failed in Title::getBaseTitle via GeoCrumbsHooks).Oct 12 2019, 11:52 PM
Krinkle added projects: Platform Engineering, Platform Team Workboards (Clinic Duty Team).
Krinkle subscribed.Oct 12 2019, 11:55 PM

Caused by:

See also:

Krinkle renamed this task from Fatal error when viewing some Incubator pages (Postcondition failed in Title::getBaseTitle via GeoCrumbsHooks) to Unable to view some pages on Incubator (Postcondition failed in Title::getBaseTitle via GeoCrumbsHooks).Oct 12 2019, 11:55 PM
Krinkle added a project: MediaWiki-extensions-WikimediaIncubator.
Anomie moved this task from Inbox to Triage Meeting Inbox on the Platform Engineering board.Oct 15 2019, 3:12 PM
daniel removed a project: Platform Engineering.Oct 15 2019, 8:10 PM
daniel triaged this task as Medium priority.Nov 11 2019, 8:09 PM
brennen added a project: User-brennen.Mar 12 2020, 5:34 PM
brennen updated the task description. (Show Details)
brennen moved this task from Backlog to Logs/Train on the User-brennen board.
daniel moved this task from Inbox to Ready (WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.Apr 7 2020, 8:49 PM
Anomie assigned this task to daniel.Apr 8 2020, 5:22 PM
• Pchelolo moved this task from Ready (WIP:5) to Later on the Platform Team Workboards (Clinic Duty Team) board.Apr 15 2020, 4:24 PM
thcipriani subscribed.Jun 11 2020, 8:22 PM

This seems to happen on de wikivoyage as well as of today: https://de.wikivoyage.org/wiki//portugal

thcipriani renamed this task from Unable to view some pages on Incubator (Postcondition failed in Title::getBaseTitle via GeoCrumbsHooks) to Unable to view some pages on Incubator (Postcondition failed in Title::getBaseTitle makeTitleSafe via GeoCrumbsHooks).Jun 11 2020, 8:23 PM
daniel added a comment.Jun 12 2020, 10:25 AM

This is cased by getBaseTitle() when the title starts with a "/", e.g. https://de.wikivoyage.org/wiki//portugal (https://de.wikivoyage.org/wiki/portugal works fine).

Basically, asking for a page with a leading "/" in the title in a namespace that has subpages enabled will trigger this.

This raises some questions about the intended behavior for degenerate cases like /// or //foo//bar//baz//.

gerritbot added a comment.Jun 12 2020, 10:25 AM

Change 605185 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Title: fix subpage split for degenerate cases

https://gerrit.wikimedia.org/r/605185

gerritbot added a project: Patch-For-Review.Jun 12 2020, 10:25 AM
daniel moved this task from Later to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Jun 12 2020, 10:25 AM
gerritbot added a comment.Jun 25 2020, 4:46 PM

Change 605185 merged by jenkins-bot:
[mediawiki/core@master] Title: fix subpage split for degenerate cases

https://gerrit.wikimedia.org/r/605185

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jun 25 2020, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 25 2020, 5:10 PM
Soda mentioned this in T256763: WikitextLinksExtractor fails tests in ProofreadPage.Jun 30 2020, 3:02 PM
Soda subscribed.EditedJul 1 2020, 7:58 PM

{{SUBPAGENAME}} no longer returns the Pagename when no subpages are detected. The getSubpageText() function which is used internally to get the output of {{SUBPAGENAME}} returns an empty string instead of the Pagename after this patch has been deployed.

Daimona mentioned this in T256922: {{SUBPAGENAME}} no longer returning the title for pages without subpages.Jul 1 2020, 9:56 PM
Aklapper added a comment.Jul 3 2020, 11:00 AM
In T229443#6272892, @Soda wrote:

{{SUBPAGENAME}} no longer returns the Pagename when no subpages are detected.

See T256922 instead for that.

daniel closed this task as Resolved.Jul 15 2020, 4:26 PM

fixed as far as I can tell.

gerritbot added a comment.Jul 27 2020, 1:13 PM

Change 499164 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/core@master] title: Fix bogus Title::getSkinFromConfigSubpage()

https://gerrit.wikimedia.org/r/499164

gerritbot added a project: Patch-For-Review.Jul 27 2020, 1:13 PM
gerritbot added a comment.Jul 28 2020, 10:50 AM

Change 616725 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/core@master] title: Fix Title::findSubpageDivider() destroying certain strings

https://gerrit.wikimedia.org/r/616725

gerritbot added a comment.Mar 31 2021, 7:49 AM

Change 616725 merged by jenkins-bot:

[mediawiki/core@master] title: Fix Title::findSubpageDivider() destroying certain strings

https://gerrit.wikimedia.org/r/616725

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.38; 2021-04-06).Mar 31 2021, 8:00 AM
gerritbot added a comment.Apr 1 2021, 6:34 PM

Change 499164 merged by jenkins-bot:

[mediawiki/core@master] title: Fix bogus Title::getSkinFromConfigSubpage()

https://gerrit.wikimedia.org/r/499164

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL