Page MenuHomePhabricator

Homepage: vertical alignment issues in mobile Impact module preview
Closed, ResolvedPublicBUG REPORT


In the context of the mobile Newcomer homepage, the text of the Impact module previews presents vertical alignment issues.
According to mockup's specifications, subheader text's line-height should be 1.3em and margin-top should be .8em.

Actual Results:

Screenshot 2019-08-06 18.20.50.png (378×746 px, 46 KB)

Expected Results:

Screenshot 2019-08-12 19.32.29.png (378×752 px, 46 KB)

.growthexperiments-homepage-module-text-normal.growthexperiments-homepage-impact-subheader-text {
    line-height: 1.3em;
    margin-top: .8em;

Event Timeline

Change 530447 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Impact: style subheader text

Change 530447 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Impact: style subheader text

For design review -checked in betalabs.
Below is comparison with the present production:

betalabsbetalabs with uselang=cscswiki production
IMG_8209.PNG (1×640 px, 101 KB)
IMG_8211.PNG (1×640 px, 99 KB)
IMG_8210.PNG (1×640 px, 100 KB)