Description

In the context of the mobile Newcomer homepage, the text of the Impact module previews presents vertical alignment issues.
According to mockup's specifications, subheader text's line-height should be 1.3em and margin-top should be .8em.

Actual Results:

Screenshot 2019-08-06 18.20.50.png (378×746 px, 46 KB)

Expected Results:

Screenshot 2019-08-12 19.32.29.png (378×752 px, 46 KB)

.growthexperiments-homepage-module-text-normal.growthexperiments-homepage-impact-subheader-text {
    line-height: 1.3em;
    margin-top: .8em;
}

Details

	Subject	Repo	Branch	Lines +/-
	Impact: style subheader text	mediawiki/extensions/GrowthExperiments	master	+5 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		• Rileych	T213990 [EPIC] Growth: Newcomer homepage
Resolved		MMiller_WMF	T215983 Homepage: mobile version
Resolved		• Rileych	T230014 Homepage: layout and UI fixes
Resolved	BUG REPORT	SBisson	T230376 Homepage: vertical alignment issues in mobile Impact module preview

Event Timeline

• Cntlsn created this task.Aug 12 2019, 5:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 12 2019, 5:34 PM

• Cntlsn triaged this task as Medium priority.Aug 12 2019, 5:34 PM

• Cntlsn moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

• Cntlsn added parent tasks: T230014: Homepage: layout and UI fixes, T213990: [EPIC] Growth: Newcomer homepage, T215983: Homepage: mobile version.Aug 12 2019, 5:45 PM

• Cntlsn removed a parent task: T213990: [EPIC] Growth: Newcomer homepage.

phuedx moved this task from Needs triage to Growth on the Mobile board.Aug 15 2019, 11:10 AM

Change 530447 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Impact: style subheader text

https://gerrit.wikimedia.org/r/530447

gerritbot added a project: Patch-For-Review.Aug 15 2019, 8:21 PM

SBisson claimed this task.Aug 15 2019, 8:21 PM

SBisson moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 16 2019, 10:40 AM

Change 530447 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Impact: style subheader text

https://gerrit.wikimedia.org/r/530447

Maintenance_bot removed a project: Patch-For-Review.Aug 16 2019, 11:10 AM

For design review -checked in betalabs.
Below is comparison with the present production:

betalabs	betalabs with `uselang=cs`	cswiki production

Etonkovidova moved this task from QA to Design Review on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 16 2019, 11:22 PM

LGTM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 20 2019, 9:01 PM

Thank you!

	F30009156: Screenshot 2019-08-06 18.20.50.png
	Aug 12 2019, 5:34 PM

	F30009158: Screenshot 2019-08-12 19.32.29.png
	Aug 12 2019, 5:34 PM

Homepage: vertical alignment issues in mobile Impact module previewClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related ObjectsSearch...

Event Timeline

Homepage: vertical alignment issues in mobile Impact module preview
Closed, ResolvedPublicBUG REPORT
Actions

Related Objects
Search...