Page MenuHomePhabricator
Create Task
Maniphest T230014

Homepage: layout and UI fixes
Closed, ResolvedPublic
Actions

Description

This task is a central place to address outstanding Newcomer homepage layout and UI fixes that haven't been surfaced elsewhere or don't need a specific phabricator task.

A list of UI fixes (current -- could be updated in the future) has been collected and prioritized in the following spreadsheet file:
https://docs.google.com/spreadsheets/d/1FXTiZX8ogKG3WLYZgZaQHdrzN-WLXi5ZNa8tPTqEBSI/edit?usp=sharing

The reference mockups can be accessed at:

Related Objects
Search...

StatusSubtypeAssignedTask
 Resolved• RileychT230014 Homepage: layout and UI fixes
 ResolvedBUG REPORTSBissonT230349 Homepage: module headers in mobile Start module dialog should have no padding
 ResolvedBUG REPORTSBissonT230377 Homepage: text size issue of pageviews number in Impact module
 ResolvedBUG REPORTSBissonT230376 Homepage: vertical alignment issues in mobile Impact module preview
 ResolvedSBissonT225667 Homepage: mobile submodule headers
 OpenNoneT225662 Homepage: tabbed menu should have border bottom
 ResolvedBUG REPORTSBissonT230350 Homepage: user info text vertical stacking issues in mobile account creation module
 ResolvedBUG REPORTSBissonT230352 Homepage: account age text styling issues in mobile account creation module
 ResolvedBUG REPORTJTannerWMFT230355 Homepage: icons alignment issue in mobile Start module dialog
 ResolvedBUG REPORTSBissonT230360 Homepage: modules padding issues in mobile Start module dialog
 ResolvedBUG REPORTSBissonT230364 Homepage: light text style tracking issue in mobile homepage module previews
 ResolvedBUG REPORTSBissonT230365 Homepage: incorrect text style in mobile help module preview
 ResolvedBUG REPORTSBissonT230368 Homepage: margin issues with light text in mobile Impact module dialog
 ResolvedBUG REPORTkostajhT230370 Homepage: size issue with mentor's username in mobile mentor module preview and dialog
 ResolvedBUG REPORTSBissonT230373 Homepage: mentor text style issues in mobile Mentorship module dialog
 ResolvedBUG REPORTSBissonT230374 Homepage: mentor message text style issue in mobile mentorship module dialog
 OpenBUG REPORTNoneT230375 Homepage: text style issues in recent questions list of mobile mentor and help module dialogs

Event Timeline

• Cntlsn created this task.Aug 7 2019, 11:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2019, 11:47 AM
• Cntlsn mentioned this in T225662: Homepage: tabbed menu should have border bottom.Aug 7 2019, 11:53 AM
• Cntlsn mentioned this in T225667: Homepage: mobile submodule headers.
• Cntlsn mentioned this in T218966: Homepage: layout and UI details.Aug 7 2019, 11:56 AM
JTannerWMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 7 2019, 6:21 PM
MMiller_WMF added a comment.Aug 7 2019, 8:03 PM

FYI @Cntlsn, I deleted the row about the mentor introductory message being in quotes, because we have a more complex rule: it should be in quotes if the mentor wrote it, but not in quotes if it's the default message (since the default message is not a quote).

• Cntlsn added a comment.Aug 8 2019, 9:56 AM

@MMiller_WMF sounds good, thanks for the correction!

kostajh added a comment.Aug 12 2019, 11:01 AM

@Cntlsn thank you for creating this, but could you please create one task per issue? It's important for 1) being able to associate patches with specific tasks that contain the relevant history (as opposed to what is now a private spreadsheet), 2) makes QA and code review easier since the reviewer just needs to evaluate one thing, in context 3) makes the tasks more easily distributed.

RHo added a comment.Aug 12 2019, 11:33 AM
In T230014#5409086, @kostajh wrote:

@Cntlsn thank you for creating this, but could you please create one task per issue? It's important for 1) being able to associate patches with specific tasks that contain the relevant history (as opposed to what is now a private spreadsheet), 2) makes QA and code review easier since the reviewer just needs to evaluate one thing, in context 3) makes the tasks more easily distributed.

hi @kostajh - sorry that was my bad! I asked @Cntlsn to file UI bugs prioritized in one task first, so that y'all could review together and break out into smaller bug tasks to fix according to priority and feasibility. Assuming that all the line items are fine to log as separate tickets, @Cntlsn can you please file as subtasks this parent "UI fixes" task? Thanks and sorry for the bad phabbing!

• Cntlsn added a comment.Aug 12 2019, 11:44 AM

Thanks @RHo and @kostajh, happy to break the list into single phab tasks.
A couple of questions before doing the work:

  • what would be the right column where to move all the tasks I create?
  • what would be the best way to highlight tasks priority? Triaging each task directly?
kostajh added a comment.Aug 12 2019, 11:47 AM

what would be the right column where to move all the tasks I create?

I think Ready for Development, since this one is there currently

what would be the best way to highlight tasks priority? Triaging each task directly?

Maybe just use High/Normal/Low in the phabricator priority field for each indvidual task?

thank you!

• Cntlsn added a subtask: T230349: Homepage: module headers in mobile Start module dialog should have no padding.Aug 12 2019, 2:33 PM
• Cntlsn added a subtask: T230377: Homepage: text size issue of pageviews number in Impact module.Aug 12 2019, 5:44 PM
• Cntlsn added a subtask: T230376: Homepage: vertical alignment issues in mobile Impact module preview.
• Cntlsn added a subtask: T225667: Homepage: mobile submodule headers.Aug 12 2019, 5:48 PM
• Cntlsn added a subtask: T225662: Homepage: tabbed menu should have border bottom.
• Cntlsn added a subtask: T230350: Homepage: user info text vertical stacking issues in mobile account creation module.
• Cntlsn added a subtask: T230352: Homepage: account age text styling issues in mobile account creation module.
• Cntlsn added a subtask: T230355: Homepage: icons alignment issue in mobile Start module dialog.
• Cntlsn added a subtask: T230360: Homepage: modules padding issues in mobile Start module dialog.Aug 12 2019, 5:51 PM
• Cntlsn added a subtask: T230364: Homepage: light text style tracking issue in mobile homepage module previews.
• Cntlsn added a subtask: T230365: Homepage: incorrect text style in mobile help module preview.
• Cntlsn added a subtask: T230368: Homepage: margin issues with light text in mobile Impact module dialog.
• Cntlsn added a subtask: T230370: Homepage: size issue with mentor's username in mobile mentor module preview and dialog.
• Cntlsn added a subtask: T230373: Homepage: mentor text style issues in mobile Mentorship module dialog.
• Cntlsn added a subtask: T230374: Homepage: mentor message text style issue in mobile mentorship module dialog.
• Cntlsn added a subtask: T230375: Homepage: text style issues in recent questions list of mobile mentor and help module dialogs.Aug 12 2019, 5:53 PM
phuedx moved this task from Needs triage to Growth on the Mobile board.Aug 15 2019, 11:11 AM
kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 19 2019, 8:28 PM
JTannerWMF moved this task from In Progress to Epics In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 21 2019, 5:44 PM

This is actually an epic so I am moving this to the correct column

MMiller_WMF closed subtask T230374: Homepage: mentor message text style issue in mobile mentorship module dialog as Resolved.Aug 28 2019, 6:38 PM
MMiller_WMF closed subtask T230373: Homepage: mentor text style issues in mobile Mentorship module dialog as Resolved.Aug 29 2019, 12:49 AM
MMiller_WMF closed subtask T230364: Homepage: light text style tracking issue in mobile homepage module previews as Resolved.
MMiller_WMF closed subtask T230350: Homepage: user info text vertical stacking issues in mobile account creation module as Resolved.
MMiller_WMF closed subtask T230377: Homepage: text size issue of pageviews number in Impact module as Resolved.Aug 29 2019, 12:51 AM
MMiller_WMF closed subtask T230365: Homepage: incorrect text style in mobile help module preview as Resolved.
MMiller_WMF closed subtask T230376: Homepage: vertical alignment issues in mobile Impact module preview as Resolved.Sep 23 2019, 10:00 PM
MMiller_WMF closed subtask T230352: Homepage: account age text styling issues in mobile account creation module as Resolved.
MMiller_WMF closed subtask T230360: Homepage: modules padding issues in mobile Start module dialog as Resolved.
MMiller_WMF closed subtask T230349: Homepage: module headers in mobile Start module dialog should have no padding as Resolved.
MMiller_WMF closed subtask T230368: Homepage: margin issues with light text in mobile Impact module dialog as Resolved.
MMiller_WMF closed subtask T230370: Homepage: size issue with mentor's username in mobile mentor module preview and dialog as Resolved.
MMiller_WMF closed subtask T225667: Homepage: mobile submodule headers as Resolved.Sep 24 2019, 5:24 PM
Etonkovidova closed subtask T230355: Homepage: icons alignment issue in mobile Start module dialog as Resolved.Dec 13 2019, 5:43 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:51 PM
• Rileych removed a project: Growth-Team-Filtering.Apr 20 2021, 4:46 PM
• Rileych closed this task as Resolved.May 4 2021, 1:23 PM
• Rileych claimed this task.
• Rileych subscribed.

Kosta and I are closing this. Reopen if you need to!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits