Page MenuHomePhabricator

Homepage: size issue with mentor's username in mobile mentor module preview and dialog
Closed, ResolvedPublicBUG REPORT

Description

In the context of the mobile Newcomer homepage, mentor's username in both mentor module preview and details dialog has too big font-size.

Actual Results:

Screenshot 2019-08-06 17.55.11.png (296×750 px, 35 KB)

calculated font-size is 19.2px.

Expected Results:

Screenshot 2019-08-12 18.49.13.png (296×752 px, 25 KB)

font-size should be 18px.

.growthexperiments-homepage-mentorship-username {
    font-size: .95em;
}

Event Timeline

Cntlsn updated the task description. (Show Details)

Should this change be made only on mobile, or only on desktop?

It is mobile only, and is related to T230374. The font-size for the two texts should be as close as possible, as it is on desktop already.

Change 530584 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Mentorship: update mentor name text

https://gerrit.wikimedia.org/r/530584

Change 530584 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Mentorship: update mentor name text

https://gerrit.wikimedia.org/r/530584

@kostajh the specs in the task refer to "growthexperiments-homepage-mentorship-username" element on two different screens - Homepage and Mentorship module. The font-size was changed on Mentorship module:

Screen Shot 2019-08-19 at 12.30.49 PM.png (997×1 px, 407 KB)

Comparison with test wiki:

betalabstestwiki
IMG_8220(1).PNG (1×640 px, 88 KB)
IMG_8221(1).PNG (1×640 px, 64 KB)

On Homepage I don't see the change in the calculated font-size. In both, Chrome and FF. The font-size seems to be falling to browser default

Another one - "growthexperiments-homepage-mentorship-username" on Homepage - has the same font-size as before:

Screen Shot 2019-08-19 at 12.24.40 PM.png (1×1 px, 390 KB)

Change 531138 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Adjust username font size on mobile summary

https://gerrit.wikimedia.org/r/531138

Change 531138 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Adjust username font size on mobile summary

https://gerrit.wikimedia.org/r/531138

Checked in`testwiki wmf.19` - the latest fix is in place.

Looks close enough to 18px from 0.95em to pass