Page MenuHomePhabricator

Homepage: size issue with mentor's username in mobile mentor module preview and dialog
Open, LowPublicBug

Description

In the context of the mobile Newcomer homepage, mentor's username in both mentor module preview and details dialog has too big font-size.

Actual Results:

calculated font-size is 19.2px.

Expected Results:

font-size should be 18px.

.growthexperiments-homepage-mentorship-username {
    font-size: .95em;
}

Event Timeline

Cntlsn created this task.Mon, Aug 12, 4:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, Aug 12, 4:51 PM
Cntlsn triaged this task as Low priority.Mon, Aug 12, 4:52 PM
Cntlsn updated the task description. (Show Details)

Should this change be made only on mobile, or only on desktop?

phuedx moved this task from Needs triage to Growth on the Mobile board.Thu, Aug 15, 11:10 AM

It is mobile only, and is related to T230374. The font-size for the two texts should be as close as possible, as it is on desktop already.

Change 530584 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Mentorship: update mentor name text

https://gerrit.wikimedia.org/r/530584

Change 530584 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Mentorship: update mentor name text

https://gerrit.wikimedia.org/r/530584

@kostajh the specs in the task refer to "growthexperiments-homepage-mentorship-username" element on two different screens - Homepage and Mentorship module. The font-size was changed on Mentorship module:

Comparison with test wiki:

betalabstestwiki

On Homepage I don't see the change in the calculated font-size. In both, Chrome and FF. The font-size seems to be falling to browser default

Another one - "growthexperiments-homepage-mentorship-username" on Homepage - has the same font-size as before:

Change 531138 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Adjust username font size on mobile summary

https://gerrit.wikimedia.org/r/531138

kostajh claimed this task.Tue, Aug 20, 9:45 AM
kostajh moved this task from Design Review to Code Review on the Growth-Team (Current Sprint) board.

Change 531138 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Adjust username font size on mobile summary

https://gerrit.wikimedia.org/r/531138

Checked in`testwiki wmf.19` - the latest fix is in place.