| • Cntlsn | |
| Aug 12 2019, 5:12 PM |
| F30118749: Screen Shot 2019-08-22 at 12.12.23 PM.png | |
| Aug 26 2019, 7:47 PM |
| F30051926: image.png | |
| Aug 21 2019, 8:16 AM |
| F30043089: mentorship 4.PNG | |
| Aug 17 2019, 12:21 AM |
| F30043082: mentorship 1.PNG | |
| Aug 17 2019, 12:21 AM |
| F30043085: mentorship 3.PNG | |
| Aug 17 2019, 12:21 AM |
| F30009135: Screenshot 2019-08-12 19.10.50.png | |
| Aug 12 2019, 5:12 PM |
| F30009132: Screenshot 2019-08-06 17.59.25.png | |
| Aug 12 2019, 5:12 PM |
In the context of the mobile Newcomer homepage, the mentor's message text style in the mobile Mentorship module dialog is not correct. According to mockup's specifications the font-size should be as close as possible to 18px and letter-spacing should be .016em.
Actual Results:
Expected Results:
.growthexperiments-homepage-mentorship-intro {
font-size: 1.1em;
}| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Rileych | T213990 [EPIC] Growth: Newcomer homepage | |||
| Resolved | MMiller_WMF | T215983 Homepage: mobile version | |||
| Resolved | • Rileych | T230014 Homepage: layout and UI fixes | |||
| Resolved | BUG REPORT | SBisson | T230374 Homepage: mentor message text style issue in mobile mentorship module dialog |
Change 530579 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Mentorship: update intro text size on mobile
Change 530579 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Mentorship: update intro text size on mobile
For Design review:
.growthexperiments-homepage-mobile-details .growthexperiments-homepage-mentorship-intro, .growthexperiments-homepage-module-mobile-overlay .growthexperiments-homepage-mentorship-intro {
font-size: 1.1em;
letter-spacing: 0.016em;
(Interesting that "Your recent questions" label dispalyed untranslated, but when I checked there was no untranslated messagesin cswiki).
| With long description | With uselang=cs |
 |  |
Font-size and leading LGTM
Maybe we can investigate why the translate strings for "Your recent questions" and the time since a question was posted ("Posted $1") are not showing up, since they are shown as translated:
I don't know why uselang=cs didn't work in this case, but if you change the language to cs via the language selector widget the strings appear correctly
I don't know why uselang=cs didn't work in this case, but if you change the language to cs via the language selector widget the strings appear correctly
Ah, I do know why. On the server side, we render the "Your recent questions" section with the correct language, but it's updated immediately via JS (so we have the correct archived status of questions) and that is not respecting the language code set by the user.
Change 531434 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] QuestionStore API: Accept language code from client
hi @kostajh - actually, I am reviewing further tasks related to letter-spacing and can we remove specifying letter-spacing from all the modules please? It has very marginal benefit considering we are using the standard sans-serif font stack anyway, and in the different languages we have the module, I prefer to not change the letter-spacing from the default of 0 in case of unintended visual effects.
I will update the task description accordingly.
Done in a patch not linked here. So, the remaining issue for code review and then QA is rendering the "Your recent questions" bit in the language that the user is viewing the wiki (e.g. uselang=cs when the wiki content language is en).
Change 531434 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Homepage recent questions: Send language code from client
