Page MenuHomePhabricator

Newcomer tasks: "No results" card widget
Closed, ResolvedPublic

Description

  • If the user's filter settings yield no tasks, they should see an area that says something like, "Change the filter settings to find more tasks." along with a graphic. Mockup here.

Event Timeline

kostajh created this task.Oct 9 2019, 10:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2019, 10:25 AM
kostajh removed kostajh as the assignee of this task.Oct 9 2019, 10:31 AM
MMiller_WMF renamed this task from Build out "No results" card widget to Newcomer tasks: "No results" card widget.Oct 9 2019, 5:47 PM
MMiller_WMF added subscribers: Catrope, Tgr, Etonkovidova and 6 others.

Change 542904 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: "No results" card widget

https://gerrit.wikimedia.org/r/542904

Change 542904 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: "No results" card widget

https://gerrit.wikimedia.org/r/542904

@Catrope will fix the issue with button positioning.

Expected:
Actual:

Minor visual bugs:

  • Height of card should not alter when no suggestions are found. This can be done by adding more space above the "No suggestions found" header
  • There should ~8px more space between the header "No suggestions found" and the graphic
MMiller_WMF moved this task from Inbox to Upcoming Work on the Growth-Team board.

Change 565719 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Fix no results card logic

https://gerrit.wikimedia.org/r/565719

Change 565721 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Make pseudo cards have a similar size to real cards

https://gerrit.wikimedia.org/r/565721

Change 565719 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix no results card logic

https://gerrit.wikimedia.org/r/565719

Moving to QA; please see the notes in the commit message for some caveats about the implementation.

Change 565721 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Make pseudo cards have a similar size to real cards

https://gerrit.wikimedia.org/r/565721

Checked in betalabs and moved for a Design review - please note the divider between topics and difficulty filters seems to be of double width.

.

There is still an issue of the height changing when the module has suggestion vs when there are no suggestions:

As @Tgr noted on T242470, this is more noticeable when clicking from the last suggested article card to the end message, but I am wondering if we can introduce a fixed height somehow to stop this from happening and resolve both this task and T2342470?

MMiller_WMF closed this task as Resolved.Feb 4 2020, 1:39 AM

@RHo -- changing heights are already filed separately here: T237482: Newcomer tasks: module height changes

If that's the only outstanding thing you saw, then this task is resolved. Thank you!