- If the user's filter settings yield no tasks, they should see an area that says something like, "Change the filter settings to find more tasks." along with a graphic. Mockup here.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | MMiller_WMF | T227728 [EPIC] Growth: Newcomer tasks 1.0 | |||
| Resolved | kostajh | T232423 Newcomer tasks: suggested edits module | |||
| Resolved | kostajh | T235044 Newcomer tasks: "No results" card widget |
Event Timeline
Comment Actions
Change 542904 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: "No results" card widget
Comment Actions
Change 542904 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: "No results" card widget
Comment Actions
Expected:  | Actual:  |
Minor visual bugs:
- Height of card should not alter when no suggestions are found. This can be done by adding more space above the "No suggestions found" header
- There should ~8px more space between the header "No suggestions found" and the graphic
Comment Actions
Change 565719 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Fix no results card logic
Comment Actions
Change 565721 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Make pseudo cards have a similar size to real cards
Comment Actions
Change 565719 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix no results card logic
Comment Actions
Moving to QA; please see the notes in the commit message for some caveats about the implementation.
Comment Actions
Change 565721 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Make pseudo cards have a similar size to real cards
Comment Actions
.
Checked in betalabs and moved for a Design review - please note the divider between topics and difficulty filters seems to be of double width.
Comment Actions
There is still an issue of the height changing when the module has suggestion vs when there are no suggestions:
As @Tgr noted on T242470, this is more noticeable when clicking from the last suggested article card to the end message, but I am wondering if we can introduce a fixed height somehow to stop this from happening and resolve both this task and T2342470?
Comment Actions
@RHo -- changing heights are already filed separately here: T237482: Newcomer tasks: module height changes
If that's the only outstanding thing you saw, then this task is resolved. Thank you!