Change 562664 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: pass topic matching enabled flag to "no results" cards

https://gerrit.wikimedia.org/r/562664

Change 562664 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: pass topic matching enabled flag to "no results" cards

https://gerrit.wikimedia.org/r/562664

Looks like this needs some style tweaks

It looks fine to me... some kind of browser difference maybe?

I see the same as in @Gergo comment above.

However, two points to notice

• @RHo comment - https://phabricator.wikimedia.org/T235044#5662071 - has not been addressed.
• a question to @RHo - when there is no results found, the footer still says - "Other users have noted these articles need work...". Since the footer refers to the article(s) displayed - should we provide a different footer for the case when there are no results have been found?
• for "No more suggestions" - the text "Select other interests or difficulty levels to find suggested edits." gets cut off for cswiki - filed as T242470: Newcomer tasks: suggested edits "se-card-text" is cut off for long text

In T238613#5791969, @Tgr wrote:

It looks fine to me... some kind of browser difference maybe?

Of course looking good in English does not mean that's not a problem, duh.

The thing is, the text area has a fixed height, because the whole card has a fixed height, because we want the various card types to have the same dimensions. (For the no results card that's probably not that important. The no more suggestions card takes the place of a task card during navigation though, so size changes would be jarring.) Not sure how to square that with supporting arbitrarily long interface messages in the bottom.

In T238613#5793748, @Etonkovidova wrote:

How did that happen? It shouldn't be possible to see the no results card and a task type description in the same time.

@Etonkovidova -- I think this question is for you.

In T238613#5794394, @Tgr wrote:

How did that happen? It shouldn't be possible to see the no results card and a task type description in the same time.

I cannot reproduce it.

In T238613#5793748, @Etonkovidova wrote:

• a question to @RHo - when there is no results found, the footer still says - "Other users have noted these articles need work...". Since the footer refers to the article(s) displayed - should we provide a different footer for the case when there are no results have been found?

That's a good point but I think this is OK to keep the same since the default case is this module will show some articles suggestions, and it should be clear the text "Other users..." refers to the entire set suggested edits.

In T238613#5794394, @Tgr wrote:

The thing is, the text area has a fixed height, because the whole card has a fixed height, because we want the various card types to have the same dimensions. (For the no results card that's probably not that important. The no more suggestions card takes the place of a task card during navigation though, so size changes would be jarring.) Not sure how to square that with supporting arbitrarily long interface messages in the bottom.

I see @MMiller_WMF has created a separate task T242470 for this issue, so happy to move this copy-specific task to PM review.