Page MenuHomePhabricator
Create Task
Maniphest T237505

Globaluserinfo API module should allow getting data for more than one user at once
Open, MediumPublic
Actions

Description

Sometimes, it's handy to API request data about more than one user at once.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/CentralAuthmaster+177 -123API: Allow multiple values in 'user' and 'id' parameters to globaluserinfo
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm created this task.Nov 6 2019, 9:06 AM
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptNov 6 2019, 9:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Nov 6 2019, 9:07 AM

Change 548966 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/CentralAuth@master] [api] Allow users to specify more than one user to globaluserinfo

https://gerrit.wikimedia.org/r/548966

gerritbot added a project: Patch-For-Review.Nov 6 2019, 9:07 AM
Urbanecm triaged this task as High priority.Nov 6 2019, 9:16 AM

This is a dependency of one GCI tasks, triaging as high.

Urbanecm moved this task from Backlog to Waiting on review on the User-Urbanecm board.Nov 11 2019, 8:23 AM
dbarratt added a project: Anti-Harassment.Nov 17 2019, 10:22 PM
Restricted Application added a subscriber: MGChecker. · View Herald TranscriptNov 17 2019, 10:22 PM
dbarratt mentioned this in T237296: CheckUser 2.0: Create service and methods for new CU extension.Nov 18 2019, 3:38 PM
1997kB added a subscriber: 1997kB.Dec 10 2019, 1:49 AM
Krinkle added projects: Platform Engineering, Performance-Team (Radar).Dec 15 2019, 6:59 PM
Krinkle added subscribers: Anomie, Krinkle.
@Krinkle wrote at Gerrit:

[…] I'm not familiar with the CA code itself to know whether this safe and will perform well at standard batch sizes. If this is a cheap lookup, then repeating it 500 times may be fine.

If not, then this has to be declined and/or blocked on adding batching to the internal logic because repeating it synchronously in a single thread on the server would be undesirable for prod stability (repeated and/or concurrent queries would be preferred in that case).

I've CC-ed @Anomie and CPT on the task whom I believe know this code better. Their input should be waited for before merging this.

Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Dec 15 2019, 7:00 PM
Anomie edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Dec 16 2019, 2:16 PM
Anomie moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.
Anomie moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (Clinic Duty Team) board.Dec 16 2019, 8:51 PM
WDoranWMF moved this task from External Code Review In Progress to External Code Review Completed on the Platform Team Workboards (Clinic Duty Team) board.Mar 3 2020, 8:57 PM
Krinkle removed a project: Performance-Team (Radar).Mar 3 2020, 10:30 PM
Krinkle removed a subscriber: Krinkle.
DannyS712 added a subscriber: DannyS712.Mar 25 2020, 5:41 AM
Minorax added a subscriber: Minorax.Mar 25 2020, 5:42 AM
CptViraj added a subscriber: CptViraj.Apr 3 2020, 4:15 AM
Urbanecm moved this task from External Code Review Completed to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.Apr 20 2020, 9:46 AM

Review incorporated, could CPT have another look?

daniel lowered the priority of this task from High to Medium.Apr 21 2020, 9:22 AM
daniel raised the priority of this task from Medium to High.Apr 21 2020, 9:31 AM
daniel moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (Clinic Duty Team) board.
Urbanecm lowered the priority of this task from High to Medium.Jul 11 2020, 2:53 PM
In T237505#5639450, @Urbanecm wrote:

This is a dependency of one GCI tasks, triaging as high.

(not true anymore)

CCicalese_WMF edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Team Workboards (Clinic Duty Team).Jul 31 2020, 5:10 PM
DannyS712 mentioned this in T261752: API: Make list=users display status of globally locked users.Sep 1 2020, 2:23 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:02 PM
GeneralNotability added a subscriber: GeneralNotability.Oct 24 2020, 3:42 PM
phuedx moved this task from Untriaged to Tracking work by others on the Anti-Harassment board.Oct 18 2021, 4:52 PM
MarcoAurelio awarded a token.Apr 18 2022, 2:31 PM
Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Tue, Feb 21, 9:33 PM
Aklapper removed Urbanecm as the assignee of this task.Tue, Mar 21, 9:41 AM

@Urbanecm: Removing task assignee as this open task has been assigned for more than two years - See the email sent to task assignee on Feburary 22nd, 2023.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL