Here's a question – where do the units come from? Are we using a hard-coded list, or somehow fetching a list of appropriate units based on the property? Units will also be property-specific (a "length" property will have different units from a "weight" property).

How does Wikidata handle this?

In T239474#5728837, @egardner wrote:

Here's a question – where do the units come from? Are we using a hard-coded list, or somehow fetching a list of appropriate units based on the property? Units will also be property-specific (a "length" property will have different units from a "weight" property).

How does Wikidata handle this?

Wikidata. You can put in centimeter or Cameroon

Any news on this? We just created https://www.wikidata.org/wiki/Property:P7787 to indicate the heading the photographer was looking when taking the image. The unit would be degree (http://www.wikidata.org/entity/Q28390). Currently can't use that, just without a unit, see for example https://commons.wikimedia.org/w/index.php?title=File:%D0%A1h%C3%A2teau_d%27Amboise_4.jpg&diff=prev&oldid=387384011

This is work that will be coming up soon. Best estimate for deployment is early Feb., but it could be earlier if things work out. We're a bit short-handed at the moment.

@matthiasmullie what am I doing wrong at /w/api.php?action=wbeditentity&format=json&id=M51867633&token=123445678903dd2%2B%5C&data=%7B%22claims%22%3A%5B%7B%22mainsnak%22%3A%7B%22snaktype%22%3A%22value%22%2C%22property%22%3A%22P7787%22%2C%22datavalue%22%3A%7B%22value%22%3A%20%7B%22amount%22%20%3A%20%22%2B67%22%2C%20%22unit%22%20%3A%20%22http%3A%2F%2Fwww.wikidata.org%2Fentity%2FQ28390%22%7D%2C%22type%22%3A%22quantity%22%7D%7D%2C%22type%22%3A%22statement%22%2C%22rank%22%3A%22normal%22%7D%5D%7D ?

In T239474#5803682, @Multichill wrote:

@matthiasmullie what am I doing wrong at /w/api.php?action=wbeditentity&format=json&id=M51867633&token=123445678903dd2%2B%5C&data=%7B%22claims%22%3A%5B%7B%22mainsnak%22%3A%7B%22snaktype%22%3A%22value%22%2C%22property%22%3A%22P7787%22%2C%22datavalue%22%3A%7B%22value%22%3A%20%7B%22amount%22%20%3A%20%22%2B67%22%2C%20%22unit%22%20%3A%20%22http%3A%2F%2Fwww.wikidata.org%2Fentity%2FQ28390%22%7D%2C%22type%22%3A%22quantity%22%7D%7D%2C%22type%22%3A%22statement%22%2C%22rank%22%3A%22normal%22%7D%5D%7D ?

Probably nothing :)
I have a feeling this @todo has something to do with it: https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/repo/includes/WikibaseRepo.php#L1235
It looks like only entities from a local repo (in this case Commons) are allowed, but we need it to accept Wikidata concept uris.
Will continue looking into this - stay tuned!

Change 566397 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Implement units support for quantity input UI

https://gerrit.wikimedia.org/r/566397

Yup, it looks like the issue is:

	/**
	 * @return string
	 */
	private function getVocabularyBaseUri() {
		//@todo: We currently use the local repo concept URI here. This should be configurable,
		// to e.g. allow 3rd parties to use Wikidata as their vocabulary repo.
		if ( $this->getDataAccessSettings()->useEntitySourceBasedFederation() ) {
			return $this->getLocalEntitySource()->getConceptBaseUri();
		}

		return $this->settings->getSetting( 'conceptBaseUri' );
	}

This need to be switched based on entity type, as mediainfos need the concept base URI of commons, and items and properties need the concept base URI of wikidata.

In WikibaseRepo this base uri is currently used by getLocalItemUriParser which sounds like it only ever needs the actually local concept URI base.
It is also used in newValidatorBuilders however, which in turn is used in buildQuantityValidators, this should probably only ever have the concept URI base for Items.

Change 566753 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Cleanup repo Item vocab uri parsing & fix federated units

https://gerrit.wikimedia.org/r/566753

Change 566766 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] Adjust for Repo, LocalItemUriParser -> ItemUrlParser

https://gerrit.wikimedia.org/r/566766

Change 566767 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Remove deprecated WikibaseRepo::getLocalItemUriParser

https://gerrit.wikimedia.org/r/566767

Change 566753 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Cleanup repo Item vocab uri parsing & fix federated units

https://gerrit.wikimedia.org/r/566753

Change 566766 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Adjust for Repo, LocalItemUriParser -> ItemUrlParser

https://gerrit.wikimedia.org/r/566766

Change 566767 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove deprecated WikibaseRepo::getLocalItemUriParser

https://gerrit.wikimedia.org/r/566767

I just come here to report this bug. Luckily it is being fixed.

Actual (backend) support for other entities has already been merged.
Patch to bring support to the frontend is in code review.

Here's what that'll look like - pretty much the exact same as Wikidata & support for time inputs.

Empty:

Once it receives input, the customization panel pops out:

Where units can be searched:

And are eventually rendered with units:

And pretty much the exact same for qualifiers:

In T239474#5845117, @matthiasmullie wrote:

Where units can be searched:

If we're building a new interface, can you make it a bit smarter so it actually suggests a relevant unit? If I'm adding things like height and width, I probably want something like cm (not Cameroon) and when I add heading I probably want degree. Now I just get everything .

Wanted to test this, but looks like 1.35.0-wmf.18 got rolled back everywhere 2 days ago.

Design update: see F31552245

In T239474#5845899, @Multichill wrote:

If we're building a new interface, can you make it a bit smarter so it actually suggests a relevant unit? If I'm adding things like height and width, I probably want something like cm (not Cameroon) and when I add heading I probably want degree. Now I just get everything .

I like the idea, but it's going to be a bit of a pain to figure out how to best go about this (can't hardcode specific items into the code)
Wikidata has a bazillion config vars to reference specific items, I guess we could go with something similar here.
Either way, I filed T244856 - it's outside this task's scope :)

I agree, let's continue in the other task about that part.

Change 566397 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Implement units support for quantity input UI

https://gerrit.wikimedia.org/r/566397