Internal API HTTP requests should hit the app server internal service IP, not the public HTTPS URL
Open, Needs TriagePublic
Actions

Description

Off the top of my head GlobalUserPage needs updating, definitely there are others.

Rough codesearch: https://codesearch.wmflabs.org/operations/?q=https%3A%2F%2F&i=nope&files=php%24&repos=Wikimedia%20MediaWiki%20config

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T243727 Internal API HTTP requests should hit the app server internal service IP, not the public HTTPS URL
		Resolved		Addshore	T243726 Babel should get cross-wiki languages via DB instead of making an HTTP request

Event Timeline

Legoktm created this task.Jan 26 2020, 9:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2020, 9:39 PM

Addshore subscribed.Jan 26 2020, 9:40 PM

The one's I can think of off the top of my head:

Commons file descriptions (wmf-config/filebackend.php)
GlobalUserPage
Babel ( T243726 )
CirrusSearch config
SpamBlacklist
JsonConfig

Jdforrester-WMF added a subtask: T243726: Babel should get cross-wiki languages via DB instead of making an HTTP request.Jan 26 2020, 9:47 PM

Jdforrester-WMF edited projects, added Performance Issue, MediaWiki-Action-API, WMF-General-or-Unknown; removed Wikimedia-Site-requests.

Restricted Application added a project: Platform Engineering. · View Herald TranscriptJan 26 2020, 9:47 PM

Jdforrester-WMF added projects: GlobalUserPage, CirrusSearch, SpamBlacklist, JsonConfig.Jan 26 2020, 9:48 PM

Restricted Application added a project: Discovery-Search. · View Herald TranscriptJan 26 2020, 9:48 PM

@Jdforrester-WMF I don't think any of these merit fixing in the extensions themselves, rather in the wmf-config, which is why I tagged it Wikimedia-Site-requests

In T243727#5833006, @Legoktm wrote:

@Jdforrester-WMF I don't think any of these merit fixing in the extensions themselves, rather in the wmf-config, which is why I tagged it Wikimedia-Site-requests

I'm not sure, probably most of these extensions need fixing to add header of "Host: " otherwise, something like appservers-ro.discovery.wmnet would not work.

In T243727#5833006, @Legoktm wrote:

@Jdforrester-WMF I don't think any of these merit fixing in the extensions themselves, rather in the wmf-config, which is why I tagged it Wikimedia-Site-requests

Either way, the responsible teams should know so that they don't "fix" it later.

Anomie moved this task from Unsorted to Non-core-API stuff on the MediaWiki-Action-API board.Jan 27 2020, 3:19 AM

Legoktm added a project: Wikimedia-Incident.Jan 27 2020, 4:48 AM

WMDE-leszek subscribed.Jan 27 2020, 9:03 AM

Michael subscribed.Jan 27 2020, 9:55 AM