Page MenuHomePhabricator
Create Task
Maniphest T253764

Undeploy the InterwikiSorting extension from Wikipedia production
Closed, DeclinedPublic
Actions

Description

In T252870#6169365, @Addshore wrote:
In T252870#6169364, @Jdforrester-WMF wrote:

Is InterwikiSorter not needed in production anymore, then?

I don't believe so, sounds like it can be undeployed! woo!

Details

SubjectRepoBranchLines +/-
Stop branching the InterwikiSorting extensionmediawiki/tools/releasemaster+0 -1
Allow setting prepend languages without relying on InterwikiSorting extensionmediawiki/extensions/UniversalLanguageSelectormaster+4 -1
Undeploy InterwikiSorting - V: Stop loading i18noperations/mediawiki-configmaster+0 -1
Undeploy InterwikiSorting - IV: Drop all configoperations/mediawiki-configmaster+0 -57
Undeploy InterwikiSorting - III: Drop InterwikiSortOrders.phpoperations/mediawiki-configmaster+0 -140
Undeploy InterwikiSorting - II: Drop loading abilityoperations/mediawiki-configmaster+0 -5
Undeploy InterwikiSorting - I: Disable everywhereoperations/mediawiki-configmaster+0 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.May 27 2020, 3:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2020, 3:46 PM
gerritbot added a comment.May 27 2020, 3:57 PM

Change 599064 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Undeploy InterwikiSorting - I: Disable everywhere

https://gerrit.wikimedia.org/r/599064

gerritbot added a project: Patch-For-Review.May 27 2020, 3:57 PM

Change 599065 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Undeploy InterwikiSorting - II: Drop loading ability

https://gerrit.wikimedia.org/r/599065

gerritbot added a comment.May 27 2020, 3:57 PM

Change 599066 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Undeploy InterwikiSorting - III: Drop InterwikiSortOrders.php

https://gerrit.wikimedia.org/r/599066

Jdforrester-WMF renamed this task from Undeploy the InterwikiSorter extension from Wikipedia production to Undeploy the InterwikiSorting extension from Wikipedia production.May 27 2020, 3:57 PM
gerritbot added a comment.May 27 2020, 3:57 PM

Change 599067 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Undeploy InterwikiSorting - IV: Drop all config

https://gerrit.wikimedia.org/r/599067

gerritbot added a comment.May 27 2020, 3:57 PM

Change 599068 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Undeploy InterwikiSorting - V: Stop loading i18n

https://gerrit.wikimedia.org/r/599068

gerritbot added a comment.May 27 2020, 3:59 PM

Change 599069 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/tools/release@master] Stop branching the InterwikiSorting extension

https://gerrit.wikimedia.org/r/599069

gerritbot added a comment.May 27 2020, 4:16 PM

Change 599073 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/UniversalLanguageSelector@master] Allow setting prepend languages without relying on InterwikiSorting extension

https://gerrit.wikimedia.org/r/599073

MarcoAurelio added a subtask: T106123: Extensions needing to be removed from Wikimedia wikis.May 27 2020, 5:14 PM
MarcoAurelio removed a subtask: T106123: Extensions needing to be removed from Wikimedia wikis.
MarcoAurelio added a parent task: T106123: Extensions needing to be removed from Wikimedia wikis.
Addshore added a comment.May 28 2020, 3:57 PM

I had a quick check through the code and believe this can indeed be removed.
As long as the other thing is deployed everywhere this is and is not going away :)

Jdforrester-WMF moved this task from INBOX to Learning/Teaching/Blogging/Reading on the Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)) board.Jun 17 2020, 5:31 PM
Jdforrester-WMF moved this task from Learning/Teaching/Blogging/Reading to Maintenance on the Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)) board.
thcipriani edited projects, added Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)); removed Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)).Jul 8 2020, 5:34 PM
DannyS712 added a subtask: T257625: Interwiki sorting broken.Jul 10 2020, 6:06 AM
Lucas_Werkmeister_WMDE mentioned this in T257625: Interwiki sorting broken.Jul 10 2020, 10:24 AM
DannyS712 removed a subtask: T257625: Interwiki sorting broken.Jul 12 2020, 11:02 PM
Meno25 subscribed.Jul 18 2020, 9:43 AM
thcipriani edited projects, added Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)); removed Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)).Oct 21 2020, 1:07 AM
Pikne subscribed.Oct 21 2020, 6:51 AM
Lydia_Pintscher mentioned this in T267332: Determine which projects WMDE Technical Wishes is responsible for.Nov 11 2020, 2:06 PM
Pikne added a comment.EditedDec 2 2020, 5:38 PM
In T252870#6168927, @gerritbot wrote:

Change 599008 abandoned by Addshore:
...
Apparently this is no longer needed ad compact language links is deployed everywhere?

There may be some sort of misunderstanding here. To my understanding this extension orders compact links too, as evidenced by recent outage (T257625). Also users can opt out from using compact links.

Nikerabbit subscribed.Mar 17 2021, 12:15 PM

Is anyone driving this task? There are patches for ULS which have been open for a year soon and I'm wondering what to do about them.

Addshore added a comment.Mar 17 2021, 12:55 PM

Also users can opt out from using compact links.

So I believe this extension is still needed?
Then we can close this and decline this.

thcipriani removed a project: Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)).Apr 20 2021, 12:21 AM
thcipriani added a project: Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)).Apr 20 2021, 12:34 AM
thcipriani edited projects, added Release-Engineering-Team (Doing); removed Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)).Apr 20 2021, 4:25 AM
gerritbot added a comment.May 10 2021, 3:01 PM

Change 599064 abandoned by Jforrester:

[operations/mediawiki-config@master] Undeploy InterwikiSorting - I: Disable everywhere

Reason:

Per task.

https://gerrit.wikimedia.org/r/599064

gerritbot added a comment.May 10 2021, 3:02 PM

Change 599065 abandoned by Jforrester:

[operations/mediawiki-config@master] Undeploy InterwikiSorting - II: Drop loading ability

Reason:

Per task.

https://gerrit.wikimedia.org/r/599065

gerritbot added a comment.May 10 2021, 3:02 PM

Change 599066 abandoned by Jforrester:

[operations/mediawiki-config@master] Undeploy InterwikiSorting - III: Drop InterwikiSortOrders.php

Reason:

Per task.

https://gerrit.wikimedia.org/r/599066

gerritbot added a comment.May 10 2021, 3:02 PM

Change 599067 abandoned by Jforrester:

[operations/mediawiki-config@master] Undeploy InterwikiSorting - IV: Drop all config

Reason:

Per task.

https://gerrit.wikimedia.org/r/599067

gerritbot added a comment.May 10 2021, 3:02 PM

Change 599068 abandoned by Jforrester:

[operations/mediawiki-config@master] Undeploy InterwikiSorting - V: Stop loading i18n

Reason:

Per task.

https://gerrit.wikimedia.org/r/599068

gerritbot added a comment.May 10 2021, 3:02 PM

Change 599073 abandoned by Jforrester:

[mediawiki/extensions/UniversalLanguageSelector@master] Allow setting prepend languages without relying on InterwikiSorting extension

Reason:

Per task.

https://gerrit.wikimedia.org/r/599073

gerritbot added a comment.May 10 2021, 3:02 PM

Change 599069 abandoned by Jforrester:

[mediawiki/tools/release@master] Stop branching the InterwikiSorting extension

Reason:

Per task.

https://gerrit.wikimedia.org/r/599069

Jdforrester-WMF closed this task as Declined.May 10 2021, 3:03 PM
In T253764#6921275, @Addshore wrote:

Also users can opt out from using compact links.

So I believe this extension is still needed?
Then we can close this and decline this.

Done.

Maintenance_bot removed a project: Patch-For-Review.May 10 2021, 3:10 PM
Bugreporter subscribed.May 10 2021, 10:55 PM

In my opinion this seems something that should be merged to MediaWiki core.

Meno25 unsubscribed.May 12 2021, 2:36 PM
Addshore added a comment.Jun 2 2021, 2:48 PM
In T253764#7076434, @Bugreporter wrote:

In my opinion this seems something that should be merged to MediaWiki core.

This sounds like it would pretty reasonable, but would need buy in from the Platform Engineering team / core owners.

WMDE-leszek subscribed.Jun 3 2021, 7:41 PM
karapayneWMDE subscribed.Jun 7 2021, 3:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL