Page MenuHomePhabricator

[regression-wmf.37] Post-edit dialog display issue
Open, Needs TriagePublicBUG REPORT

Description

Steps to Reproduce:

  1. On betalabs and testwiki wmf.37 go to SE article and make an edit.
  2. After the edit is saved, the post-edit dialog is displayed. The extra white space is present

Compare with

Event Timeline

Restricted Application added a project: Growth-Team. · View Herald TranscriptTue, Jun 16, 7:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Etonkovidova updated the task description. (Show Details)Tue, Jun 16, 7:44 PM

Moving this near the top of Ready for Development.

I think this might be an OOUI regression e.g. see the publish dialog from VE on testwiki (wmf.37) compared with the one on enwiki (wmf.36)

How do you trigger this, or in what what browsers? I have the expected behaviour in VE in both Firefox and Chrome at various different browser window widths.

Oh, this must be a rule we applied too eagerly to all dialog windows. sorry for the confusion!

Change 606171 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Fix help panel sizing logic

https://gerrit.wikimedia.org/r/606171

Change 606171 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix help panel sizing logic

https://gerrit.wikimedia.org/r/606171

Change 606186 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@wmf/1.35.0-wmf.37] Fix help panel sizing logic

https://gerrit.wikimedia.org/r/606186

I will deploy the fix in the next backport window, so this will affect users on Growth wikis with the help panel on (so mostly newbies) for about three hours. During that time, all VE mid-sized dialogs are fixed to 528px height.

Change 606186 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.35.0-wmf.37] Fix help panel sizing logic

https://gerrit.wikimedia.org/r/606186

Mentioned in SAL (#wikimedia-operations) [2020-06-17T14:58:33Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.37/extensions/GrowthExperiments/modules/help/ext.growthExperiments.HelpPanelProcessDialog.js: T255607 Fix help panel sizing logic (duration: 00m 56s)

Now deployed. Does this need the team to do QA?

Thanks, James!

Now deployed. Does this need the team to do QA?

Yeah, but that can happen via the normal process. I'm confident in the fix.

Moving to PM review column - to let to know that the issue is fixed.
Checked in testwiki wmf.37 - looks good: