Fatal exception from FlaggedRevs: "Flagged revision with ID … exists with unexpected fr_page_id"
Open, MediumPublicPRODUCTION ERROR
Actions

Assigned To

None

Authored By

	brennen
	Jun 24 2020, 6:34 PM

Description

Error

MediaWiki version: 1.35.0-wmf.37

message

Exception:
Flagged revision with ID 107684164 exists with unexpected fr_page_id

exception.trace

#0 /srv/mediawiki/php-1.35.0-wmf.37/extensions/FlaggedRevs/business/RevisionReviewForm.php(303): RevisionReviewForm->approveRevision(MediaWiki\Revision\RevisionStoreRecord, NULL)
#1 /srv/mediawiki/php-1.35.0-wmf.37/extensions/FlaggedRevs/business/FRGenericSubmitForm.php(191): RevisionReviewForm->doSubmit()
#2 /srv/mediawiki/php-1.35.0-wmf.37/extensions/FlaggedRevs/frontend/specialpages/actions/RevisionReview.php(116): FRGenericSubmitForm->submit()
#3 /srv/mediawiki/php-1.35.0-wmf.37/includes/specialpage/SpecialPage.php(580): RevisionReview->execute(NULL)
#4 /srv/mediawiki/php-1.35.0-wmf.37/includes/specialpage/SpecialPageFactory.php(634): SpecialPage->run(NULL)
#5 /srv/mediawiki/php-1.35.0-wmf.37/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#6 /srv/mediawiki/php-1.35.0-wmf.37/includes/MediaWiki.php(986): MediaWiki->performRequest()
#7 /srv/mediawiki/php-1.35.0-wmf.37/includes/MediaWiki.php(543): MediaWiki->main()
#8 /srv/mediawiki/php-1.35.0-wmf.37/index.php(47): MediaWiki->run()
#9 /srv/mediawiki/w/index.php(3): require(string)
#10 {main}

Impact

User unable to submit their content review, and getting a generic internal system error page. The page likely remains marked as unreviewed.

Notes

Noticed one of these for wmf.37 in log triage meeting.

Details

Request ID: b1c0e40a-7c71-486f-9ac9-8b34a0053442
Request URL: https://ru.wikipedia.org/w/index.php?title=Служебная:Проверка_версий&action=submit

Related Objects

Mentioned In: T341210: FlaggedRevs ReviewHandlerTest::testWithMinParams fails in EntitySchema CI
T340004: FileImporter extension suite tests fail with UnexpectedValueException from FlaggedRevs
T297189: Schema change for dropping ft_title and ft_namespace
T299711: Exception: Flagged revision with ID 219379998 exists with unexpected fr_page_id
Blog Post: Production Excellence #22: June 2020
Mentioned Here: T299711: Exception: Flagged revision with ID 219379998 exists with unexpected fr_page_id
T246720: Unable to save edit due to "The given Title does not belong to page" error (Wikipedias with FlaggedRevs enabled)

Event Timeline

brennen created this task.Jun 24 2020, 6:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 24 2020, 6:34 PM

brennen moved this task from Backlog to Logs/Train on the User-brennen board.Jun 24 2020, 6:34 PM

Krinkle moved this task from Untriaged to Jun 2020 on the Wikimedia-production-error board.Jun 24 2020, 6:55 PM

Seems related to the code @daniel added as mitigation for T246720

• Pchelolo edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Jun 24 2020, 8:16 PM

BPirkle triaged this task as Medium priority.Jun 24 2020, 8:52 PM

BPirkle moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.

Krinkle renamed this task from Flagged revision with ID [id] exists with unexpected fr_page_id to Fatal exception from FlaggedRevs: "Flagged revision with ID … exists with unexpected fr_page_id".Jul 22 2020, 11:45 PM

Krinkle changed Request URL from https://ru.wikipedia.org/w/index.php?title=%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:%D0%9F%D1%80%D0%BE%D0%B2%D0%B5%D1%80%D0%BA%D0%B0_%D0%B2%D0%B5%D1%80%D1%81%D0%B8%D0%B9&action=submit to https://ru.wikipedia.org/w/index.php?title=Служебная:Проверка_версий&action=submit.

Krinkle updated the task description. (Show Details)

Krinkle edited Stack Trace. (Show Details)

Krinkle mentioned this in Blog Post: Production Excellence #22: June 2020.Jul 23 2020, 3:25 AM

Still seen. message:"exists with unexpected fr_page_id" on mediawiki-errors in Logstash.

Piastu subscribed.Jul 6 2021, 1:23 PM

Same issue on plwiki (ref, 1.37.0-wmf.12): Flagged revision with ID 63918438 exists with unexpected fr_page_id.

Edit: it seems a null edit fixed this. Note the page was previously deleted and recreated a few times due to a history merge.

In T256296#7198951, @PeterBowman wrote:

Same issue on plwiki (ref, 1.37.0-wmf.12): Flagged revision with ID 63918438 exists with unexpected fr_page_id.

Edit: it seems a null edit fixed this. Note the page was previously deleted and recreated a few times due to a history merge.

well, i wasn't completely 'null' — i've changed coma to semicolon; absolutely no changes — i've tried — does not do work.

Umherirrender mentioned this in T299711: Exception: Flagged revision with ID 219379998 exists with unexpected fr_page_id.Jan 21 2022, 4:19 PM

Per T299711, this affects both the GUI (via index.php Special:RevisionReview) and the API (via rest.php).

Currently any case I can find is from rest.php. My guess is that the previous ticket mitigated handling corrupted data in FR but the new functionality added (rest.php replacing the action=ajax) after the patch doesn't have the mitigation in place.

One way to see why we have corrupted data in the first place, another is to just simply drop fr_page_id and rely on revision table for the data (which I think we join with that anyway...), I take a look

While I was looking for this, I realized three columns of flaggedrevs are completely unused (https://gerrit.wikimedia.org/r/757949). I got sidetracked, will work on it a bit now.

Ladsgroup mentioned this in T297189: Schema change for dropping ft_title and ft_namespace.Jan 31 2022, 9:21 AM

Krinkle moved this task from Jun 2020 to Older on the Wikimedia-production-error board.Feb 4 2022, 1:07 AM

Assigning to reflect the above (and to make it easier not to forget via your phab dash).

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptFeb 4 2022, 1:13 AM

Umherirrender unsubscribed.Mar 15 2022, 10:06 PM

WMDE-Fisch mentioned this in T340004: FileImporter extension suite tests fail with UnexpectedValueException from FlaggedRevs.Jun 21 2023, 6:39 AM

thiemowmde mentioned this in T341210: FlaggedRevs ReviewHandlerTest::testWithMinParams fails in EntitySchema CI.Jul 7 2023, 11:39 AM

Krinkle edited projects, added Unstewarded-production-error; removed User-Ladsgroup, Platform Team Workboards (Clinic Duty Team).Aug 18 2023, 7:31 PM

Krinkle removed subscribers: Krinkle, • Pchelolo.

brennen unsubscribed.Sep 11 2023, 7:23 PM

@Ladsgroup: Removing task assignee as this open task has been assigned for more than two years - see the email sent to all task assignees on 2024-04-15.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

Fatal exception from FlaggedRevs: "Flagged revision with ID … exists with unexpected fr_page_id"Open, MediumPublicPRODUCTION ERRORActions