Page MenuHomePhabricator
Create Task
Maniphest T263047

Uncaught TypeError: Cannot read property 'node' of undefined
Closed, ResolvedPublic
Actions

Description

A significant amount of errors mostly on mobile Chrome on Commons and French Wikipedia (this is the most common error in https://logstash.wikimedia.org/goto/fa60de345fb4d22a9c9ae99a607eb91e)
https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.09.16/clienterror/?id=AXSYFS45LNRtRo5XRCmn

at URL1:65:990
at emitLayoutShift  URL1:65:718
at PerformanceObserver.<anonymous>  URL1:66:487

URL1: https://ca.m.wikipedia.org/w/load.php?lang=ca&modules=ext.centralNotice.bannerHistoryLogger%2CchoiceData%2Cdisplay%2CgeoIP%2CimpressionDiet%2ClargeBannerLimit%7Cext.eventLogging%2CnavigationTiming%2CwikimediaEvents%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows%7Cjquery.client%7Cmediawiki.Title%2Capi%2Cbase%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cmobile.init%2Cstartup%7Cmobile.ooui.icons%7Cmobile.placeholder.images%7Cmobile.startup.images%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.indicators%7Cskins.minerva.icons.images.scripts.misc%7Cskins.minerva.icons.page.issues.default.color%7Cskins.minerva.icons.page.issues.medium.color%7Cskins.minerva.icons.page.issues.uncolored%7Cskins.minerva.scripts%7Cuser.defaults%7Cwikibase.client.data-bridge.init&skin=minerva&version=16t48

Details

SubjectRepoBranchLines +/-
Account for empty layout shift sources arraymediawiki/extensions/NavigationTimingmaster+13 -1
Account for empty layout shift sources arraymediawiki/extensions/NavigationTimingwmf/1.36.0-wmf.9+13 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Sep 16 2020, 6:10 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptSep 16 2020, 6:10 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript
Jdlrobson updated the task description. (Show Details)Sep 16 2020, 6:10 PM
Jdlrobson added a project: Regression.EditedSep 16 2020, 6:15 PM

This is a new client-side error that has occurred with the current release relating to T259784. Possibly a deployment blocker?

Jdlrobson added a parent task: T257977: 1.36.0-wmf.9 deployment blockers.Sep 16 2020, 6:17 PM
Jdlrobson updated the task description. (Show Details)
RhinosF1 triaged this task as Unbreak Now! priority.Sep 16 2020, 6:17 PM
RhinosF1 subscribed.

Blocker ---> UBN!

Jdlrobson added a subscriber: • Gilles.Sep 16 2020, 6:18 PM
Krinkle moved this task from Untriaged to Sep 2020 on the Wikimedia-production-error board.Sep 16 2020, 6:26 PM
brennen subscribed.Sep 16 2020, 6:36 PM

Per discussion in log triage meeting, doesn't warrant a rollback but should be fixed before we roll forward to all wikis.

brennen added a project: User-brennen.Sep 16 2020, 6:37 PM
brennen moved this task from Backlog to Logs/Train on the User-brennen board.
Agusbou2015 subscribed.Sep 16 2020, 7:16 PM
• Pablo-WMDE subscribed.Sep 16 2020, 7:17 PM
Umherirrender added a project: JavaScript.Sep 16 2020, 7:21 PM
• Pablo-WMDE added a comment.EditedSep 16 2020, 7:40 PM

It appears (would be happy to be wrong), at least a significant amount of log entries - incl. the one chosen as example - are in fact from Catalan Wikipedia and involve Wikidata-Bridge.

The project recently had https://gerrit.wikimedia.org/r/627238/ merged. A shrinkage of "modern bundle by 7%" could indicate the removal of some polyfills which in turn could cause problems with some older browsers (I'm seeing really old android versions).

Looking into this a bit more.

• Pablo-WMDE added a comment.EditedSep 16 2020, 7:54 PM

https://gerrit.wikimedia.org/r/627798 should be a virtually risk free way (merely undoing to a state we saw in production earlier) to rule out/confirm bridge as the culprit. Will run this with the team first thing tomorrow (not quite German business hours).

WMDE-leszek subscribed.Sep 17 2020, 4:33 AM
• Gilles claimed this task.Sep 17 2020, 7:53 AM
gerritbot added a comment.Sep 17 2020, 8:07 AM

Change 628038 had a related patch set uploaded (by Gilles; owner: Gilles):
[mediawiki/extensions/NavigationTiming@master] Account for empty layout shift sources array

https://gerrit.wikimedia.org/r/628038

gerritbot added a project: Patch-For-Review.Sep 17 2020, 8:07 AM
gerritbot added a comment.Sep 17 2020, 8:11 AM

Change 628039 had a related patch set uploaded (by Gilles; owner: Gilles):
[mediawiki/extensions/NavigationTiming@wmf/1.36.0-wmf.9] Account for empty layout shift sources array

https://gerrit.wikimedia.org/r/628039

gerritbot added a comment.Sep 17 2020, 8:50 AM

Change 628039 merged by jenkins-bot:
[mediawiki/extensions/NavigationTiming@wmf/1.36.0-wmf.9] Account for empty layout shift sources array

https://gerrit.wikimedia.org/r/628039

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 17 2020, 9:00 AM
• Gilles changed the task status from Open to Stalled.Sep 17 2020, 9:08 AM
• Gilles added a subscriber: Krinkle.

I can't deploy the change because of a scap global lock owned by @Krinkle that I can't delete:

08:58:47 sync-file failed: <LockFailedError> Failed to acquire lock "/var/lock/scap-global-lock"; owner is "krinkle"; reason is "no excuse given"

Once the lock is removed by whoever can (I don't have the right linux permissions, it seems), please deploy the backport:

gilles@deploy1001:/srv/mediawiki-staging$ scap sync-file php-1.36.0-wmf.9/extensions/NavigationTiming 'T263047 Account for empty layout shift sources array'
• Pablo-WMDE added a comment.Sep 17 2020, 9:17 AM

https://gerrit.wikimedia.org/r/627798 is now abandoned with a patch for another suspect in deployment.

Lucas_Werkmeister_WMDE subscribed.Sep 17 2020, 9:20 AM
gerritbot added a comment.Sep 17 2020, 9:32 AM

Change 628038 merged by jenkins-bot:
[mediawiki/extensions/NavigationTiming@master] Account for empty layout shift sources array

https://gerrit.wikimedia.org/r/628038

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.10; 2020-09-22); removed MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 17 2020, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 17 2020, 10:10 AM
matthiasmullie subscribed.Sep 17 2020, 11:25 AM
In T263047#6469550, @Gilles wrote:

Once the lock is removed by whoever can (I don't have the right linux permissions, it seems), please deploy the backport:

Done.

Lucas_Werkmeister_WMDE changed the task status from Stalled to Open.Sep 17 2020, 11:26 AM
• Gilles closed this task as Resolved.Sep 17 2020, 11:58 AM

The backported patch fixed the error, as expected:

Screenshot 2020-09-17 at 13.57.51.png (804×2 px, 167 KB)

Krinkle mentioned this in T263599: Uncaught TypeError: Cannot read property 'localName' of null in emitLayoutShift .Sep 28 2020, 6:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits