Page MenuHomePhabricator
Create Task
Maniphest T263340

Fatal InvalidArgumentException "the provided Title object belongs to page" when viewing pages with history broken by Special:MergeHistory
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

On the English Wikipedia, Module:Jct/city/Chinissai had it's entire history merged into another page. Due to T93469, this resulted in a page with no history.

Trying to view such a page results in an InvalidArgumentException:

message
[befd36e9-d82c-44c3-abae-f5a080aa98dc] /wiki/Module:Jct/city/Chinissai   InvalidArgumentException from line 1639 of /srv/mediawiki/php-1.36.0-wmf.9/includes/Revision/RevisionStore.php: Revision 819371998 belongs to page ID 56252475, the provided Title object belongs to page ID 41871839
trace
#0 /srv/mediawiki/php-1.36.0-wmf.9/includes/Revision/RevisionStore.php(2981): MediaWiki\Revision\RevisionStore->ensureRevisionRowMatchesTitle(stdClass, Title, array)
#1 /srv/mediawiki/php-1.36.0-wmf.9/includes/page/WikiPage.php(710): MediaWiki\Revision\RevisionStore->getKnownCurrentRevision(Title, integer)
#2 /srv/mediawiki/php-1.36.0-wmf.9/includes/page/WikiPage.php(747): WikiPage->loadLastEdit()
#3 /srv/mediawiki/php-1.36.0-wmf.9/includes/page/WikiPage.php(602): WikiPage->getRevisionRecord()
#4 /srv/mediawiki/php-1.36.0-wmf.9/includes/libs/objectcache/wancache/WANObjectCache.php(1533): WikiPage->{closure}(boolean, integer, array, NULL, array)
#5 /srv/mediawiki/php-1.36.0-wmf.9/includes/libs/objectcache/wancache/WANObjectCache.php(1376): WANObjectCache->fetchOrRegenerate(string, integer, Closure, array, array)
#6 /srv/mediawiki/php-1.36.0-wmf.9/includes/page/WikiPage.php(615): WANObjectCache->getWithSetCallback(string, integer, Closure)
#7 /srv/mediawiki/php-1.36.0-wmf.9/includes/page/WikiPage.php(275): WikiPage->getContentModel()
#8 /srv/mediawiki/php-1.36.0-wmf.9/includes/page/WikiPage.php(261): WikiPage->getContentHandler()
#9 /srv/mediawiki/php-1.36.0-wmf.9/includes/page/Article.php(2517): WikiPage->getActionOverrides()
#10 /srv/mediawiki/php-1.36.0-wmf.9/includes/actions/Action.php(130): Article->getActionOverrides()
#11 /srv/mediawiki/php-1.36.0-wmf.9/includes/actions/Action.php(189): Action::factory(string, Article, RequestContext)
#12 /srv/mediawiki/php-1.36.0-wmf.9/includes/MediaWiki.php(166): Action::getActionName(RequestContext)
#13 /srv/mediawiki/php-1.36.0-wmf.9/includes/MediaWiki.php(903): MediaWiki->getAction()
#14 /srv/mediawiki/php-1.36.0-wmf.9/includes/MediaWiki.php(543): MediaWiki->main()
#15 /srv/mediawiki/php-1.36.0-wmf.9/index.php(53): MediaWiki->run()
#16 /srv/mediawiki/php-1.36.0-wmf.9/index.php(46): wfIndexMain()
#17 /srv/mediawiki/w/index.php(3): require(string)
#18 {main}

Details

Request ID
befd36e9-d82c-44c3-abae-f5a080aa98dc
Request URL
https://en.wikipedia.org/wiki/Module:Jct/city/Chinissai
SubjectRepoBranchLines +/-
fixMergeHistoryCorruption.php: use DB_REPLICAmediawiki/coremaster+3 -2
Improvements to fixMergeHistoryCorruption.phpmediawiki/coremaster+57 -43
Add maintenance script to delete corrupted pagesmediawiki/coremaster+127 -0
RevisionStore: don't die on mismatching Titlesmediawiki/coremaster+76 -47
Improve handling of content models that do not support redirect.mediawiki/coremaster+185 -49
RevisionStore: better exception when rev belongs to wrong pagemediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Pppery created this task.Sep 19 2020, 9:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2020, 9:51 PM
Daimona added a project: MediaWiki-Core-Revision-backend.Sep 19 2020, 10:44 PM
Daimona updated the task description. (Show Details)
Daimona edited Stack Trace. (Show Details)
Daimona set Phatality ID to e53734155dbec886d8a2aebaf61934b9619d3619fced140fdc3f67e181cd958b.
Ammarpad merged a task: T263359: Viewing certain Lua modules on enwiki results in plain-text InvalidArgumentException.Sep 20 2020, 3:11 PM
Ammarpad added subscribers: AntiCompositeNumber, Primefac.
Primefac added a comment.Sep 20 2020, 3:18 PM

Well... that's a good lesson learned. Should have just G6'd 'em.

Pppery added a comment.EditedSep 20 2020, 3:41 PM

No, you revealed a bug. I'd say that's worth the inconvenience of two extremely backend pages being unviewable. If it hadn't come up now, it would have come up later, most likely with something other than an obscure sandbox.

This bug must be recently introduced, since I was definitely able to view the pages when I nominated them for deletion, and nothing has changed about the pages since.

Tks4Fish subscribed.Sep 20 2020, 3:57 PM
Primefac added a comment.Sep 20 2020, 5:10 PM

Fair point, since clearly I would have noticed it after I merged if it were throwing errors.

Krinkle updated the task description. (Show Details)Sep 22 2020, 4:34 PM
Krinkle edited Stack Trace. (Show Details)
Krinkle updated the task description. (Show Details)
Krinkle added a project: Platform Engineering.Sep 22 2020, 6:31 PM
Krinkle moved this task from Untriaged to Sep 2020 on the Wikimedia-production-error board.
daniel triaged this task as High priority.Sep 22 2020, 8:20 PM
daniel edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.
daniel moved this task from Inbox to Ready (WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.
Ammarpad subscribed.Sep 28 2020, 8:57 AM

This will be temporarily fixed by having Scribunto content model to support redirects, there are some patches on that already. But to fix it once and for all, I can see two options: HistoryMerge needs to recognize these content models and delete the source page if no revision is remaining, since there's nothing more to see. It'll just be like how a move without leaving a redirect is currently treated. Otherwise this exception will always be thrown as these pages have all their revisions living elsewhere after the merge.
The other way is to make it mandatory for every content model to support redirect. That seems radical and may have its own downsides.

gerritbot added a comment.Sep 28 2020, 12:59 PM

Change 630580 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Improve handling of content models that do not supports redirect.

https://gerrit.wikimedia.org/r/630580

gerritbot added a project: Patch-For-Review.Sep 28 2020, 12:59 PM
daniel moved this task from Ready (WIP:5) to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Sep 29 2020, 8:48 PM
Ammarpad edited projects, added MediaWiki-Page-history; removed MediaWiki-Core-Revision-backend.Sep 30 2020, 1:32 AM
Ammarpad edited projects, added MediaWiki-MergeHistory; removed MediaWiki-Page-history.
gerritbot added a comment.Nov 9 2020, 3:55 PM

Change 630580 merged by jenkins-bot:
[mediawiki/core@master] Improve handling of content models that do not support redirect.

https://gerrit.wikimedia.org/r/630580

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.18; 2020-11-17).Nov 9 2020, 4:00 PM
• Clarakosi moved this task from Waiting for Review to Done on the Platform Team Workboards (Clinic Duty Team) board.Nov 9 2020, 4:08 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 9 2020, 4:10 PM
Ammarpad closed this task as Resolved.Nov 10 2020, 1:18 AM
Ammarpad claimed this task.
Pppery reopened this task as Open.Nov 10 2020, 1:38 AM

This is not fixed because viewing https://en.wikipedia.org/wiki/Module:Jct/city/Chinissai still results in an error.

Ammarpad merged a task: T258348: Exception when moving page over a redirect: Revision 29139277 belongs to page ID 2362318, the provided Title object belongs to page ID 721654.Nov 14 2020, 3:49 AM
Ammarpad added subscribers: MGChecker, DannyS712, Schniggendiller.
gerritbot added a comment.Nov 16 2020, 3:54 PM

Change 641198 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Add maintenance script to delete corrupted pages

https://gerrit.wikimedia.org/r/641198

gerritbot added a project: Patch-For-Review.Nov 16 2020, 3:54 PM
Ammarpad moved this task from Done to Inbox on the Platform Team Workboards (Clinic Duty Team) board.Nov 16 2020, 3:58 PM

Moving back to inbox for code review

• AMooney edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Team Workboards (Clinic Duty Team).Nov 17 2020, 2:20 PM
tstarling mentioned this in T268910: Page can't be moved: InvalidArgumentException: Revision belongs to different page ID than Title object.Dec 15 2020, 10:31 PM
• Clarakosi moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (External Code Reviews) board.Dec 18 2020, 9:01 PM
daniel edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Team Workboards (External Code Reviews).Jan 26 2021, 11:50 AM
daniel subscribed.

Moving to code review on the clinic duty board. This is a production error and should be resolved as part of clinic duty.

daniel moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Jan 26 2021, 11:50 AM
gerritbot added a comment.Jan 26 2021, 11:59 AM

Change 658575 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] RevisionStore: better exception when rev belongs to wrong page

https://gerrit.wikimedia.org/r/658575

gerritbot added a comment.Jan 27 2021, 9:41 PM

Change 658575 merged by jenkins-bot:
[mediawiki/core@master] RevisionStore: better exception when rev belongs to wrong page

https://gerrit.wikimedia.org/r/658575

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.29; 2021-02-02); removed MW-1.36-notes (1.36.0-wmf.18; 2020-11-17).Jan 27 2021, 10:00 PM
Krinkle renamed this task from "Fatal Exception of Type InvalidArgumentException" when viewing pages with broken history caused by Special:MergeHistory to Fatal InvalidArgumentException "the provided Title object belongs to page" when viewing pages with history broken by Special:MergeHistory.Apr 1 2021, 1:24 AM
Krinkle mentioned this in T251448: The given Title (XXX) does not belong to page ID during parse, coming from LuaSandbox.Apr 1 2021, 1:41 AM
daniel mentioned this in T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".Apr 15 2021, 9:19 AM
gerritbot added a comment.Apr 28 2021, 9:24 AM

Change 683242 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] RevisionStore: don't die on mismatching Titles

https://gerrit.wikimedia.org/r/683242

gerritbot added a comment.Apr 29 2021, 4:51 PM

Change 683242 merged by jenkins-bot:

[mediawiki/core@master] RevisionStore: don't die on mismatching Titles

https://gerrit.wikimedia.org/r/683242

tstarling mentioned this in T277521: History merge causes data corruption, makes page inaccessible.May 7 2021, 6:57 AM
Izno merged a task: T277521: History merge causes data corruption, makes page inaccessible.May 7 2021, 9:14 AM
Izno added subscribers: Izno, roman-stolar, tstarling, Umherirrender.
tstarling merged a task: T282729: InvalidArgumentException: The revision does not belong to the given page..May 13 2021, 9:22 PM
tstarling added a subscriber: thcipriani.
gerritbot added a comment.May 17 2021, 8:55 PM

Change 641198 merged by jenkins-bot:

[mediawiki/core@master] Add maintenance script to delete corrupted pages

https://gerrit.wikimedia.org/r/641198

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).May 17 2021, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 17 2021, 9:10 PM
daniel mentioned this in T284904: Encountered mismatching Title object (see T259022, T268910, T279832, T263340).Jun 14 2021, 9:56 AM
BPirkle merged a task: T284907: InvalidArgumentException: The revision does not belong to the given page..Jun 22 2021, 9:24 PM
gerritbot added a comment.Jun 29 2021, 1:33 AM

Change 701703 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Improvements to fixMergeHistoryCorruption.php

https://gerrit.wikimedia.org/r/701703

gerritbot added a project: Patch-For-Review.Jun 29 2021, 1:33 AM
gerritbot added a comment.Jun 30 2021, 4:13 AM

Change 701703 merged by jenkins-bot:

[mediawiki/core@master] Improvements to fixMergeHistoryCorruption.php

https://gerrit.wikimedia.org/r/701703

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.14; 2021-07-12); removed MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).Jun 30 2021, 5:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 30 2021, 5:10 AM
gerritbot added a comment.Aug 31 2021, 12:56 AM

Change 715635 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] fixMergeHistoryCorruption.php: use DB_REPLICA

https://gerrit.wikimedia.org/r/715635

gerritbot added a project: Patch-For-Review.Aug 31 2021, 12:56 AM
gerritbot added a comment.Aug 31 2021, 5:09 PM

Change 715635 merged by jenkins-bot:

[mediawiki/core@master] fixMergeHistoryCorruption.php: use DB_REPLICA

https://gerrit.wikimedia.org/r/715635

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.23; 2021-09-13); removed MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Aug 31 2021, 6:00 PM
Umherirrender unsubscribed.Nov 24 2021, 7:46 PM
Zabe removed a project: Patch-For-Review.Jan 16 2022, 7:57 PM
Ammarpad closed this task as Resolved.Feb 24 2022, 11:57 AM
Ammarpad mentioned this in T302486: Run fixMergeHistoryCorruption.php on affected wikis.

This task is resolved. See for T302486 the next step.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL