Page MenuHomePhabricator

Scale: deploy without SuggestedEdits
Open, Needs TriagePublic

Description

Tasks

In order to deploy the Growth features to more wikis, we need to suppress SuggestedEdits module when communities haven't curated the Templates and Help pages.

Newcomers will have the homepage with the mentorship module and the impact module only, like it was before we create SuggestedEdits. This is not an optimal solution, but it would be a first base/placeholder, allowing the deployment of any other module afterwards.

Current state

This is already possible by setting wgGEHomepageSuggestedEditsEnabled to false. However, since we abandoned variant A, there is a big blank space (see fr.wiktionary's homepage).

image.png (800×1 px, 59 KB)

Open questions

How to deal with the big blank space? Move modules a bit to make it look better? Revive variant A? Something else? See T273837: When wgGEHomepageSuggestedEditsEnabled is false, homepage has a big blank space.

Suggested edits require MediaWiki:NewcomerTasks.json to be defined. Right now, this file is pre-populated by a Growth-Team member (right now, only @Tgr has required permisssions). See T274009: Scaling: Open question: How should we deal with on-wiki configuration for dozens of wikis?.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Trizek-WMF Should the description say "we need to suppress the suggested edits module when"?

@Trizek-WMF Should the description say "we need to suppress the suggested edits module when"?

Correct! Thank you for spotting my bad copy/pasting. :)

This is already possible, but with a questionmark. See how it works in fr.wiktionary (ignore my dark mode):

image.png (800×1 px, 59 KB)

Since we abandoned variant A and decided to make suggested edits the center of our feature, there is a really big blank space. As @RHo pointed out in Slack, it looks like a bug rather than a feature.

I'm unsure what to do with this task. It's resolved, as it is possible to deploy w/o SE, but also needs more work, as this is just ugly.

This task implies to have a way to deploy without SE with a decent design. Hence fixing the blank page effect.

kostajh added a subscriber: kostajh.

@Urbanecm_WMF I think we do deploy without suggested edits in some cases? So I think we could mark this as resolved.

@Urbanecm_WMF I think we do deploy without suggested edits in some cases? So I think we could mark this as resolved.

The default is to have the module without any tasks in it. It is possible to select topics, but all checkboxes for tasks are greyed.

We will soon deploy Add a link to all Wikipedias, meaning that they will have at least one suggested edit. But we might have other wikis asking for our features, and as our existing tools don't necessary scale to them, we should keep an option to remove Suggested edits from the Homepage.

@Urbanecm_WMF I think we do deploy without suggested edits in some cases? So I think we could mark this as resolved.

Indeed. frwiktionary is a wiki that has SE disabled, and it looks much better now than on the screenshots in this task's history:

image.png (830×1 px, 109 KB)

But we might have other wikis asking for our features, and as our existing tools don't necessary scale to them, we should keep an option to remove Suggested edits from the Homepage.

We have that option -- albeit only in the server configuration (as wgGEHomepageSuggestedEditsEnabled). Should we move it to community configuration instead?

Suggested edits are the core component of our features. Therefore, it is our responsibility to enable or disable it on a case by case basis, depending on the configuration of the wiki.

And I hope we will have some Suggested Edits for other wikis soon.

mewoph added a subscriber: mewoph.

Hi @Trizek-WMF given the current improved experience without suggested edits, can this task be closed or should we still keep it for further enhancements to the experience and/or configuration mechanisms?

IMO what's missing here is automatically disabling suggested edits if the wiki has zero configured task types.