@Trizek-WMF Should the description say "we need to suppress the suggested edits module when"?

In T270300#6697383, @Urbanecm_WMF wrote:

@Trizek-WMF Should the description say "we need to suppress the suggested edits module when"?

Correct! Thank you for spotting my bad copy/pasting. :)

This is already possible, but with a questionmark. See how it works in fr.wiktionary (ignore my dark mode):

Since we abandoned variant A and decided to make suggested edits the center of our feature, there is a really big blank space. As @RHo pointed out in Slack, it looks like a bug rather than a feature.

I'm unsure what to do with this task. It's resolved, as it is possible to deploy w/o SE, but also needs more work, as this is just ugly.

This task implies to have a way to deploy without SE with a decent design. Hence fixing the blank page effect.

@Urbanecm_WMF I think we do deploy without suggested edits in some cases? So I think we could mark this as resolved.

In T270300#7835251, @kostajh wrote:

@Urbanecm_WMF I think we do deploy without suggested edits in some cases? So I think we could mark this as resolved.

The default is to have the module without any tasks in it. It is possible to select topics, but all checkboxes for tasks are greyed.

We will soon deploy Add a link to all Wikipedias, meaning that they will have at least one suggested edit. But we might have other wikis asking for our features, and as our existing tools don't necessary scale to them, we should keep an option to remove Suggested edits from the Homepage.

In T270300#7835251, @kostajh wrote:

@Urbanecm_WMF I think we do deploy without suggested edits in some cases? So I think we could mark this as resolved.

Indeed. frwiktionary is a wiki that has SE disabled, and it looks much better now than on the screenshots in this task's history:

But we might have other wikis asking for our features, and as our existing tools don't necessary scale to them, we should keep an option to remove Suggested edits from the Homepage.

We have that option -- albeit only in the server configuration (as wgGEHomepageSuggestedEditsEnabled). Should we move it to community configuration instead?

Suggested edits are the core component of our features. Therefore, it is our responsibility to enable or disable it on a case by case basis, depending on the configuration of the wiki.

And I hope we will have some Suggested Edits for other wikis soon.

Hi @Trizek-WMF given the current improved experience without suggested edits, can this task be closed or should we still keep it for further enhancements to the experience and/or configuration mechanisms?

IMO what's missing here is automatically disabling suggested edits if the wiki has zero configured task types.