When wgGEHomepageSuggestedEditsEnabled is false, homepage has a big blank space
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Urbanecm_WMF
	Feb 4 2021, 1:56 AM

Description

As we decided to make Suggested Edits the center of our features, they are rendered in a prominent space of the homepage. When suggested edits are disabled, it looks like this:

(fr.wiktionary)

If we want to deploy our features to other wikis in this configuration, we probably want to improve the look of the homepage in this scenario.

Open questions

How should we deal with suggested edits disabled? Revive variant A? Move modules a bit to make it look better? Something else?

Proposed design

As this is a very exceptional case, I would move the impact module to the place where the Suggested edits module would be.

I think this is best as it would also cover the situation when some wikis also have the mentor module turned off:

Details

	Subject	Repo	Branch	Lines +/-
	Homepage: move impact module to main group when suggested edits is disabled	mediawiki/extensions/GrowthExperiments	master	+7 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Trizek-WMF	T246939 [Growth scaling] streamlined configuration
Open	None	T304052 Enable Growth features on Wikipedias upon creation
Resolved	Urbanecm_WMF	T270300 Scale: deploy without SuggestedEdits
Resolved	• mewoph	T273837 When wgGEHomepageSuggestedEditsEnabled is false, homepage has a big blank space

Event Timeline

Urbanecm_WMF created this task.Feb 4 2021, 1:56 AM

Urbanecm_WMF mentioned this in T270300: Scale: deploy without SuggestedEdits.

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM

MMiller_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team-Filtering, Growth-Team.Sep 21 2021, 2:16 AM

MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

MMiller_WMF triaged this task as High priority.Sep 21 2021, 2:20 AM

Hi @MMiller_WMF @RHo — I'm moving this to Needs Design since the expected behavior is still TBD.

Tgr mentioned this in T290441: Think about Growth features being used by Wikisource.Sep 28 2021, 2:01 AM

Urbanecm_WMF mentioned this in T290582: Deploy Growth features to all remaining active versions of Wikipedia.Sep 30 2021, 8:00 PM

There are 27 of such errors in GrowthExperiments logstash channel during last 24 hours from Nov 1, 2021 @ 22:34:03.569

Screen Shot 2021-11-01 at 3.33.30 PM.png (1×1 px, 208 KB)

mwversion: 1.38.0-wmf.6
reqId: a33484b2-9de8-40ed-9420-4999620c38c8
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

The configuration title does not exist.

exception.trace

from /srv/mediawiki/php-1.38.0-wmf.6/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSuggester/TaskSuggesterFactory.php(28)
#0 /srv/mediawiki/php-1.38.0-wmf.6/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSuggester/LocalSearchTaskSuggesterFactory.php(55): GrowthExperiments\NewcomerTasks\TaskSuggester\TaskSuggesterFactory->createError(StatusValue)
#1 /srv/mediawiki/php-1.38.0-wmf.6/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSuggester/DecoratingTaskSuggesterFactory.php(53): GrowthExperiments\NewcomerTasks\TaskSuggester\LocalSearchTaskSuggesterFactory->create()
#2 /srv/mediawiki/php-1.38.0-wmf.6/extensions/GrowthExperiments/includes/HomepageHooks.php(724): GrowthExperiments\NewcomerTasks\TaskSuggester\DecoratingTaskSuggesterFactory->create()
#3 /srv/mediawiki/php-1.38.0-wmf.6/includes/deferred/MWCallableUpdate.php(38): GrowthExperiments\HomepageHooks->GrowthExperiments\{closure}()
#4 /srv/mediawiki/php-1.38.0-wmf.6/includes/deferred/DeferredUpdates.php(515): MWCallableUpdate->doUpdate()
#5 /srv/mediawiki/php-1.38.0-wmf.6/includes/deferred/DeferredUpdates.php(391): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#6 /srv/mediawiki/php-1.38.0-wmf.6/includes/deferred/DeferredUpdates.php(221): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, string)
#7 /srv/mediawiki/php-1.38.0-wmf.6/includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(MWCallableUpdate, integer)
#8 /srv/mediawiki/php-1.38.0-wmf.6/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#9 /srv/mediawiki/php-1.38.0-wmf.6/includes/deferred/DeferredUpdates.php(242): DeferredUpdatesScope->processUpdates(integer, Closure)
#10 /srv/mediawiki/php-1.38.0-wmf.6/includes/MediaWiki.php(1136): DeferredUpdates::doUpdates()
#11 /srv/mediawiki/php-1.38.0-wmf.6/includes/MediaWiki.php(846): MediaWiki->restInPeace()
#12 /srv/mediawiki/php-1.38.0-wmf.6/includes/MediaWiki.php(584): MediaWiki->doPostOutputShutdown()
#13 /srv/mediawiki/php-1.38.0-wmf.6/index.php(53): MediaWiki->run()
#14 /srv/mediawiki/php-1.38.0-wmf.6/index.php(46): wfIndexMain()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}

RHo updated the task description. (Show Details)Nov 2 2021, 11:42 AM

I think what @Etonkovidova mentioned is a different bug: on some wikis, the NewcomerTasks.json configuration file is not present at all, and this is what happens in that case. I think that should be discussed (and ideally, fixed) as part of another task.

RHo lowered the priority of this task from High to Low.Feb 8 2022, 1:14 PM

RHo moved this task from Needs Design/Design Doing to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

Hi @RHo, when the user hasn't made any edits, currently the unactivated state of the impact module with the heart graphic makes a reference to suggested edits in the copy (and on mobile there is a link to open the suggested edits module). Should we still show the unactivated state with a different copy or just use the default state of the impact module?

Screen Shot 2022-02-14 at 3.37.54 PM.png (412×980 px, 50 KB)

In T273837#7709738, @mewoph wrote:

Hi @RHo, when the user hasn't made any edits, currently the unactivated state of the impact module with the heart graphic makes a reference to suggested edits in the copy (and on mobile there is a link to open the suggested edits module). Should we still show the unactivated state with a different copy or just use the default state of the impact module?

Ack. Yes let's use the default state since I would prefer not to introduce another variation of the unactivated state for this edge case.

• mewoph claimed this task.Feb 15 2022, 6:44 PM

• mewoph moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 762927 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Homepage: move impact module to main group when suggested edits is disabled

https://gerrit.wikimedia.org/r/762927

gerritbot added a project: Patch-For-Review.Feb 15 2022, 6:52 PM

Special:Homepage when GEHomepageSuggestedEditsEnabled is false

Screen Shot 2022-02-15 at 10.50.25 AM.png (2×2 px, 856 KB)

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 16 2022, 5:24 PM

Change 762927 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Homepage: move impact module to main group when suggested edits is disabled

https://gerrit.wikimedia.org/r/762927

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).Feb 16 2022, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 16 2022, 6:11 PM

Checked on frwiktionary wmf.23:

Screen Shot 2022-02-25 at 3.16.43 PM.png (1×2 px, 262 KB)

	F34966830: Screen Shot 2022-02-25 at 3.16.43 PM.png
	Feb 25 2022, 11:19 PM

	F34952632: Screen Shot 2022-02-15 at 10.50.25 AM.png
	Feb 15 2022, 6:53 PM

	F34951818: Screen Shot 2022-02-14 at 3.37.54 PM.png
	Feb 14 2022, 11:40 PM

	F34723054: Screen Shot 2021-11-01 at 3.33.30 PM.png
	Nov 1 2021, 11:09 PM

When wgGEHomepageSuggestedEditsEnabled is false, homepage has a big blank spaceClosed, ResolvedPublicActions