Page MenuHomePhabricator

Implement edit notice logic
Open, Needs TriagePublic

Description

This task is about deciding on and implementing the logic that will determine what edit notices [i] are not shown within the New Discussion Tool.

Background

Currently, when people edit talk pages, they will often see messages above the edit window and section=new form that contain guidance about how to edit the talk page (e.g. "follow the guidelines and sign your posts") and information to keep in mind when editing talk pages (e.g. "your IP address will be published along with the edit you are making").

The New Discussion Tool makes some of these messages obsolete [ii] and others redundant. [iii] This task is about deciding on and implementing the logic that makes it so the New Discussion Tool does not show obsolete and redundant messages.

Possible edit notices

This section will contain the list of all possible edit notices that could appear within the New Discussion Tool were the logic this ticket is asking for is not implemented.

Requirements

The following types of edit notices should not appear within the New Discussion Tool:

  • Edit notices that contain obsolete information (e.g. Talkpagetext as @matmarex first suggested in T269033#6696031)
  • Edit notices that contain information the New Discussion Tool displays "natively" (e.g. anoneditwarning as @Esanders noted in T269310#6698758).

Open questions

  • What logic should determine the edit notices that are not shown within the New Discussion Tool?

Done

  • All ===Open questions are answered
  • Document the list of all possible edit notices that could appear within the New Discussion Tool were the logic this ticket is asking for is not implemented
  • Define and implement the logic needed to fulfill the the ===Requirements listed above

i. https://www.mediawiki.org/wiki/Manual:Interface/Edit_notice
ii. The New Discussion Tool makes the message that instructs people to sign the topics they are adding because the tool does this for people automatically
iii. The New New Discussion Tool displays a warning to people who are using it while logged out informing them their IP address will be published with the topic they are drafting.

Event Timeline

What logic should determine the edit notices that are not shown within the New Discussion Tool?

I think this task's description already covers everything. We shouldn't display 'talkpagetext' and 'anoneditwarning', everything else is fine. Most pages have no notices anyway.

It appears that talkpagetext is not included in the VE edit notices API (which the tool would use) so is not currently an issue. Clearly we never bothered to add it because VE is not supposed to be used on talk pages.

This just leaves anoneditwarning to be excluded.

I think this task is done, and further work to make edit notices appear in DiscussionTools would happen in T269033.

Open questions

  • What logic should determine the edit notices that are not shown within the New Discussion Tool?

Answered above – we only need to exclude 'anoneditwarning'. (edit: …and 'talkpagetext' is already excluded)

Done

  • All ===Open questions are answered
  • Document the list of all possible edit notices that could appear within the New Discussion Tool were the logic this ticket is asking for is not implemented

That would be all edit notices that appear in the wikitext editor. (It's impossible to provide an exact list, since each page can have a custom edit notice.)

  • Define and implement the logic needed to fulfill the the ===Requirements listed above

Done in T272188