Page MenuHomePhabricator
Create Task
Maniphest T272302

Preference "Allow emails from brand-new users" can be changed locally even when global and with "set a local exception" off
Closed, ResolvedPublic
Actions

Description

I am not sure if this is a bug that everyone will encounter, or it is a deliberate design. I am putting it here.

Steps to reproduce:

  1. Go to your preference page and go to your global preference
  2. Mark this specific option as global: "Allow emails from brand-new users"
  3. Close your webpage, and go to your preference page again
  4. Normally, when an option is marked as global, you can't change it anymore unless you checked "Set a local exception for this global preference". But for this particular option, you can change it.

Screen Shot 2021-01-18 at 10.16.03 PM.png (898×1 px, 165 KB)

Details

SubjectRepoBranchLines +/-
Add support for conditional disable fields in HTMLFormmediawiki/coremaster+121 -86
Use native method to disable checkboxes conditionallymediawiki/extensions/GlobalPreferencesmaster+20 -86
Use native method to disable new users checkbox in Special:Preferencesmediawiki/coremaster+1 -27
Customize query in gerrit

Related Objects

Event Timeline

MilkyDefer created this task.Jan 18 2021, 2:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2021, 2:16 PM
Aklapper renamed this task from Even if set as global and not checking "set a local exception", a certain preference can still be changed to Even if set as global and not checking "set a local exception", "Allow emails from brand-new users" preference can still be locally changed.Jan 18 2021, 5:27 PM
Aklapper added a project: MediaWiki-extensions-GlobalPreferences.
Restricted Application added a project: Community-Tech. · View Herald TranscriptJan 18 2021, 5:27 PM
Func subscribed.EditedApr 21 2021, 3:28 PM

I will test this after patch of T279256 get deployed.

gerritbot added a comment.Apr 24 2021, 4:08 AM

Change 682214 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] Hide new users checkbox of Special:Preference instead of disable it

https://gerrit.wikimedia.org/r/682214

gerritbot added a project: Patch-For-Review.Apr 24 2021, 4:08 AM
gerritbot added a comment.Apr 25 2021, 3:25 PM

Change 682303 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] Add support for conditional disable fields in HTMLForm

https://gerrit.wikimedia.org/r/682303

gerritbot added a comment.Apr 28 2021, 3:37 PM

Change 683142 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/GlobalPreferences@master] Use native method to disable new users checkbox

https://gerrit.wikimedia.org/r/683142

• NRodriguez closed this task as a duplicate of T286271: Globally set preferences no longer greyed out in local preferences.Oct 25 2021, 3:34 PM
Func reopened this task as Open.Nov 23 2021, 3:17 PM

Shouldn't merge into T286271, this is another bug.

Func merged a task: T274482: Email-allow-new-users-label checkbox should not be available but is switchable.Nov 23 2021, 3:19 PM
Func added subscribers: YFdyh000, Samwilson.
gerritbot added a comment.Nov 23 2021, 3:20 PM

Change 682214 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] Use native method to disable new users checkbox in Special:Preferences

https://gerrit.wikimedia.org/r/682214

gerritbot added a comment.Nov 23 2021, 3:21 PM

Change 682303 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] Add support for conditional disable fields in HTMLForm

https://gerrit.wikimedia.org/r/682303

gerritbot added a comment.Nov 23 2021, 3:21 PM

Change 683142 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/GlobalPreferences@master] Use native method to disable checkboxes conditionally

https://gerrit.wikimedia.org/r/683142

gerritbot added a comment.Dec 1 2021, 2:54 AM

Change 683142 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/GlobalPreferences@master] Use native method to disable checkboxes conditionally

https://gerrit.wikimedia.org/r/683142

MusikAnimal mentioned this in T286271: Globally set preferences no longer greyed out in local preferences.Dec 1 2021, 10:51 PM
Func mentioned this in T296151: Dependent user options might be incorrectly set if parent option disabled.Dec 2 2021, 12:07 PM
• NRodriguez edited projects, added Community-Tech (CommTech-Sprint-15); removed Community-Tech.Dec 2 2021, 6:22 PM
• NRodriguez moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-15) board.
MusikAnimal mentioned this in T296924: When you set the local exception for an option the label text still appears disabled.Dec 3 2021, 12:53 AM
thiemowmde mentioned this in T297370: OOJS-UI failure from GlobalPreferences code on live enwiki.Dec 9 2021, 12:37 PM
matmarex subscribed.Dec 9 2021, 4:23 PM
dom_walden subscribed.Dec 10 2021, 3:28 PM

QA Notes:
You can follow the reproduction steps in the description, and test on beta.

Where it says "your preference page" it is referring to https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences.

Where it says "global preference" it is referring to https://en.wikipedia.beta.wmflabs.org/wiki/Special:GlobalPreferences.

gerritbot added a comment.Dec 13 2021, 10:50 PM

Change 682303 merged by jenkins-bot:

[mediawiki/core@master] Add support for conditional disable fields in HTMLForm

https://gerrit.wikimedia.org/r/682303

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.13; 2021-12-13).Dec 13 2021, 11:00 PM
gerritbot added a comment.Dec 13 2021, 11:44 PM

Change 682214 merged by jenkins-bot:

[mediawiki/core@master] Use native method to disable new users checkbox in Special:Preferences

https://gerrit.wikimedia.org/r/682214

Krinkle renamed this task from Even if set as global and not checking "set a local exception", "Allow emails from brand-new users" preference can still be locally changed to Preference "Allow emails from brand-new users" can be changed locally even when global and with "set a local exception" off.Dec 14 2021, 12:30 AM
gerritbot added a comment.Dec 14 2021, 12:58 AM

Change 683142 merged by jenkins-bot:

[mediawiki/extensions/GlobalPreferences@master] Use native method to disable checkboxes conditionally

https://gerrit.wikimedia.org/r/683142

MusikAnimal moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-15) board.Dec 14 2021, 1:40 AM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-16); removed Community-Tech (CommTech-Sprint-15).Jan 4 2022, 5:08 PM
ldelench_wmf moved this task from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-16) board.Jan 4 2022, 5:11 PM
dom_walden moved this task from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-16) board.Jan 6 2022, 11:32 AM

On https://test.wikipedia.org I enabled all user options as global.

In Special:Preferences, all the options I had made global were disabled (with the exception of the Beta features, see T298680).

However:

  • I only tested one wiki. Each wiki has a slightly different set of user options. It is possible that there are bugs in other user options which I did not test.
  • I only tested on one browser (Firefox).
  • GlobalPreferences can be quite buggy. I would not bet against there being other bugs I have missed.

Test environment: https://test.wikipedia.org/ GlobalPreferences 0.1.2 (c91eb42) 15:24, 9 December 2021.
Test browser: Firefox 78

Func merged a task: T296151: Dependent user options might be incorrectly set if parent option disabled.Jan 8 2022, 4:00 PM
Func claimed this task.Jan 12 2022, 7:34 AM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-17); removed Community-Tech (CommTech-Sprint-16).Jan 18 2022, 8:13 PM
ldelench_wmf moved this task from Ready 🎬 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-17) board.Jan 18 2022, 8:23 PM
Func removed a project: Patch-For-Review.Jan 19 2022, 1:07 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-18); removed Community-Tech (CommTech-Sprint-17).Jan 31 2022, 2:33 PM
ldelench_wmf moved this task from Ready 🎬 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-18) board.Jan 31 2022, 2:34 PM
• NRodriguez closed this task as Resolved.Feb 4 2022, 3:47 PM
• JMcLeod_WMF moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-18) board.Feb 15 2022, 10:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL