Page MenuHomePhabricator

[Search] Lighten color of search thumbnail placeholder icon
Open, MediumPublic

Description

Description

Currently the image icon is Base20/#54595D, which is taking a bit too much attention. It should be changed to Base30/#72777D .

currentcorrect
Screen Shot 2021-07-17 at 3.39.29 PM.png (635×530 px, 78 KB)
Screen Shot 2021-07-17 at 3.39.16 PM.png (636×532 px, 78 KB)

Event Timeline

alexhollender_WMF renamed this task from Lighten color of search thumbnail placeholder icon to [Search] Lighten color of search thumbnail placeholder icon.Jul 19 2021, 3:19 PM

With that the icon isn't aligned to color contrast reqs anymore? Does it have too? This is borderline, some folks might not decipher the icon solely on contrast anymore, but it is the reason we've set Base20 on grey background.

With that the icon isn't aligned to color contrast reqs anymore? Does it have too? This is borderline, some folks might not decipher the icon solely on contrast anymore, but it is the reason we've set Base20 on grey background.

I thought that for [[ https://www.w3.org/WAI/WCAG21/Techniques/general/G207 | icons it is at the lower threshold of 3:1 ]]would be met by using Base30 on Base 90. Having said that, I also don't feel like this falls within the scope of the definition of graphical object requiring contrast, and consider it to be a "sensory" non-text content type (defined here).

Presumably needs to happen in WVUI

@RHo Thanks for the nudge. I was there (at the 3:1 icon contrast ratio recommendation by WCAG 2.1) in the past, my comment was only in the context of other changes at the same time, being overly sensitive.

Please note that the patch is only changing color of the thumbnail placeholder and not of the footer icon as outlined in the task description.

Change 723706 had a related patch set uploaded (by VolkerE; author: VolkerE):

[wvui@master] [typeahead-search-suggestion][styles] Lighten thumbnail placeholder icon

https://gerrit.wikimedia.org/r/723706

Change 723706 merged by jenkins-bot:

[wvui@master] [typeahead-search-suggestion][styles] Lighten thumbnail placeholder icon

https://gerrit.wikimedia.org/r/723706

Yes. Olga do you want to prioritize this work?

my apologies for any confusion — I wasn't suggesting we prioritize it, I saw the patch and thought maybe the word had already been done.

Ah understood, this might have been resolved a long time ago then (in September). Are you seeing the lightened icon in Vector or is there still work to be done here?

Ah understood, this might have been resolved a long time ago then (in September). Are you seeing the lightened icon in Vector or is there still work to be done here?

I'm not seeing the correct color in Vector. If the work hasn't already been done I'm fine leaving this for later on when we're wrapping things up.

@Jdlrobson - are we still planning on the next technical goal to be around search? We could add this as one of the tasks for that