Page MenuHomePhabricator
Create Task
Maniphest T289084

MinervaNeue shows 2 search elements when JS is disabled
Closed, DeclinedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
https://jmp.sh/vPMAxxq

What should have happened instead?:
The search icon should not be present on mobile at higher screen sizes. It should only appear at a lower breakpoint when the search bar collapses.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
English wiki prod, reproduced in Safari and Chrome

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclinedBUG REPORTJdlrobsonT289084 MinervaNeue shows 2 search elements when JS is disabled
 OpenNoneT282473 [GOAL] Use the Codex search widget inside the mobile site
 ResolvedJdlrobsonT275251 New Vector Search is not Wikidata aware
 ResolvedLucas_Werkmeister_WMDET316093 Make new Vector search use wbsearchentities on Wikidata
 DuplicateNoneT317681 Make new Vector search navigate to item search results on Wikidata
 ResolvedLucas_Werkmeister_WMDET317682 Make new Vector search navigate to search result URL when selecting search result using keyboard
 ResolvedMichaelT322333 Modify new Vector Search to allow loading more results on Wikidata
 ResolvedMichaelT326633 Monitor the deployment of the new Search on the 2022 version of the Vector skin
 OpenNoneT275252 Codex Typeahead search should be adapted for mobile (Vector and Minerva)
 ResolvedAnneTT283188 TypeaheadSearch defaults to English Wikipedia for "domain" options
 OpenNoneT211006 Add red link experience to empty search results for Codex/mobile
 ResolvedVolker_ET217790 Add 'articleAdd' icon to OOUI
 OpenNoneT216743 Page disappears when searching on tablet/desktop
 OpenNoneT143741 Search failures are not handled well by Codex TypeaheadSearch and MobileFrontend search
 DeclinedNoneT279072 MobileFrontend search bar dropdown suggestions link directly to pages
 OpenNoneT221194 Search input of overlay is not tab-able, inaccessible by alternative input users
 OpenNoneT278283 Clicking back in the search box should reactivate the suggestions
 OpenNoneT221124 Entire search result element should be clickable (PageList component)
 StalledNoneT285223 Show item description in the Wikidata search results in MinervaNeue skin
 StalledNoneT285356 [tablet/desktop] Minerva search bar blurs text and moves/shrinks slightly when focussed
 ResolvedAnneTT286851 [Search] Lighten color of search thumbnail placeholder icon
 ResolvedStevenSunT286922 Add message for no results in TypeaheadSearch
 DeclinedJdrewniakT286729 Improve tabbing functionality for new search component
 ResolvedovasilevaT279674 Use of dir=auto in WVUI breaks search interface is broken in wikis mixing LTR and RTL languages
 DuplicateBUG REPORTNoneT287770 [Bug] Codex TypeaheadSearch component does not scale well with small font size user preference
 ResolvedCatropeT288686 WVUI's TypeaheadSearch should work with a non-default `$wgScriptPath`
 ResolvedovasilevaT308288 Implement search token clickthrough tracking on autocomplete for mobile web
 ResolvedBUG REPORTEdtadrosT309795 Autocomplete highlighting should ignore trailing space inserted by Android keyboard autocomplete
 ResolvedBUG REPORTovasilevaT317902 [Unplanned][Regression] Codex TypeaheadSearch intermediate state misaligned on mobile resolutions
 In ProgressNoneT303013 Indicate when search results are from redirects (sometimes)
 Resolved• EUdoh-WMFT323987 Add supporting text in MenuItem component

Event Timeline

bwang created this task.Aug 17 2021, 9:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2021, 9:10 PM
Jdlrobson added a project: Web-Team-Backlog (Needs Prioritization (Tech)).Aug 18 2021, 3:31 PM
Jdlrobson moved this task from Backlog to Using Codex in web team products / Skin unification on the Web-Team-Backlog (Needs Prioritization (Tech)) board.
Jdlrobson changed the task status from Open to Stalled.Aug 18 2021, 3:33 PM
Jdlrobson subscribed.

I believe this is by design. The second search icon is for triggering the search (it's not obvious to all users that hitting enter will trigger a search). In WVUI we don't show a search icon for triggering search we have a button that says "Search"/

Note, it makes little sense for us to improve the search feature until we've consolidated the desktop and mobile experiences as part of T282473 so this will likely remain like this until that happens.

Jdlrobson moved this task from Using Codex in web team products / Skin unification to WVUI migrations on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Aug 26 2021, 6:30 PM
Jdlrobson moved this task from WVUI migrations to Unused on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Nov 1 2021, 10:29 PM
Jdlrobson triaged this task as Low priority.Dec 9 2021, 7:43 PM
Jdlrobson moved this task from Unused to Using Codex in web team products / Skin unification on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Dec 21 2021, 5:29 PM
Aklapper renamed this task from MinerveNeue shows 2 search elements when JS is disabled to MinervaNeue shows 2 search elements when JS is disabled.Mar 1 2022, 6:07 AM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptMar 1 2022, 6:07 AM
Aklapper added a subtask: T282473: [GOAL] Use the Codex search widget inside the mobile site.Mar 1 2022, 6:08 AM
Jdlrobson moved this task from Using Codex in web team products / Skin unification to Codex focus on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Apr 28 2022, 10:05 PM
Jdlrobson moved this task from Codex focus to Using Codex in web team products / Skin unification on the Web-Team-Backlog (Needs Prioritization (Tech)) board.
Jdlrobson raised the priority of this task from Low to Needs Triage.Dec 8 2023, 9:48 PM
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Needs Prioritization (Tech)).
Jdlrobson changed the task status from Stalled to Open.Dec 19 2023, 5:51 PM
Jdlrobson moved this task from Incoming to FY2023-24 Q3 Sprint 2 on the Web-Team-Backlog board.
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 2); removed Web-Team-Backlog.
ovasileva claimed this task.Jan 11 2024, 6:40 PM
ovasileva triaged this task as Medium priority.Jan 29 2024, 3:43 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 3); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 2).Jan 29 2024, 7:02 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 4); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 3).Feb 1 2024, 7:25 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 5); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 4).Feb 26 2024, 7:04 PM
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (FY2023-24 Q3 Sprint 5).Mar 11 2024, 7:10 PM
Jdlrobson claimed this task.Wed, May 29, 7:25 PM
Jdlrobson added a subscriber: ovasileva.
Jdlrobson closed this task as Declined.Thu, May 30, 1:18 AM
Jdlrobson moved this task from Incoming to Holding area (temporary) on the Web-Team-Backlog board.

Following https://phabricator.wikimedia.org/T289084#7291937 I would like to suggest declining this.

Both the input and search icon is functional it provides a path to the Special:Search page with or without a search query.

Screenshot_20240529_181447_Chrome.jpg (2×1 px, 1017 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits