(wrong task, moved to T290045)

Moving back to In Progress to update registrations & hook up new Add Image classes

Change 720084 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an Image: Suggestions mode

https://gerrit.wikimedia.org/r/720084

With the current patch, the editing surface should be updated as per the task description and edit mode toggle should be working. Image inspector is not yet shown (this will be done in T290045: Add an image: image inspector).

Note: There will be console errors SuggestionInteractionLogger.log called before logger instance is set. This is expected until instrumentation is implemented for Add Image.

Mobile:

Desktop:

The escape key is not working so it's impossible to exit the editor (on desktop; on mobile there's a cancel button). That's expected and we can handle it in the dialog; just making a note so it does not get forgotten.

Change 720084 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an Image: Suggestions mode

https://gerrit.wikimedia.org/r/720084

Change 720493 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Add Image: Do not show edit button dot

https://gerrit.wikimedia.org/r/720493

Change 720493 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add Image: Do not show edit button dot

https://gerrit.wikimedia.org/r/720493

Thanks @Tgr — I added escape handling to the task description in T290045: Add an image: image inspector

I just updated the task with the decisions and mockups from the team deep dive on 2021-09-28.

@mewoph -- @RHo just made a change to the task description, saying that we want to show the article title at the top, even though that's not what happens by default in VE.

This is the desired experience:

But this is what we currently see in beta:

@mewoph -- is this possible to add? Is it challenging?

Hi @MMiller_WMF @RHo it should be fairly straightforward to add the title after the editor loads like so:

Would this be acceptable? I think it would be more complicated to show the title during the loading state since currently our code isn't called until later on.

Should the title be at 50% opacity like on desktop or should we keep the same default text color (which then changes during caption step)?

In T289829#7462315, @mewoph wrote:

Hi @MMiller_WMF @RHo it should be fairly straightforward to add the title after the editor loads like so:

Would this be acceptable? I think it would be more complicated to show the title during the loading state since currently our code isn't called until later on.

Thanks sharing this screencast @mewoph. Is it expected that the page will load in read mode first and then switch to the editor mode, or could we immediately load the page in edit state like in the user testing prototype?
If not, my feeling is that this is not ideal but acceptable for Iteration 1 of images. However, per @MMiller_WMF's question about whether we'd want to add this for the structured link task, I don't think we should if it is added is after the editor loads like shown above.

Should the title be at 50% opacity like on desktop or should we keep the same default text color (which then changes during caption step)?

The title should be 100% opacity, thanks.

The editor will be loaded automatically (the user doesn't have to click on the edit icon), but there will still be some time between when the page is rendered and when the editor loads. Here's the corresponding task from add link: T280991: Add a link: open the article in edit mode right away.

Change 735423 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: add article title to the document during suggestions mode (mobile)

https://gerrit.wikimedia.org/r/735423

Moving back to Code Review for additional changes to add the article title

Change 735423 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: add article title to the document during suggestions mode (mobile)

https://gerrit.wikimedia.org/r/735423

Checked in betalabs - works as expected.

For @RHo quik review
(1) Add image is not usable in horizontal mode (I believe it was never intended to be)

(2)

The user should not be able to actually change the text or elements of the article in any way, except through the image suggestions.

When links in an article are clicked - they become underlined; otherwise, there are no other effects.