Page MenuHomePhabricator

Central notice projects and language choices not loading
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Open (with appropriate rights) a banner in the central notice interface
  • You'll notice that all languages and project fields are empty
  • happens with both enabled and not enabled banners

What happens?:
Cannot change or set central notice banners

What should have happened instead?:

  • all languages and projects should load

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Screenshot 2021-09-20 at 18-53-57 Central notice admin - Meta.png (895×1 px, 46 KB)

Event Timeline

It loads briefly as plain text, then we get the blank blue boxes, so this is aparently a rendering issue somewhere.

Pcoombe triaged this task as Unbreak Now! priority.Mon, Sep 20, 5:32 PM

The entries are having CSS class "ui-helper-hidden" applied. Removing this makes them visible, but clicking to add/remove them results in a javascript error:

Uncaught TypeError: Cannot read properties of undefined (reading 'prop')
    at $.<computed>.<computed>._setSelected (<anonymous>:368:952)
    at $.<computed>.<computed>._setSelected (load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|jquery.plugin.jstree|jquery.ui&skin=vector&version=109wb:578)
    at HTMLAnchorElement.<anonymous> (<anonymous>:371:557)
    at HTMLAnchorElement.dispatch (load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|jquery.plugin.jstree|jquery.ui&skin=vector&version=109wb:70)
    at HTMLAnchorElement.elemData.handle (load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|jquery.plugin.jstree|jquery.ui&skin=vector&version=109wb:66)

Triaging as UBN as this makes it impossible to make certain changes to campaigns or create new ones.

Have to log off now, but I dug around and think this must be related to the removal of jQuery Migrate (T280944) from Meta earlier today.

@Pcoombe that looks like exactly the cause! Locally I can see the breakage with that setting false, but the multiselect works properly with wgIncludejQueryMigrate = true;

Change 722404 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/mediawiki-config@master] Revert \"Disable jQuery Migrate on group1\"

https://gerrit.wikimedia.org/r/722404

Change 722404 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert \"Disable jQuery Migrate on group1\"

https://gerrit.wikimedia.org/r/722404

Mentioned in SAL (#wikimedia-operations) [2021-09-20T19:45:58Z] <legoktm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Revert "Disable jQuery Migrate on group1" (T291410) (duration: 00m 56s)

Thanks so so much for this fix @Legoktm. CentralNotice is now working again! Thanks also @Ciell, @Pharos, @Pcoombe, @DStrine, @Ejegg :)

This should be seen as a temporary fix. This morning a Mediawiki config change was rolled out, and was just reverted for this. However we're now blocking T280944. The real fix will be to remove the unmaintained widget that CentralNotice uses for these bits of campaign config.

Thank you for this quick action!

Zabe lowered the priority of this task from Unbreak Now! to High.Tue, Sep 21, 2:23 PM

This has been quickly fixed on meta. So I would no longer count this as UBN since it is only blocking the removal of jQuery Migrate v3 and longer actually breaking things on production.

Change 722695 had a related patch set uploaded (by AndyRussG; author: AndyRussG):

[mediawiki/extensions/CentralNotice@master] Close all tags in multiselect for jQuery update

https://gerrit.wikimedia.org/r/722695

Change 722695 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Close all tags in multiselect for jQuery update

https://gerrit.wikimedia.org/r/722695