New wikidiff2 version has broken ProofreadPage's PageSlotDiffRendererTest::testGetDiff and MW's REST API DiffCompare test
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Zabe
	Oct 6 2021, 9:04 PM

Description

20:49:52 There were 2 failures:
20:49:52 
20:49:52 1) ProofreadPage\Page\PageSlotDiffRendererTest::testGetDiff with data set #1 (null, ProofreadPage\Page\PageContent Object (...), 'Page statusPage status-Not pr...ooter ')
20:49:52 Failed asserting that two strings are identical.
20:49:52 --- Expected
20:49:52 +++ Actual
20:49:52 @@ @@
20:49:52 -'Page statusPage status-Not proofread+ProblematicHeader (noinclude):Header (noinclude): + header Page body (to be transcluded):Page body (to be transcluded): + body2 Footer (noinclude):Footer (noinclude): + footer '
20:49:52 +'Page statusPage status-Not proofread+ProblematicHeader (noinclude):Header (noinclude): header Page body (to be transcluded):Page body (to be transcluded): body2 Footer (noinclude):Footer (noinclude): footer '
20:49:52 
20:49:52 /workspace/src/extensions/ProofreadPage/tests/phpunit/Page/PageSlotDiffRendererTest.php:52
20:49:52 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:452
20:49:52 === Logs generated by test case
20:49:52 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
20:49:52 [localisation] [debug] LocalisationCache using store LCStoreNull []
20:49:52 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
20:49:52 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
20:49:52 [localisation] [debug] LocalisationCache using store LCStoreNull []
20:49:52 [ContentHandler] [info] Registered handler for wikitext: WikitextContentHandler []
20:49:52 [ContentHandler] [info] Registered handler for proofread-page: ProofreadPage\Page\PageContentHandler []
20:49:52 [GlobalTitleFail] [info] RequestContext::getTitle called with no title set. {"exception":{}}
20:49:52 [objectcache] [debug] MainObjectStash using store {class} {"class":"HashBagOStuff"}
20:49:52 [localisation] [debug] LocalisationCache::isExpired(en): cache missing, need to make one []
20:49:52 [wfDebug] [debug] ParserFactory: using default preprocessor {"private":false}
20:49:52 [localisation] [debug] LocalisationCache::isExpired(en): cache missing, need to make one []
20:49:52 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"thisWikiIsTheRepo","logValue":"true"}
20:49:52 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"entitySources","logValue":"array (\n  'local' => \n  array (\n    'entityNamespaces' => \n    array (\n      'item' => 120,\n      'property' => 122,\n      'mediainfo' => '6\/mediainfo',\n    ),\n    'repoDatabase' => false,\n    'baseUri' => 'http:\/\/127.0.0.1:9412\/entity\/',\n    'rdfNodeNamespacePrefix' => 'wd',\n    'rdfPredicateNamespacePrefix' => '',\n    'interwikiPrefix' => '',\n  ),\n)"}
20:49:52 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"entitySources","logValue":"array (\n  'local' => \n  array (\n    'repoDatabase' => false,\n    'entityNamespaces' => \n    array (\n      'item' => '120\/main',\n      'property' => '122\/main',\n      'mediainfo' => '6\/mediainfo',\n    ),\n    'baseUri' => 'http:\/\/127.0.0.1:9412\/entity\/',\n    'rdfNodeNamespacePrefix' => 'wd',\n    'rdfPredicateNamespacePrefix' => '',\n    'interwikiPrefix' => '',\n  ),\n)"}
20:49:52 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"itemAndPropertySourceName","logValue":"'local'"}
20:49:52 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"siteGlobalID","logValue":"'wikidb'"}
20:49:52 [wfDebug] [debug] DifferenceEngine old '0' new '0' rcid '0' {"private":false}
20:49:52 [wfDebug] [debug] DifferenceEngine old '0' new '0' rcid '0' {"private":false}
20:49:52 [wfDebug] [debug] DifferenceEngine old '0' new '0' rcid '0' {"private":false}
20:49:52 ===
20:49:52 
20:49:52 2) ProofreadPage\Page\PageSlotDiffRendererTest::testGetDiff with data set #2 (ProofreadPage\Page\PageContent Object (...), null, 'Page statusPage status-Proble...ooter ')
20:49:52 Failed asserting that two strings are identical.
20:49:52 --- Expected
20:49:52 +++ Actual
20:49:52 @@ @@
20:49:52 -'Page statusPage status-Problematic+Not proofreadHeader (noinclude):Header (noinclude): - header Page body (to be transcluded):Page body (to be transcluded): - body Footer (noinclude):Footer (noinclude): - footer '
20:49:52 +'Page statusPage status-Problematic+Not proofreadHeader (noinclude):Header (noinclude): header Page body (to be transcluded):Page body (to be transcluded): body Footer (noinclude):Footer (noinclude): footer '
20:49:52 
20:49:52 /workspace/src/extensions/ProofreadPage/tests/phpunit/Page/PageSlotDiffRendererTest.php:52
20:49:52 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:452
20:49:52 === Logs generated by test case
20:49:52 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
20:49:52 [localisation] [debug] LocalisationCache using store LCStoreNull []
20:49:52 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
20:49:52 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
20:49:52 [localisation] [debug] LocalisationCache using store LCStoreNull []
20:49:52 [ContentHandler] [info] Registered handler for wikitext: WikitextContentHandler []
20:49:52 [ContentHandler] [info] Registered handler for proofread-page: ProofreadPage\Page\PageContentHandler []
20:49:52 [GlobalTitleFail] [info] RequestContext::getTitle called with no title set. {"exception":{}}
20:49:52 [objectcache] [debug] MainObjectStash using store {class} {"class":"HashBagOStuff"}
20:49:52 [localisation] [debug] LocalisationCache::isExpired(en): cache missing, need to make one []
20:49:52 [wfDebug] [debug] ParserFactory: using default preprocessor {"private":false}
20:49:52 [localisation] [debug] LocalisationCache::isExpired(en): cache missing, need to make one []
20:49:52 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"thisWikiIsTheRepo","logValue":"true"}
20:49:52 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"entitySources","logValue":"array (\n  'local' => \n  array (\n    'entityNamespaces' => \n    array (\n      'item' => 120,\n      'property' => 122,\n      'mediainfo' => '6\/mediainfo',\n    ),\n    'repoDatabase' => false,\n    'baseUri' => 'http:\/\/127.0.0.1:9412\/entity\/',\n    'rdfNodeNamespacePrefix' => 'wd',\n    'rdfPredicateNamespacePrefix' => '',\n    'interwikiPrefix' => '',\n  ),\n)"}
20:49:52 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"entitySources","logValue":"array (\n  'local' => \n  array (\n    'repoDatabase' => false,\n    'entityNamespaces' => \n    array (\n      'item' => '120\/main',\n      'property' => '122\/main',\n      'mediainfo' => '6\/mediainfo',\n    ),\n    'baseUri' => 'http:\/\/127.0.0.1:9412\/entity\/',\n    'rdfNodeNamespacePrefix' => 'wd',\n    'rdfPredicateNamespacePrefix' => '',\n    'interwikiPrefix' => '',\n  ),\n)"}
20:49:52 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"itemAndPropertySourceName","logValue":"'local'"}
20:49:52 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"siteGlobalID","logValue":"'wikidb'"}
20:49:52 [wfDebug] [debug] DifferenceEngine old '0' new '0' rcid '0' {"private":false}
20:49:52 [wfDebug] [debug] DifferenceEngine old '0' new '0' rcid '0' {"private":false}
20:49:52 [wfDebug] [debug] DifferenceEngine old '0' new '0' rcid '0' {"private":false}
20:49:52 ===
20:49:52 
20:49:52 FAILURES!
20:49:52 Tests: 24385, Assertions: 79577, Failures: 2, Skipped: 100.

Details

Subject	Repo	Branch	Lines +/-
PageSlotDiffRendererTest::testGetDiff: Skip as new wikidiff2 breaks this test	mediawiki/extensions/ProofreadPage	REL1_35	+4 -2
api-testing: Adjust DiffCompare expected outcome to cope with new wikidiff2 output	mediawiki/core	wmf/1.38.0-wmf.2	+2 -2
api-testing: Adjust DiffCompare expected outcome to cope with new wikidiff2 output	mediawiki/core	wmf/1.38.0-wmf.3	+2 -2
PageSlotDiffRendererTest::testGetDiff: Skip as new wikidiff2 breaks this test	mediawiki/extensions/ProofreadPage	wmf/1.38.0-wmf.2	+4 -2
PageSlotDiffRendererTest::testGetDiff: Skip as new wikidiff2 breaks this test	mediawiki/extensions/ProofreadPage	wmf/1.38.0-wmf.3	+4 -2
api-testing: Adjust DiffCompare expected outcome to cope with new wikidiff2 output	mediawiki/core	master	+2 -2
PageSlotDiffRendererTest::testGetDiff: Skip as new wikidiff2 breaks this test	mediawiki/extensions/ProofreadPage	master	+4 -2

Customize query in gerrit

Related Objects

Mentioned In: T293022: LivePreview doesn't work with ProofreadPage pages
Mentioned Here: T285857: Deploy wikidiff2 1.13.0
T285956: Lock selection to a single side in TableDiffFormatter

Event Timeline

Zabe created this task.Oct 6 2021, 9:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 6 2021, 9:04 PM

RhinosF1 triaged this task as Unbreak Now! priority.Oct 6 2021, 9:05 PM

Restricted Application added a subscriber: RhinosF1. · View Herald TranscriptOct 6 2021, 9:05 PM

It looks like CI for core and multiple extensions is failing. At least GrowthExperiments, TemplateData and VisualEditor, probably many more.

Zabe renamed this task from mediawiki/core CI fails with 'Failed asserting that two strings are identical.' to ProofreadPage\Page\PageSlotDiffRendererTest::testGetDif makes CI fail with 'Failed asserting that two strings are identical.'.Oct 6 2021, 9:07 PM

Zabe merged a task: T292677: ProofreadPage\Page\PageSlotDiffRendererTest::testGetDiff test failures preventing all merges.

Zabe added a subscriber: matmarex.

Zabe added a project: ProofreadPage.Oct 6 2021, 9:09 PM

https://github.com/wikimedia/integration-config/commit/a0e7e3ebe2a04327238a1d76a70c34638a7c3dbd might fit into the timeline but I'm not 100%. Pinged James on irc.

Btw. there is a second failure, see https://gerrit.wikimedia.org/r/c/mediawiki/core/+/726953. Very likely happening for the same reason as the other error.

21:00:52   253 passing (48s)
21:00:52   1 pending
21:00:52   2 failing
21:00:52 
21:00:52   1) Diff Compare with Variables
21:00:52        should compare revisions 1 and 4:
21:00:52      AssertionError: expected '<tr>\n  <td colspan="2" class="diff-lineno">Line 1:</td>\n  <td colspan="2" class="diff-lineno">Line 1:</td>\n</tr>\n<tr>\n  <td class="diff-marker"></td>\n  <td class="diff-context diff-side-deleted"><div>Counting: </div></td>\n  <td class="diff-marker"></td>\n  <td class="diff-context diff-side-added"><div>Counting: </div></td>\n</tr>\n<tr>\n  <td class="diff-marker" data-marker="−"></td>\n  <td class="diff-deletedline diff-side-deleted"><div>* One</div></td>\n  <td class="diff-marker" data-marker="+"></td>\n  <td class="diff-addedline diff-side-added"><div>* One<ins class="diffchange diffchange-inline"> </ins></div></td>\n</tr>\n<tr>\n  <td colspan="2" class="diff-empty diff-side-deleted"></td>\n  <td class="diff-marker" data-marker="+"></td>\n  <td class="diff-addedline diff-side-added"><div>* Two</div></td>\n</tr>\n' to match /<td class=.diff-addedline.>.*\* Two/
21:00:52       at Context.it (tests/api-testing/action/DiffCompare.js:39:10)
21:00:52       at process._tickCallback (internal/process/next_tick.js:68:7)
21:00:52 
21:00:52   2) Diff Compare with Variables
21:00:52        should compare revisions 3 and 4:
21:00:52      AssertionError: expected '<tr>\n  <td colspan="2" class="diff-lineno">Line 1:</td>\n  <td colspan="2" class="diff-lineno">Line 1:</td>\n</tr>\n<tr>\n  <td class="diff-marker"></td>\n  <td class="diff-context diff-side-deleted"><div>Counting: </div></td>\n  <td class="diff-marker"></td>\n  <td class="diff-context diff-side-added"><div>Counting: </div></td>\n</tr>\n<tr>\n  <td class="diff-marker"></td>\n  <td class="diff-context diff-side-deleted"><div>* One </div></td>\n  <td class="diff-marker"></td>\n  <td class="diff-context diff-side-added"><div>* One </div></td>\n</tr>\n<tr>\n  <td class="diff-marker" data-marker="−"></td>\n  <td class="diff-deletedline diff-side-deleted"><div>* Two<del class="diffchange diffchange-inline"> </del></div></td>\n  <td class="diff-marker" data-marker="+"></td>\n  <td class="diff-addedline diff-side-added"><div>* Two</div></td>\n</tr>\n<tr>\n  <td class="diff-marker" data-marker="−"></td>\n  <td class="diff-deletedline diff-side-deleted"><div>* Three</div></td>\n  <td colspan="2" class="diff-empty diff-side-added"></td>\n</tr>\n' to match /<td class=.diff-deletedline.>.*\* Three/
21:00:52       at Context.it (tests/api-testing/action/DiffCompare.js:45:10)
21:00:52       at process._tickCallback (internal/process/next_tick.js:68:7)

Another failure at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CodeEditor/+/726940/ (build output)

The most likely cause is the addition of diff-side-deleted which made the (fragile) regex no longer match. Ref T285956, T285857, which just released the relevant change to php-wikidiff2 to Beta and thus likely CI as well.

I think in this case it's a fair failure and the test should be fixed to be a bit more permissive.

Currently:

input: '… <td class="diff-context diff-side-deleted"> … '
regex: /<td class=.diff-deletedline.>.*\* Three/

For example: /<td [^>]*class=[^>]*diff-deletedline[^>]*>.*\* Three/

DannyS712 subscribed.Oct 6 2021, 9:35 PM

Jdforrester-WMF subscribed.Oct 6 2021, 10:04 PM

Another failure on https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/726663

Jdforrester-WMF renamed this task from ProofreadPage\Page\PageSlotDiffRendererTest::testGetDiff makes CI fail with 'Failed asserting that two strings are identical.' to New wikidiff2 version has broken ProofreadPage's PageSlotDiffRendererTest::testGetDiff as it's doing an exact string match.Oct 6 2021, 10:14 PM

Jdforrester-WMF added a project: wikidiff2.

Change 726987 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/ProofreadPage@master] PageSlotDiffRendererTest::testGetDiff: Skip as new wikidiff2 breaks this test

https://gerrit.wikimedia.org/r/726987

gerritbot added a project: Patch-For-Review.Oct 6 2021, 10:15 PM

Change 726989 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] api-testing: Adjust DiffCompare expected outcome to cope with new wikidiff2 output

https://gerrit.wikimedia.org/r/726989

Hmm, yes, MW's own REST API tests are using a regex test but assuming only the single class on its TD element.

NOTE: Fails on this patch too: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/726986

In T292676#7407015, @xSavitar wrote:

NOTE: Fails on this patch too: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/726986

Yes, it'll fail every patch in the world right now, hence UBN. :-)

Jdforrester-WMF renamed this task from New wikidiff2 version has broken ProofreadPage's PageSlotDiffRendererTest::testGetDiff as it's doing an exact string match to New wikidiff2 version has broken ProofreadPage's PageSlotDiffRendererTest::testGetDiff and MW's REST API DiffCompare test.Oct 6 2021, 10:34 PM

Daimona subscribed.Oct 6 2021, 10:56 PM

Change 726987 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] PageSlotDiffRendererTest::testGetDiff: Skip as new wikidiff2 breaks this test

https://gerrit.wikimedia.org/r/726987

Change 726989 merged by jenkins-bot:

[mediawiki/core@master] api-testing: Adjust DiffCompare expected outcome to cope with new wikidiff2 output

https://gerrit.wikimedia.org/r/726989

OK, this should now be resolved. If any other extension or other repo's test suite is broken, please comment here or open a new task.

In T292676#7406942, @Zabe wrote:

Btw. there is a second failure, see https://gerrit.wikimedia.org/r/c/mediawiki/core/+/726953. Very likely happening for the same reason as the other error.

~~This is a different failure that I think requires a different fix. Appears to come from Core's api-testing/action/DiffCompare.js~~

sorry I see https://gerrit.wikimedia.org/r/c/mediawiki/core/+/726989/ now :)

Maintenance_bot removed a project: Patch-For-Review.Oct 6 2021, 11:10 PM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.4; 2021-10-12).Oct 7 2021, 12:00 AM

Change 726959 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/ProofreadPage@wmf/1.38.0-wmf.3] PageSlotDiffRendererTest::testGetDiff: Skip as new wikidiff2 breaks this test

https://gerrit.wikimedia.org/r/726959

Change 726960 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/ProofreadPage@wmf/1.38.0-wmf.2] PageSlotDiffRendererTest::testGetDiff: Skip as new wikidiff2 breaks this test

https://gerrit.wikimedia.org/r/726960

Change 726961 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@wmf/1.38.0-wmf.3] api-testing: Adjust DiffCompare expected outcome to cope with new wikidiff2 output

https://gerrit.wikimedia.org/r/726961

Change 726962 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@wmf/1.38.0-wmf.2] api-testing: Adjust DiffCompare expected outcome to cope with new wikidiff2 output

https://gerrit.wikimedia.org/r/726962

Change 726959 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@wmf/1.38.0-wmf.3] PageSlotDiffRendererTest::testGetDiff: Skip as new wikidiff2 breaks this test

https://gerrit.wikimedia.org/r/726959

Change 726960 merged by Ladsgroup:

[mediawiki/extensions/ProofreadPage@wmf/1.38.0-wmf.2] PageSlotDiffRendererTest::testGetDiff: Skip as new wikidiff2 breaks this test

https://gerrit.wikimedia.org/r/726960

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.3; 2021-10-05); removed MW-1.38-notes (1.38.0-wmf.4; 2021-10-12).Oct 7 2021, 3:00 PM

Change 726961 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.3] api-testing: Adjust DiffCompare expected outcome to cope with new wikidiff2 output

https://gerrit.wikimedia.org/r/726961

Change 726962 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.2] api-testing: Adjust DiffCompare expected outcome to cope with new wikidiff2 output

https://gerrit.wikimedia.org/r/726962

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.2; 2021-09-28); removed MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 7 2021, 4:00 PM

Zabe removed a project: Patch-For-Review.Oct 9 2021, 7:54 PM

Note that the ProofreadPage test failure was not a broken test, it detected actual breakage. ProofreadPage stores multiple semi-structured parts of a page using noinclude sections (it predates MCR and other relevant facilities), and then hides these from users by hooking into the diff.

See this page: open it for editing and hit "Show changes". The displayed diff should be empty, but isn't.

In T292676#7416732, @Xover wrote:

Note that the ProofreadPage test failure was not a broken test, it detected actual breakage. ProofreadPage stores multiple semi-structured parts of a page using noinclude sections (it predates MCR and other relevant facilities), and then hides these from users by hooking into the diff.

The new version of wikidiff2 only changes the HTML output, and nothing is expected to break, unless somebody is parsing the resulting HTML with 0 flexibility, which is something that shouldn't happen and is error-prone anyway.

See this page: open it for editing and hit "Show changes". The displayed diff should be empty, but isn't.

Cannot reproduce, the diff is empty for me, as it should be.

xSavitar awarded a token.Oct 11 2021, 1:07 PM

In T292676#7417079, @Daimona wrote:

In T292676#7416732, @Xover wrote:

See this page: open it for editing and hit "Show changes". The displayed diff should be empty, but isn't.

Cannot reproduce, the diff is empty for me, as it should be.

Oh, interesting. Doesn't happen when logged out, so clearly something more or something else is going on. That particular failure at this particular time is kinda suspicious though.

In T292676#7417079, @Daimona wrote:

In T292676#7416732, @Xover wrote:

See this page: open it for editing and hit "Show changes". The displayed diff should be empty, but isn't.

Cannot reproduce, the diff is empty for me, as it should be.

Ah. It seems to be dependent on the Editing → Show previews without reloading the page setting being turned on in Preferences. When that pref is on it shows:

2021-10-11_160516_1464x758_screenshot.png (758×1 px, 248 KB)

When it's off I get a clean diff.

Krinkle reopened this task as Open.Oct 11 2021, 5:29 PM

Krinkle closed this task as Resolved.

Krinkle lowered the priority of this task from Unbreak Now! to High.

Krinkle mentioned this in T293022: LivePreview doesn't work with ProofreadPage pages.

Zabe raised the priority of this task from High to Unbreak Now!.Oct 11 2021, 5:53 PM

Zabe removed a project: User-Zabe.Apr 13 2022, 12:47 AM

hashar removed a project: Continuous-Integration-Config.Apr 19 2022, 1:08 PM

Change 884331 had a related patch set uploaded (by Umherirrender; author: Jforrester):

[mediawiki/extensions/ProofreadPage@REL1_35] PageSlotDiffRendererTest::testGetDiff: Skip as new wikidiff2 breaks this test

https://gerrit.wikimedia.org/r/884331

gerritbot added a project: Patch-For-Review.Jan 27 2023, 8:14 PM

Change 884331 merged by jenkins-bot: